Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image.pullSecrets configuration for NewDDAWithOperator #1327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Dec 27, 2024

What does this PR do?

Fix the image.pullSecrets configuration when creating a new DDA resource with the NewDDAWithOperator component. image.pullSecrets should be a list of secret names, not a map.

Which scenarios this will impact?

aws/KindVM

Motivation

bugfix

Additional Notes

@fanny-jiang fanny-jiang marked this pull request as ready for review December 27, 2024 23:58
@fanny-jiang fanny-jiang requested a review from a team as a code owner December 27, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant