Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Improve parametric Java client #3740

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Dec 23, 2024

Motivation

I looked at the changelog and found weird changes.

Changes

  • Fix /trace/config DTO
  • Fix span contexts not being cleared
  • Fix span parent not found error not handled
  • Refactor OpenTelemetry type conversions into a dedicated helper Refactor config access into a dedicated helper
  • Refactor span contexts usage
  • Clean up no more used OpenTelemetry and OpenTracing endpoint DTOs

In addition, I also update to latest versions of Spring Boot, OTel API and JDK LTS.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@PerfectSlayer PerfectSlayer added java Pull requests that update Java code run-parametric-scenario labels Dec 23, 2024
@PerfectSlayer PerfectSlayer changed the title Improve parametric Java client [java] Improve parametric Java client Dec 23, 2024
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from 1278236 to 2efc8f5 Compare December 23, 2024 15:40
Fix /trace/config DTO
Fix span contexts not being cleared
Fix span parent not found error not handled
Refactor OpenTelemetry type conversions into a dedicated helper
Refactor config access into a dedicated helper
Refactor span contexts usage
Clean up no more used OpenTelemetry and OpenTracing endpoint DTOs
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from 2efc8f5 to b52b29a Compare December 31, 2024 05:56
Use the latest framework, API and JDK LTS versions
@PerfectSlayer PerfectSlayer marked this pull request as ready for review December 31, 2024 06:29
@PerfectSlayer PerfectSlayer requested review from a team as code owners December 31, 2024 06:29
@PerfectSlayer PerfectSlayer merged commit ff77b03 into main Dec 31, 2024
53 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/parametric-otel-java branch December 31, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants