-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: install dev package in its own prefix #209
Conversation
a8b19fa
to
27c9eed
Compare
27c9eed
to
3c3a869
Compare
I tried installing riot from this branch and this caused the build_base_venvs job to fail (at least with python2.7) |
Something interesting I noticed is that pip logs the following error in cherrypy when riot venvs are created (link)
Is this expected? Would this fix also address this error? |
It looks like the dev package is not being installed. That's when the dependencies are installed with this change. I wonder if there are some changes still needed to support the lockfiles, or if they have to be re-generated. Tagging @emmettbutler as I'm not that familiar with how that part of riot works. |
3c3a869
to
96df281
Compare
0f7d0b8
to
67229cd
Compare
This prevents any dependency layers from removing the dev package dependencies from the base environment.
67229cd
to
59c014a
Compare
With this fix we are able to build base envs in dd-trace-py ci: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/36413/workflows/5058b2b6-b4e1-45f1-8b34-531217eb88ac/jobs/2456864, however it causes a different set: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py?branch=munir%2Funblock-ci |
Ah! Having moved the library to a different prefix, we also need to update the |
7046f3d
to
e4073f6
Compare
Hmmm we still experiencing issues installing packages: import error, PR. Ideally these issues should be caught by riot tests. Can we add a regression test? Also this hot fix has a lot complexity and could be difficult to debug/maintain. Can we simplify it a bit 😅 |
Ah I think the slotscheck issue is to be expected since the dev package is no longer installed in the base venv. We would have to check whether the new site-packages is ending up in the PYTHONPATH. If not we need to somehow add it, but I'm not sure this is something to address in riot.
I'm afraid I don't have anything simpler to propose 🙁 |
I skipped the slotcheck
I skipped the slotscheck in this PR and now most test runs are failing due import errors: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/36927/workflows/209ef960-c85f-4763-9ce1-727e5c1bdc92. I am not sure if this new issue should be fixed in riot or if we need to update the @P403n1x87 any thoughts on what we should try next? |
🤔 it looks like there are different kinds of failures. The ones failing to import |
Superseded by #212 |
Resolves: #211
This prevents any dependency layers from removing the dev package dependencies from the base environment.