Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatadogAgent] Unable to override topologySpreadConstraints #1454

Closed
starlightromero opened this issue Jul 12, 2024 · 3 comments
Closed

[DatadogAgent] Unable to override topologySpreadConstraints #1454

starlightromero opened this issue Jul 12, 2024 · 3 comments
Labels
chart/datadog-operator This issue or pull request is related to the datadog-operator chart waiting-user-feedback

Comments

@starlightromero
Copy link

Describe what happened:

A user is unable to override topologySpreadConstraints on the DatadogAgent custom resource.

kubectl explain DatadogAgent.spec.override
GROUP:      datadoghq.com
KIND:       DatadogAgent
VERSION:    v2alpha1

FIELD: override <map[string]Object>


DESCRIPTION:
    <empty>
FIELDS:
  affinity	<Object>
    <no description>

  annotations	<map[string]string>
    <no description>

  containers	<map[string]Object>
    <no description>

  createRbac	<boolean>
    <no description>

  customConfigurations	<map[string]Object>
    <no description>

  disabled	<boolean>
    <no description>

  env	<[]Object>
    <no description>

  extraChecksd	<Object>
    <no description>

  extraConfd	<Object>
    <no description>

  hostNetwork	<boolean>
    <no description>

  hostPID	<boolean>
    <no description>

  image	<Object>
    <no description>

  labels	<map[string]string>
    <no description>

  name	<string>
    <no description>

  nodeSelector	<map[string]string>
    <no description>

  priorityClassName	<string>
    <no description>

  replicas	<integer>
    <no description>

  securityContext	<Object>
    <no description>

  serviceAccountName	<string>
    <no description>

  tolerations	<[]Object>
    <no description>

  volumes	<[]Object>
    <no description>

Describe what you expected:

topologySpreadConstraints could be modified

Steps to reproduce the issue:

Set topologySpreadContraints on the manifest and apply.

---
apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  ...
spec:
  override:
    nodeAgent:
      topologySpreadConstraints:
      - maxSkew: 1
        topologyKey: topology.kubernetes.io/zone
        whenUnsatisfiable: ScheduleAnyway        

Additional environment details (Operating System, Cloud provider, etc):

@levan-m
Copy link
Contributor

levan-m commented Jul 26, 2024

Hello, thanks for raising this question! Could you please submit a feature request in the Datadog Operator repo and close this one.

@levan-m levan-m added waiting-user-feedback chart/datadog-operator This issue or pull request is related to the datadog-operator chart labels Jul 26, 2024
@alee2233
Copy link

alee2233 commented Oct 9, 2024

Actually, the node agent is a daemonset, so topology spread constraints shouldn't apply right?

EDIT: TSCs would still be relevant for the other components like Cluster Agent

@starlightromero
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog-operator This issue or pull request is related to the datadog-operator chart waiting-user-feedback
Projects
None yet
Development

No branches or pull requests

3 participants