Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis command_args end up in APM despite being disabled #4227

Open
farnoy opened this issue Dec 16, 2024 · 1 comment
Open

Redis command_args end up in APM despite being disabled #4227

farnoy opened this issue Dec 16, 2024 · 1 comment
Labels
bug Involves a bug community Was opened by a community member

Comments

@farnoy
Copy link

farnoy commented Dec 16, 2024

Current behaviour
Command arguments are submitted in the span, despite this setting being disabled.

Expected behaviour
I wanted to just see commands like GET, SET without arguments.

Steps to reproduce

  1. Instrument Redis
  2. Use Rails.cache
  3. Observe cache keys as arguments to the GET command

Environment

  • datadog version: 1.23 but this instrumentation hasn't changed through 2.8
  • Configuration block (Datadog.configure ...):
c.tracing.instrument :redis,
                      describes: { url: redis_url },
                      service_name: "#{service_base_name}-redis"
  • Ruby version: 3.3.6
  • Operating system: linux x64
  • Relevant library versions:
     ddtrace (1.23.3)
       datadog-ci (~> 0.8.1)
       debase-ruby_core_source (= 3.3.1)
       libdatadog (~> 7.0.0.1.0)
       libddwaf (~> 1.14.0.0.0)
       msgpack
@farnoy farnoy added bug Involves a bug community Was opened by a community member labels Dec 16, 2024
@farnoy
Copy link
Author

farnoy commented Dec 16, 2024

Oh and I did verify that it gets disabled properly:

        :command_args=>
          #<Datadog::Core::Configuration::Option:0x00007fb9804235d8
           @context=#<Datadog::Tracing::Contrib::Redis::Configuration::Settings:0x00007fb98a865fb0 ...>,
           @definition=
            #<Datadog::Core::Configuration::OptionDefinition:0x00007fb9948b9430
             @after_set=nil,
             @default=false,
             @default_proc=nil,
             @deprecated_env=nil,
             @env="DD_REDIS_COMMAND_ARGS",
             @env_parser=nil,
             @name=:command_args,
             @resetter=nil,
             @setter=
              #<Proc:0x00007fb993e7ab68 /app/vendor/bundle/ruby/3.3.0/gems/ddtrace-1.23.3/lib/datadog/core/configuration/opt
ion_definition.rb:10 (lambda)>,
             @type=:bool,
             @type_options={:nilable=>false}>,
           @is_set=true,
           @precedence_set=#<struct Datadog::Core::Configuration::Option::Precedence::Value numeric=
1, name=:programmatic>,
           @value=false,
           @value_per_precedence=
            {#<struct Datadog::Core::Configuration::Option::Precedence::Value numeric=1, name=
:programmatic>=>false}>,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member
Projects
None yet
Development

No branches or pull requests

1 participant