Skip to content

Commit 293ea19

Browse files
committed
[NO-TICKET] Relax profiling CODEOWNERS configuration
**What does this PR do?** This PR relaxes the GitHub `CODEOWNERS` file rules for things related to profiling. Specifically, it adds `@DataDog/ruby-guild` as a second owner on top of just `@DataDog/profiling-rb`. **Motivation:** Now that we've enableed the "Require review from Code Owners" feature on GitHub, since there's not a lot of us working on profiling, it hasn't worked very well. Specifically, for very small PRs (#4072 is a good example where we slightly tweaked a test to avoid flakiness), it's annoying to have to wait for a very small reviewer pool, when most folks that are on the Ruby guild can help out review such changes. **Additional Notes:** N/A **How to test the change?** Check that future PRs affecting profiling can be merged with a review from anyone on the ruby-guild team.
1 parent c7d75d6 commit 293ea19

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/CODEOWNERS

+7-7
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
/lib/datadog/opentelemetry/ @DataDog/tracing-ruby
1414
/lib/datadog/opentelemetry.rb @DataDog/tracing-ruby
1515
/lib-injection/ @DataDog/tracing-ruby
16-
/lib/datadog/profiling/ @DataDog/profiling-rb
17-
/lib/datadog/profiling.rb @DataDog/profiling-rb
18-
/ext/ @DataDog/profiling-rb
16+
/lib/datadog/profiling/ @DataDog/profiling-rb @DataDog/ruby-guild
17+
/lib/datadog/profiling.rb @DataDog/profiling-rb @DataDog/ruby-guild
18+
/ext/ @DataDog/profiling-rb @DataDog/ruby-guild
1919

2020
# RBS signatures
2121
/sig/datadog/appsec/ @DataDog/asm-ruby
@@ -25,8 +25,8 @@
2525
/sig/datadog/tracing.rbs @DataDog/tracing-ruby
2626
/sig/datadog/opentelemetry/ @DataDog/tracing-ruby
2727
/sig/datadog/opentelemetry.rbs @DataDog/tracing-ruby
28-
/sig/datadog/profiling/ @DataDog/profiling-rb
29-
/sig/datadog/profiling.rbs @DataDog/profiling-rb
28+
/sig/datadog/profiling/ @DataDog/profiling-rb @DataDog/ruby-guild
29+
/sig/datadog/profiling.rbs @DataDog/profiling-rb @DataDog/ruby-guild
3030

3131
# Specs
3232
/spec/datadog/appsec/ @DataDog/asm-ruby
@@ -35,5 +35,5 @@
3535
/spec/datadog/tracing_spec.rb @DataDog/tracing-ruby
3636
/spec/datadog/opentelemetry/ @DataDog/tracing-ruby
3737
/spec/datadog/opentelemetry_spec.rb @DataDog/tracing-ruby
38-
/spec/datadog/profiling/ @DataDog/profiling-rb
39-
/spec/datadog/profiling_spec.rb @DataDog/profiling-rb
38+
/spec/datadog/profiling/ @DataDog/profiling-rb @DataDog/ruby-guild
39+
/spec/datadog/profiling_spec.rb @DataDog/profiling-rb @DataDog/ruby-guild

0 commit comments

Comments
 (0)