Skip to content

Commit fbde764

Browse files
juanjuxavara1986
andauthored
chore(iast): fix idna package test (#10377)
## Description - Fix IDNA package test. - Make the warning about a package that was marked as failing now working a warning (xfail). Signed-off-by: Juanjo Alvarez <[email protected]> ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Signed-off-by: Juanjo Alvarez <[email protected]> Co-authored-by: Alberto Vara <[email protected]>
1 parent ee75b12 commit fbde764

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Diff for: tests/appsec/iast_packages/test_packages.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ def uninstall(self, python_cmd):
290290
"xn--eckwd4c7c.xn--zckzah",
291291
import_module_to_validate="idna.codec",
292292
test_propagation=True,
293-
fixme_propagation_fails=False,
294293
),
295294
PackageForTesting(
296295
"importlib-resources",
@@ -885,7 +884,7 @@ def _assert_propagation_results(response, package):
885884
if package.fixme_propagation_fails is not None:
886885
if result_ok:
887886
if package.fixme_propagation_fails: # For packages that are reliably failing
888-
pytest.fail(
887+
pytest.xfail(
889888
"FIXME: Test passed unexpectedly, consider changing to fixme_propagation_fails=False for package %s"
890889
% package.name
891890
)

0 commit comments

Comments
 (0)