Commit 9c89921
authored
fix(profiling): upgrade echion to fix segfaults from services with many
Comparison:
P403n1x87/echion@158a50f...576ff53
This upgrade includes two PRs from Echion
- [fix: copy ob_digit field in PyLongObject before
dereferencing](P403n1x87/echion#133) by
@taegyunkim
- [perf: use std::this_thread::sleep_for instead of busy
loop](P403n1x87/echion#132) by @KowalskiThomas
Note the perf change only applies to echion standalone mode, and
`dd-trace-py` has already been using `std::this_thread::sleep_until`
since stack_v2 was introduced
https://github.com/DataDog/dd-trace-py/blob/d90eb4fbe59f0fc0a205c49f321edbdb76c6b155/ddtrace/internal/datadog/profiling/stack_v2/src/sampler.cpp#L177
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)asyncio.Tasks (#14630)1 parent fcacd83 commit 9c89921
File tree
2 files changed
+6
-1
lines changed- ddtrace/internal/datadog/profiling/stack_v2
- releasenotes/notes
2 files changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
0 commit comments