fix: remove throwing PyErr on large bytes object in span attribute [backport 3.14] (#14632)

Backport f6d8df9 from #14589 to 3.14.

Removes throwing `PyErr_Format` when encoding bytes object, which may
have led to potential error in customer logs in application with long
byte string postgres query as resource name.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Quinna Halim <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>

Author: 3 people

ddtrace/internal/_encoding.pyx

@@ -148,7 +148,6 @@ cdef inline int pack_text(msgpack_packer *pk, object text) except? -1:
     if PyBytesLike_Check(text):
         L = len(text)
         if L > MAX_SPAN_META_VALUE_LEN:
-            PyErr_Format(ValueError, b"%.200s object is too large", Py_TYPE(text).tp_name)
             text = truncate_string(text)
             L = len(text)
         ret = msgpack_pack_raw(pk, L)

releasenotes/notes/fix-span-encoding-bytes-5c285cf9e55db509.yaml

@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    tracing: Fixes encoding bytes objects as span attributes by truncating byte string, rather than throwing PyErr_Format.

tests/tracer/test_encoders.py

@@ -404,6 +404,69 @@ def test_long_span_start(encoding):
     assert decode(encoder.encode()[0][0]) is not None
 
 
+@allencodings
+def test_span_encoding_large_resource(encoding):
+    encoder = MSGPACK_ENCODERS[encoding](1 << 20, 1 << 20)
+    postgres_query = (
+        "INSERT INTO table VALUES "
+        '(\'x\' * 25001, \'{"top_left": {"x": 0.29411766, "y": 0.123786405}, '
+        '"top_right": {"x": 0.38886696, "y": 0.123786405}, '
+        '"bottom_right": {"x": 0.38886696, "y": 0.13288835}, '
+        '"bottom_left": {"x": 0.29411766, "y": 0.13288835}}\'), '
+        '(\'y\' * 25001, \'{"top_left": {"x": 0.12345678, "y": 0.23456789}, '
+        '"top_right": {"x": 0.34567890, "y": 0.23456789}, '
+        '"bottom_right": {"x": 0.34567890, "y": 0.45678901}, '
+        '"bottom_left": {"x": 0.12345678, "y": 0.45678901}}\'), '
+        '(\'z\' * 25001, \'{"top_left": {"x": 0.56789012, "y": 0.67890123}, '
+        '"top_right": {"x": 0.78901234, "y": 0.67890123}, '
+        '"bottom_right": {"x": 0.78901234, "y": 0.89012345}, '
+        '"bottom_left": {"x": 0.56789012, "y": 0.89012345}}\'), '
+        '(\'a\' * 25001, \'{"top_left": {"x": 0.11111111, "y": 0.22222222}, '
+        '"top_right": {"x": 0.33333333, "y": 0.22222222}, '
+        '"bottom_right": {"x": 0.33333333, "y": 0.44444444}, '
+        '"bottom_left": {"x": 0.11111111, "y": 0.44444444}}\'), '
+        '(\'b\' * 25001, \'{"top_left": {"x": 0.55555555, "y": 0.66666666}, '
+        '"top_right": {"x": 0.77777777, "y": 0.66666666}, '
+        '"bottom_right": {"x": 0.77777777, "y": 0.88888888}, '
+        '"bottom_left": {"x": 0.55555555, "y": 0.88888888}}\'), '
+        '(\'c\' * 25001, \'{"top_left": {"x": 0.99999999, "y": 0.10101010}, '
+        '"top_right": {"x": 0.20202020, "y": 0.10101010}, '
+        '"bottom_right": {"x": 0.20202020, "y": 0.30303030}, '
+        '"bottom_left": {"x": 0.99999999, "y": 0.30303030}}\'), '
+        '(\'d\' * 25001, \'{"top_left": {"x": 0.40404040, "y": 0.50505050}, '
+        '"top_right": {"x": 0.60606060, "y": 0.50505050}, '
+        '"bottom_right": {"x": 0.60606060, "y": 0.70707070}, '
+        '"bottom_left": {"x": 0.40404040, "y": 0.70707070}}\'), '
+        '(\'e\' * 25001, \'{"top_left": {"x": 0.80808080, "y": 0.90909090}, '
+        '"top_right": {"x": 0.12121212, "y": 0.90909090}, '
+        '"bottom_right": {"x": 0.12121212, "y": 0.13131313}, '
+        '"bottom_left": {"x": 0.80808080, "y": 0.13131313}}\'), '
+        '(\'f\' * 25001, \'{"top_left": {"x": 0.14141414, "y": 0.15151515}, '
+        '"top_right": {"x": 0.16161616, "y": 0.15151515}, '
+        '"bottom_right": {"x": 0.16161616, "y": 0.17171717}, '
+        '"bottom_left": {"x": 0.14141414, "y": 0.17171717}}\'), '
+        '(\'g\' * 25001, \'{"top_left": {"x": 0.18181818, "y": 0.19191919}, '
+        '"top_right": {"x": 0.20202020, "y": 0.19191919}, '
+        '"bottom_right": {"x": 0.20202020, "y": 0.21212121}, '
+        '"bottom_left": {"x": 0.18181818, "y": 0.21212121}}\'), '
+        '(\'h\' * 25001, \'{"top_left": {"x": 0.22222222, "y": 0.23232323}, '
+        '"top_right": {"x": 0.24242424, "y": 0.23232323}, '
+        '"bottom_right": {"x": 0.24242424, "y": 0.25252525}, '
+        '"bottom_left": {"x": 0.22222222, "y": 0.25252525}}\'), '
+        '(\'i\' * 25001, \'{"top_left": {"x": 0.26262626, "y": 0.27272727}, '
+        '"top_right": {"x": 0.28282828, "y": 0.27272727}, '
+        '"bottom_right": {"x": 0.28282828, "y": 0.29292929}, '
+        '"bottom_left": {"x": 0.26262626, "y": 0.29292929}}\'), '
+        '(\'j\' * 25001, \'{"top_left": {"x": 0.30303030, "y": 0.31313131}, '
+        '"top_right": {"x": 0.32323232, "y": 0.31313131}, '
+        '"bottom_right": {"x": 0.32323232, "y": 0.33333333}, '
+        '"bottom_left": {"x": 0.30303030, "y": 0.33333333}}\')' * 10
+    )
+    span = Span(name="test-span", resource=postgres_query.encode("utf-8"))
+    trace = [span]
+    encoder.put(trace)
+
+
 class SubString(str):
     pass