You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat(iast): add secure marks core and sanitize command injection (#13017)
## Overview
This PR implements the secure marks functionality for IAST, focusing on
command injection sanitization. It adds core functionality to mark
strings as secure after they've been validated or sanitized by security
functions.
## Motivation
- Improve IAST vulnerability detection accuracy by tracking sanitized
inputs
- Reduce false positives by properly marking strings that have been
secured
- Implement command injection protection as part of the secure marks
system
## Changes
- Added new `secure_marks` package in `ddtrace/appsec/_iast/`
- Implemented validators and sanitizers for command injection protection
- Added support for common security functions (shlex.quote, shlex.split,
django.utils.shlex.quote)
- Updated taint tracking to support secure marks
- Added comprehensive test coverage for the new functionality
## Testing Strategy
- Unit tests for validators and sanitizers
- Integration tests with common security functions
- C++ tests for taint range secure marks functionality
- Performance impact validated (import time improved by ~1.4ms)
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
0 commit comments