refactor: do not keep internal_metadata_json

Author: KowalskiThomas

ddtrace/internal/datadog/profiling/dd_wrapper/include/profiler_stats.hpp

@@ -3,7 +3,6 @@
 #include <cstddef>
 
 #include <string>
-#include <string_view>
 
 namespace Datadog {
 
@@ -17,8 +16,6 @@ a mutex to protect access to the data.
 class ProfilerStats
 {
   private:
-    std::string internal_metadata_json;
-
     // Number of samples collected (one per thread)
     size_t sample_count = 0;
 
@@ -37,9 +34,7 @@ class ProfilerStats
 
     // Returns a JSON string containing relevant Profiler Stats to be included
     // in the libdatadog payload.
-    // The function returned a string_view to a statically allocated string that
-    // is updated every time the function is called.
-    std::string_view get_internal_metadata_json();
+    std::string get_internal_metadata_json();
 
     void reset_state();
 };

ddtrace/internal/datadog/profiling/dd_wrapper/src/profiler_stats.cpp

@@ -1,7 +1,6 @@
 #include "profiler_stats.hpp"
 
 #include <charconv>
-#include <string>
 
 namespace {
 
@@ -46,12 +45,13 @@ Datadog::ProfilerStats::reset_state()
     sampling_event_count = 0;
 }
 
-std::string_view
+std::string
 Datadog::ProfilerStats::get_internal_metadata_json()
 {
+    std::string internal_metadata_json;
     internal_metadata_json.reserve(128);
 
-    internal_metadata_json = "{";
+    internal_metadata_json += "{";
 
     internal_metadata_json += R"("sample_count": )";
     append_to_string(internal_metadata_json, sample_count);