fixup! fixup! fixup! fixup! fixup! wip

Author: KowalskiThomas

ddtrace/internal/datadog/profiling/dd_wrapper/src/ddup_interface.cpp

@@ -347,6 +347,9 @@ ddup_upload() // cppcheck-suppress unusedFunction
         return false;
     }
 
+    // Build the Uploader, which takes care of serializing the Profile and capturing ProfilerStats.
+    // This takes a reference in a way that locks the areas where the profile might
+    // be modified. It gets cleared and released as soon as serialization is complete (or has failed).
     auto uploader_or_err = Datadog::UploaderBuilder::build();
 
     if (std::holds_alternative<std::string>(uploader_or_err)) {
@@ -360,8 +363,9 @@ ddup_upload() // cppcheck-suppress unusedFunction
     // Get the reference to the uploader
     auto& uploader = std::get<Datadog::Uploader>(uploader_or_err);
 
-    // Upload without holding any locks
-    // The encoding has already been done in UploaderBuilder::build
+    // Upload without holding any locks (encoding has already been done in UploaderBuilder::build)
+    // This also cancels inflight uploads. There are better ways to do this, but this is what
+    // we have for now.
     return uploader.upload();
 }