Skip to content

Commit 43090bb

Browse files
lievanlievan
authored andcommitted
fix(llmobs): send batches of span events (#5493)
* batch span events * try to fix test --------- Co-authored-by: lievan <evan.li@datadoqhq.com>
1 parent 10aabcd commit 43090bb

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/dd-trace/src/llmobs/writers/spans/base.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ class LLMObsSpanWriter extends BaseWriter {
4141
}
4242

4343
makePayload (events) {
44-
return {
44+
return events.map(event => ({
4545
'_dd.stage': 'raw',
4646
'_dd.tracer_version': tracerVersion,
4747
event_type: this._eventType,
48-
spans: events
49-
}
48+
spans: [event]
49+
}))
5050
}
5151

5252
_truncateSpanEvent (event) {

packages/dd-trace/test/llmobs/sdk/typescript/index.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const testCases = [
3838
file: 'index',
3939
setup: (agent, results = {}) => {
4040
const llmobsRes = agent.assertLlmObsPayloadReceived(({ payload }) => {
41-
results.llmobsSpans = payload.spans
41+
results.llmobsSpans = payload.flatMap(item => item.spans)
4242
})
4343

4444
const apmRes = agent.assertMessageReceived(({ payload }) => {

packages/dd-trace/test/llmobs/writers/spans/base.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ describe('LLMObsSpanWriter', () => {
9292

9393
const payload = writer.makePayload(events)
9494

95-
expect(payload['_dd.stage']).to.equal('raw')
96-
expect(payload.event_type).to.equal('span')
97-
expect(payload.spans).to.deep.equal(events)
95+
expect(payload[0]['_dd.stage']).to.equal('raw')
96+
expect(payload[0].event_type).to.equal('span')
97+
expect(payload[0].spans).to.deep.equal(events)
9898
})
9999
})

0 commit comments

Comments
 (0)