-
Notifications
You must be signed in to change notification settings - Fork 315
🍒 9909 - Fix npe on ConflatingMetricsAggregator when the resource is null #9938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v1.55.x
Are you sure you want to change the base?
Conversation
(cherry picked from commit 6f71652)
|
🎯 Code Coverage 🔗 Commit SHA: 44c1e5f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 49 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050259
Total [baseline] (10.746 s) : 0, 10745529
Agent [candidate] (1.035 s) : 0, 1035252
Total [candidate] (10.924 s) : 0, 10923683
section appsec
Agent [baseline] (1.225 s) : 0, 1225070
Total [baseline] (10.925 s) : 0, 10925092
Agent [candidate] (1.203 s) : 0, 1202698
Total [candidate] (10.928 s) : 0, 10928075
section iast
Agent [baseline] (1.182 s) : 0, 1182222
Total [baseline] (11.163 s) : 0, 11162911
Agent [candidate] (1.161 s) : 0, 1161083
Total [candidate] (11.13 s) : 0, 11129530
section profiling
Agent [baseline] (1.195 s) : 0, 1194978
Total [baseline] (10.937 s) : 0, 10936740
Agent [candidate] (1.175 s) : 0, 1175284
Total [candidate] (10.878 s) : 0, 10878210
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (705.451 ms) : 0, 705451
BytebuddyAgent [candidate] (706.942 ms) : 0, 706942
GlobalTracer [baseline] (249.261 ms) : 0, 249261
GlobalTracer [candidate] (245.42 ms) : 0, 245420
AppSec [baseline] (32.469 ms) : 0, 32469
AppSec [candidate] (32.24 ms) : 0, 32240
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.375 ms) : 0, 6375
Remote Config [baseline] (674.172 µs) : 0, 674
Remote Config [candidate] (674.127 µs) : 0, 674
Telemetry [baseline] (13.223 ms) : 0, 13223
Telemetry [candidate] (13.654 ms) : 0, 13654
Flare Poller [baseline] (6.517 ms) : 0, 6517
Flare Poller [candidate] (7.202 ms) : 0, 7202
section appsec
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (729.611 ms) : 0, 729611
BytebuddyAgent [candidate] (726.254 ms) : 0, 726254
GlobalTracer [baseline] (241.178 ms) : 0, 241178
GlobalTracer [candidate] (235.759 ms) : 0, 235759
AppSec [baseline] (174.357 ms) : 0, 174357
AppSec [candidate] (174.299 ms) : 0, 174299
Debugger [baseline] (6.186 ms) : 0, 6186
Debugger [candidate] (5.939 ms) : 0, 5939
Remote Config [baseline] (670.875 µs) : 0, 671
Remote Config [candidate] (621.201 µs) : 0, 621
Telemetry [baseline] (8.002 ms) : 0, 8002
Telemetry [candidate] (8.407 ms) : 0, 8407
Flare Poller [baseline] (3.955 ms) : 0, 3955
Flare Poller [candidate] (3.911 ms) : 0, 3911
IAST [baseline] (24.849 ms) : 0, 24849
IAST [candidate] (24.869 ms) : 0, 24869
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (829.143 ms) : 0, 829143
BytebuddyAgent [candidate] (823.178 ms) : 0, 823178
GlobalTracer [baseline] (237.192 ms) : 0, 237192
GlobalTracer [candidate] (234.137 ms) : 0, 234137
AppSec [baseline] (27.8 ms) : 0, 27800
AppSec [candidate] (29.694 ms) : 0, 29694
Debugger [baseline] (6.075 ms) : 0, 6075
Debugger [candidate] (6.168 ms) : 0, 6168
Remote Config [baseline] (608.499 µs) : 0, 608
Remote Config [candidate] (609.846 µs) : 0, 610
Telemetry [baseline] (7.929 ms) : 0, 7929
Telemetry [candidate] (8.452 ms) : 0, 8452
Flare Poller [baseline] (4.086 ms) : 0, 4086
Flare Poller [candidate] (4.152 ms) : 0, 4152
IAST [baseline] (33.219 ms) : 0, 33219
IAST [candidate] (31.754 ms) : 0, 31754
section profiling
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (731.195 ms) : 0, 731195
BytebuddyAgent [candidate] (728.16 ms) : 0, 728160
GlobalTracer [baseline] (222.889 ms) : 0, 222889
GlobalTracer [candidate] (220.6 ms) : 0, 220600
AppSec [baseline] (32.173 ms) : 0, 32173
AppSec [candidate] (32.246 ms) : 0, 32246
Debugger [baseline] (8.921 ms) : 0, 8921
Debugger [candidate] (9.778 ms) : 0, 9778
Remote Config [baseline] (697.127 µs) : 0, 697
Remote Config [candidate] (1.452 ms) : 0, 1452
Telemetry [baseline] (13.793 ms) : 0, 13793
Telemetry [candidate] (12.205 ms) : 0, 12205
Flare Poller [baseline] (4.128 ms) : 0, 4128
Flare Poller [candidate] (4.13 ms) : 0, 4130
ProfilingAgent [baseline] (109.783 ms) : 0, 109783
ProfilingAgent [candidate] (109.637 ms) : 0, 109637
Profiling [baseline] (110.434 ms) : 0, 110434
Profiling [candidate] (110.301 ms) : 0, 110301
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053140
Total [baseline] (8.689 s) : 0, 8688903
Agent [candidate] (1.039 s) : 0, 1038854
Total [candidate] (8.68 s) : 0, 8679576
section iast
Agent [baseline] (1.184 s) : 0, 1183588
Total [baseline] (9.279 s) : 0, 9278822
Agent [candidate] (1.166 s) : 0, 1166007
Total [candidate] (9.379 s) : 0, 9379452
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (707.533 ms) : 0, 707533
BytebuddyAgent [candidate] (708.753 ms) : 0, 708753
GlobalTracer [baseline] (249.361 ms) : 0, 249361
GlobalTracer [candidate] (246.601 ms) : 0, 246601
AppSec [baseline] (32.576 ms) : 0, 32576
AppSec [candidate] (32.706 ms) : 0, 32706
Debugger [baseline] (6.438 ms) : 0, 6438
Debugger [candidate] (6.476 ms) : 0, 6476
Remote Config [baseline] (679.068 µs) : 0, 679
Remote Config [candidate] (680.953 µs) : 0, 681
Telemetry [baseline] (13.093 ms) : 0, 13093
Telemetry [candidate] (14.41 ms) : 0, 14410
Flare Poller [baseline] (7.3 ms) : 0, 7300
Flare Poller [candidate] (6.507 ms) : 0, 6507
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (830.503 ms) : 0, 830503
BytebuddyAgent [candidate] (826.641 ms) : 0, 826641
GlobalTracer [baseline] (237.326 ms) : 0, 237326
GlobalTracer [candidate] (235.249 ms) : 0, 235249
AppSec [baseline] (28.542 ms) : 0, 28542
AppSec [candidate] (29.104 ms) : 0, 29104
Debugger [baseline] (6.038 ms) : 0, 6038
Debugger [candidate] (6.245 ms) : 0, 6245
Remote Config [baseline] (608.766 µs) : 0, 609
Remote Config [candidate] (617.54 µs) : 0, 618
Telemetry [baseline] (7.96 ms) : 0, 7960
Telemetry [candidate] (8.626 ms) : 0, 8626
Flare Poller [baseline] (4.106 ms) : 0, 4106
Flare Poller [candidate] (4.144 ms) : 0, 4144
IAST [baseline] (32.269 ms) : 0, 32269
IAST [candidate] (32.72 ms) : 0, 32720
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section baseline
no_agent (1.197 ms) : 1186, 1209
. : milestone, 1197,
iast (3.214 ms) : 3170, 3259
. : milestone, 3214,
iast_FULL (5.603 ms) : 5547, 5659
. : milestone, 5603,
iast_GLOBAL (3.56 ms) : 3508, 3613
. : milestone, 3560,
profiling (1.986 ms) : 1969, 2003
. : milestone, 1986,
tracing (1.85 ms) : 1834, 1867
. : milestone, 1850,
section candidate
no_agent (1.184 ms) : 1173, 1196
. : milestone, 1184,
iast (3.242 ms) : 3204, 3279
. : milestone, 3242,
iast_FULL (5.684 ms) : 5628, 5741
. : milestone, 5684,
iast_GLOBAL (3.607 ms) : 3549, 3664
. : milestone, 3607,
profiling (1.907 ms) : 1891, 1923
. : milestone, 1907,
tracing (1.76 ms) : 1746, 1773
. : milestone, 1760,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section baseline
no_agent (19.158 ms) : 18962, 19355
. : milestone, 19158,
appsec (19.531 ms) : 19332, 19729
. : milestone, 19531,
code_origins (17.72 ms) : 17546, 17893
. : milestone, 17720,
iast (18.889 ms) : 18699, 19079
. : milestone, 18889,
profiling (19.686 ms) : 19480, 19892
. : milestone, 19686,
tracing (17.535 ms) : 17362, 17709
. : milestone, 17535,
section candidate
no_agent (18.002 ms) : 17816, 18188
. : milestone, 18002,
appsec (19.436 ms) : 19240, 19631
. : milestone, 19436,
code_origins (19.639 ms) : 19445, 19834
. : milestone, 19639,
iast (19.628 ms) : 19434, 19822
. : milestone, 19628,
profiling (20.686 ms) : 20479, 20893
. : milestone, 20686,
tracing (17.455 ms) : 17282, 17628
. : milestone, 17455,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.708 ms) : 3490, 3925
. : milestone, 3708,
iast (2.221 ms) : 2157, 2285
. : milestone, 2221,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.086 ms) : 2032, 2139
. : milestone, 2086,
tracing (2.028 ms) : 1978, 2077
. : milestone, 2028,
section candidate
no_agent (1.489 ms) : 1478, 1501
. : milestone, 1489,
appsec (3.657 ms) : 3444, 3870
. : milestone, 3657,
iast (2.225 ms) : 2161, 2288
. : milestone, 2225,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.06 ms) : 2009, 2112
. : milestone, 2060,
tracing (2.035 ms) : 1986, 2085
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section baseline
no_agent (15.609 s) : 15609000, 15609000
. : milestone, 15609000,
appsec (14.645 s) : 14645000, 14645000
. : milestone, 14645000,
iast (18.555 s) : 18555000, 18555000
. : milestone, 18555000,
iast_GLOBAL (17.714 s) : 17714000, 17714000
. : milestone, 17714000,
profiling (15.823 s) : 15823000, 15823000
. : milestone, 15823000,
tracing (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
section candidate
no_agent (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
appsec (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
iast (18.386 s) : 18386000, 18386000
. : milestone, 18386000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
profiling (15.356 s) : 15356000, 15356000
. : milestone, 15356000,
tracing (15.466 s) : 15466000, 15466000
. : milestone, 15466000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back-porting the approval
Backport #9909 to release/v1.55.x