-
Notifications
You must be signed in to change notification settings - Fork 315
Add metrics OpenTelemetry instrumentation entry mechanism #9908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: f15cec4 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051078
Total [baseline] (8.663 s) : 0, 8662920
Agent [candidate] (1.048 s) : 0, 1047546
Total [candidate] (8.648 s) : 0, 8647645
section iast
Agent [baseline] (1.177 s) : 0, 1177053
Total [baseline] (9.268 s) : 0, 9267628
Agent [candidate] (1.184 s) : 0, 1184432
Total [candidate] (9.296 s) : 0, 9295787
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (707.67 ms) : 0, 707670
BytebuddyAgent [candidate] (705.526 ms) : 0, 705526
GlobalTracer [baseline] (246.215 ms) : 0, 246215
GlobalTracer [candidate] (245.633 ms) : 0, 245633
AppSec [baseline] (32.522 ms) : 0, 32522
AppSec [candidate] (32.099 ms) : 0, 32099
Debugger [baseline] (6.442 ms) : 0, 6442
Debugger [candidate] (6.346 ms) : 0, 6346
Remote Config [baseline] (727.668 µs) : 0, 728
Remote Config [candidate] (700.267 µs) : 0, 700
Telemetry [baseline] (15.449 ms) : 0, 15449
Telemetry [candidate] (13.809 ms) : 0, 13809
Flare Poller [baseline] (5.807 ms) : 0, 5807
Flare Poller [candidate] (7.302 ms) : 0, 7302
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (826.652 ms) : 0, 826652
BytebuddyAgent [candidate] (831.894 ms) : 0, 831894
GlobalTracer [baseline] (233.974 ms) : 0, 233974
GlobalTracer [candidate] (235.668 ms) : 0, 235668
IAST [baseline] (30.624 ms) : 0, 30624
IAST [candidate] (32.525 ms) : 0, 32525
AppSec [baseline] (30.347 ms) : 0, 30347
AppSec [candidate] (28.864 ms) : 0, 28864
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.004 ms) : 0, 6004
Remote Config [baseline] (609.745 µs) : 0, 610
Remote Config [candidate] (611.788 µs) : 0, 612
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.427 ms) : 0, 8427
Flare Poller [baseline] (4.189 ms) : 0, 4189
Flare Poller [candidate] (4.193 ms) : 0, 4193
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056105
Total [baseline] (10.824 s) : 0, 10824405
Agent [candidate] (1.046 s) : 0, 1045733
Total [candidate] (10.755 s) : 0, 10755302
section appsec
Agent [baseline] (1.228 s) : 0, 1228168
Total [baseline] (10.904 s) : 0, 10904248
Agent [candidate] (1.221 s) : 0, 1220557
Total [candidate] (10.972 s) : 0, 10971500
section iast
Agent [baseline] (1.182 s) : 0, 1182232
Total [baseline] (11.151 s) : 0, 11150805
Agent [candidate] (1.178 s) : 0, 1178437
Total [candidate] (11.116 s) : 0, 11115575
section profiling
Agent [baseline] (1.193 s) : 0, 1192662
Total [baseline] (10.936 s) : 0, 10935641
Agent [candidate] (1.194 s) : 0, 1193839
Total [candidate] (10.894 s) : 0, 10893736
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (711.039 ms) : 0, 711039
BytebuddyAgent [candidate] (704.746 ms) : 0, 704746
GlobalTracer [baseline] (247.57 ms) : 0, 247570
GlobalTracer [candidate] (245.416 ms) : 0, 245416
AppSec [baseline] (32.824 ms) : 0, 32824
AppSec [candidate] (31.971 ms) : 0, 31971
Debugger [baseline] (6.456 ms) : 0, 6456
Debugger [candidate] (6.317 ms) : 0, 6317
Remote Config [baseline] (720.544 µs) : 0, 721
Remote Config [candidate] (712.116 µs) : 0, 712
Telemetry [baseline] (13.002 ms) : 0, 13002
Telemetry [candidate] (14.039 ms) : 0, 14039
Flare Poller [baseline] (8.119 ms) : 0, 8119
Flare Poller [candidate] (6.431 ms) : 0, 6431
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (731.71 ms) : 0, 731710
BytebuddyAgent [candidate] (728.267 ms) : 0, 728267
GlobalTracer [baseline] (239.583 ms) : 0, 239583
GlobalTracer [candidate] (237.232 ms) : 0, 237232
IAST [baseline] (25.366 ms) : 0, 25366
IAST [candidate] (24.814 ms) : 0, 24814
AppSec [baseline] (175.552 ms) : 0, 175552
AppSec [candidate] (174.845 ms) : 0, 174845
Debugger [baseline] (6.101 ms) : 0, 6101
Debugger [candidate] (5.976 ms) : 0, 5976
Remote Config [baseline] (654.536 µs) : 0, 655
Remote Config [candidate] (676.217 µs) : 0, 676
Telemetry [baseline] (8.766 ms) : 0, 8766
Telemetry [candidate] (8.545 ms) : 0, 8545
Flare Poller [baseline] (3.998 ms) : 0, 3998
Flare Poller [candidate] (3.988 ms) : 0, 3988
section iast
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (830.195 ms) : 0, 830195
BytebuddyAgent [candidate] (827.804 ms) : 0, 827804
GlobalTracer [baseline] (235.33 ms) : 0, 235330
GlobalTracer [candidate] (234.431 ms) : 0, 234431
IAST [baseline] (32.622 ms) : 0, 32622
IAST [candidate] (32.292 ms) : 0, 32292
AppSec [baseline] (28.673 ms) : 0, 28673
AppSec [candidate] (28.514 ms) : 0, 28514
Debugger [baseline] (6.014 ms) : 0, 6014
Debugger [candidate] (6.007 ms) : 0, 6007
Remote Config [baseline] (600.35 µs) : 0, 600
Remote Config [candidate] (607.856 µs) : 0, 608
Telemetry [baseline] (8.457 ms) : 0, 8457
Telemetry [candidate] (8.403 ms) : 0, 8403
Flare Poller [baseline] (4.111 ms) : 0, 4111
Flare Poller [candidate] (4.103 ms) : 0, 4103
section profiling
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.415 ms) : 0, 1415
BytebuddyAgent [baseline] (729.951 ms) : 0, 729951
BytebuddyAgent [candidate] (730.167 ms) : 0, 730167
GlobalTracer [baseline] (221.457 ms) : 0, 221457
GlobalTracer [candidate] (221.586 ms) : 0, 221586
AppSec [baseline] (32.115 ms) : 0, 32115
AppSec [candidate] (31.962 ms) : 0, 31962
Debugger [baseline] (7.402 ms) : 0, 7402
Debugger [candidate] (6.705 ms) : 0, 6705
Remote Config [baseline] (682.902 µs) : 0, 683
Remote Config [candidate] (676.824 µs) : 0, 677
Telemetry [baseline] (15.316 ms) : 0, 15316
Telemetry [candidate] (15.579 ms) : 0, 15579
Flare Poller [baseline] (4.138 ms) : 0, 4138
Flare Poller [candidate] (4.172 ms) : 0, 4172
ProfilingAgent [baseline] (110.488 ms) : 0, 110488
ProfilingAgent [candidate] (111.197 ms) : 0, 111197
Profiling [baseline] (111.134 ms) : 0, 111134
Profiling [candidate] (111.844 ms) : 0, 111844
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1177, 1200
. : milestone, 1188,
iast (3.188 ms) : 3148, 3228
. : milestone, 3188,
iast_FULL (5.764 ms) : 5707, 5821
. : milestone, 5764,
iast_GLOBAL (3.749 ms) : 3692, 3806
. : milestone, 3749,
profiling (2.031 ms) : 2013, 2049
. : milestone, 2031,
tracing (1.809 ms) : 1794, 1824
. : milestone, 1809,
section candidate
no_agent (1.177 ms) : 1166, 1189
. : milestone, 1177,
iast (3.126 ms) : 3085, 3167
. : milestone, 3126,
iast_FULL (5.951 ms) : 5891, 6010
. : milestone, 5951,
iast_GLOBAL (3.655 ms) : 3596, 3714
. : milestone, 3655,
profiling (1.871 ms) : 1855, 1888
. : milestone, 1871,
tracing (1.923 ms) : 1906, 1940
. : milestone, 1923,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (18.134 ms) : 17948, 18319
. : milestone, 18134,
appsec (18.602 ms) : 18414, 18790
. : milestone, 18602,
code_origins (17.558 ms) : 17384, 17732
. : milestone, 17558,
iast (17.683 ms) : 17507, 17859
. : milestone, 17683,
profiling (20.093 ms) : 19890, 20297
. : milestone, 20093,
tracing (17.661 ms) : 17484, 17838
. : milestone, 17661,
section candidate
no_agent (18.765 ms) : 18575, 18954
. : milestone, 18765,
appsec (18.552 ms) : 18362, 18743
. : milestone, 18552,
code_origins (18.598 ms) : 18407, 18789
. : milestone, 18598,
iast (18.352 ms) : 18171, 18533
. : milestone, 18352,
profiling (18.822 ms) : 18632, 19012
. : milestone, 18822,
tracing (17.575 ms) : 17401, 17749
. : milestone, 17575,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
appsec (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
iast (18.369 s) : 18369000, 18369000
. : milestone, 18369000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
. : milestone, 18110000,
profiling (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
tracing (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
section candidate
no_agent (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
appsec (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
iast (18.4 s) : 18400000, 18400000
. : milestone, 18400000,
iast_GLOBAL (18.079 s) : 18079000, 18079000
. : milestone, 18079000,
profiling (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
tracing (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f15cec4a60, baseline=1.56.0-SNAPSHOT~5db793a092
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.734 ms) : 3514, 3954
. : milestone, 3734,
iast (2.22 ms) : 2157, 2283
. : milestone, 2220,
iast_GLOBAL (2.269 ms) : 2205, 2333
. : milestone, 2269,
profiling (2.071 ms) : 2020, 2122
. : milestone, 2071,
tracing (2.038 ms) : 1989, 2088
. : milestone, 2038,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.713 ms) : 3494, 3932
. : milestone, 3713,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.262 ms) : 2198, 2325
. : milestone, 2262,
profiling (2.071 ms) : 2019, 2123
. : milestone, 2071,
tracing (2.03 ms) : 1981, 2079
. : milestone, 2030,
|
What Does This Do
Initial OpenTelemetry metrics instrumentation and stubbed types to support the OTel metrics API - tests will be added as the various stubs are replaced with real implementations
Motivation
OpenTelemetry Metrics API support
Additional Notes
Jira ticket: APMAPI-1671