Mute JMXFetch Shutdown in progress error #8068

ygree · 2024-12-07T01:07:28Z

What Does This Do

Mute JMXFetch Shutdown in progress error

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-14162

github-actions · 2024-12-07T01:07:38Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

github-actions · 2024-12-07T01:07:38Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2024-12-07T01:50:55Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/mute-jmxfetch-shutdown-err
git_commit_date	1733503294	1733533148
git_commit_sha	`0db6312`	`e10b807`
release_version	1.44.0-SNAPSHOT~0db63127b0	1.44.0-SNAPSHOT~e10b807755

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733536086	1733536086
ci_job_id	729870661	729870661
ci_pipeline_id	50491920	50491920
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100888
Total [baseline] (8.705 s) : 0, 8705390
Agent [candidate] (1.099 s) : 0, 1099376
Total [candidate] (8.701 s) : 0, 8700865
section iast
Agent [baseline] (1.217 s) : 0, 1216584
Total [baseline] (9.179 s) : 0, 9179201
Agent [candidate] (1.224 s) : 0, 1223572
Total [candidate] (9.209 s) : 0, 9208877
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.225 s) : 0, 1224839
Total [baseline] (9.184 s) : 0, 9183866
Agent [candidate] (1.217 s) : 0, 1217123
Total [candidate] (9.187 s) : 0, 9187272
section iast_TELEMETRY_OFF
Agent [baseline] (1.216 s) : 0, 1216400
Total [baseline] (9.168 s) : 0, 9168195
Agent [candidate] (1.217 s) : 0, 1217130
Total [candidate] (9.199 s) : 0, 9198789

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.101 s	-
Agent	iast	1.217 s	115.696 ms (10.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.225 s	123.951 ms (11.3%)
Agent	iast_TELEMETRY_OFF	1.216 s	115.512 ms (10.5%)
Total	tracing	8.705 s	-
Total	iast	9.179 s	473.811 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.184 s	478.477 ms (5.5%)
Total	iast_TELEMETRY_OFF	9.168 s	462.805 ms (5.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.099 s	-
Agent	iast	1.224 s	124.197 ms (11.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.217 s	117.747 ms (10.7%)
Agent	iast_TELEMETRY_OFF	1.217 s	117.754 ms (10.7%)
Total	tracing	8.701 s	-
Total	iast	9.209 s	508.012 ms (5.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.187 s	486.408 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.199 s	497.925 ms (5.7%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.824 ms) : 0, 699824
BytebuddyAgent [candidate] (698.87 ms) : 0, 698870
GlobalTracer [baseline] (319.462 ms) : 0, 319462
GlobalTracer [candidate] (318.61 ms) : 0, 318610
AppSec [baseline] (55.041 ms) : 0, 55041
AppSec [candidate] (54.747 ms) : 0, 54747
Remote Config [baseline] (687.681 µs) : 0, 688
Remote Config [candidate] (684.494 µs) : 0, 684
Telemetry [baseline] (12.039 ms) : 0, 12039
Telemetry [candidate] (12.668 ms) : 0, 12668
section iast
BytebuddyAgent [baseline] (811.408 ms) : 0, 811408
BytebuddyAgent [candidate] (814.304 ms) : 0, 814304
GlobalTracer [baseline] (304.334 ms) : 0, 304334
GlobalTracer [candidate] (308.186 ms) : 0, 308186
AppSec [baseline] (57.969 ms) : 0, 57969
AppSec [candidate] (56.566 ms) : 0, 56566
IAST [baseline] (20.939 ms) : 0, 20939
IAST [candidate] (22.58 ms) : 0, 22580
Remote Config [baseline] (651.834 µs) : 0, 652
Remote Config [candidate] (638.49 µs) : 0, 638
Telemetry [baseline] (7.572 ms) : 0, 7572
Telemetry [candidate] (7.526 ms) : 0, 7526
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (817.763 ms) : 0, 817763
BytebuddyAgent [candidate] (810.984 ms) : 0, 810984
GlobalTracer [baseline] (305.735 ms) : 0, 305735
GlobalTracer [candidate] (305.422 ms) : 0, 305422
AppSec [baseline] (58.11 ms) : 0, 58110
AppSec [candidate] (57.121 ms) : 0, 57121
IAST [baseline] (21.084 ms) : 0, 21084
IAST [candidate] (21.731 ms) : 0, 21731
Remote Config [baseline] (648.964 µs) : 0, 649
Remote Config [candidate] (631.594 µs) : 0, 632
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.504 ms) : 0, 7504
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.542 ms) : 0, 810542
BytebuddyAgent [candidate] (810.044 ms) : 0, 810044
GlobalTracer [baseline] (305.423 ms) : 0, 305423
GlobalTracer [candidate] (306.152 ms) : 0, 306152
AppSec [baseline] (57.278 ms) : 0, 57278
AppSec [candidate] (56.936 ms) : 0, 56936
IAST [baseline] (21.294 ms) : 0, 21294
IAST [candidate] (22.115 ms) : 0, 22115
Remote Config [baseline] (640.414 µs) : 0, 640
Remote Config [candidate] (628.716 µs) : 0, 629
Telemetry [baseline] (7.452 ms) : 0, 7452
Telemetry [candidate] (7.522 ms) : 0, 7522

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088897
Total [baseline] (10.418 s) : 0, 10417822
Agent [candidate] (1.1 s) : 0, 1100425
Total [candidate] (10.399 s) : 0, 10399366
section appsec
Agent [baseline] (1.223 s) : 0, 1222897
Total [baseline] (10.69 s) : 0, 10689697
Agent [candidate] (1.23 s) : 0, 1229810
Total [candidate] (10.768 s) : 0, 10768014
section iast
Agent [baseline] (1.224 s) : 0, 1224173
Total [baseline] (11.001 s) : 0, 11000822
Agent [candidate] (1.22 s) : 0, 1219903
Total [candidate] (10.942 s) : 0, 10941503
section profiling
Agent [baseline] (1.312 s) : 0, 1312136
Total [baseline] (10.767 s) : 0, 10766723
Agent [candidate] (1.322 s) : 0, 1322433
Total [candidate] (10.811 s) : 0, 10810597

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	appsec	1.223 s	134.0 ms (12.3%)
Agent	iast	1.224 s	135.277 ms (12.4%)
Agent	profiling	1.312 s	223.239 ms (20.5%)
Total	tracing	10.418 s	-
Total	appsec	10.69 s	271.875 ms (2.6%)
Total	iast	11.001 s	583.001 ms (5.6%)
Total	profiling	10.767 s	348.901 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.1 s	-
Agent	appsec	1.23 s	129.385 ms (11.8%)
Agent	iast	1.22 s	119.477 ms (10.9%)
Agent	profiling	1.322 s	222.008 ms (20.2%)
Total	tracing	10.399 s	-
Total	appsec	10.768 s	368.649 ms (3.5%)
Total	iast	10.942 s	542.138 ms (5.2%)
Total	profiling	10.811 s	411.231 ms (4.0%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.321 ms) : 0, 693321
BytebuddyAgent [candidate] (700.697 ms) : 0, 700697
GlobalTracer [baseline] (316.854 ms) : 0, 316854
GlobalTracer [candidate] (319.532 ms) : 0, 319532
AppSec [baseline] (54.446 ms) : 0, 54446
AppSec [candidate] (55.059 ms) : 0, 55059
Remote Config [baseline] (677.38 µs) : 0, 677
Remote Config [candidate] (683.111 µs) : 0, 683
Telemetry [baseline] (9.866 ms) : 0, 9866
Telemetry [candidate] (10.574 ms) : 0, 10574
section appsec
BytebuddyAgent [baseline] (710.461 ms) : 0, 710461
BytebuddyAgent [candidate] (714.374 ms) : 0, 714374
GlobalTracer [baseline] (313.384 ms) : 0, 313384
GlobalTracer [candidate] (315.316 ms) : 0, 315316
AppSec [baseline] (166.77 ms) : 0, 166770
AppSec [candidate] (167.923 ms) : 0, 167923
IAST [baseline] (18.942 ms) : 0, 18942
IAST [candidate] (19.155 ms) : 0, 19155
Remote Config [baseline] (1.013 ms) : 0, 1013
Remote Config [candidate] (671.775 µs) : 0, 672
Telemetry [baseline] (8.11 ms) : 0, 8110
Telemetry [candidate] (8.177 ms) : 0, 8177
section iast
BytebuddyAgent [baseline] (815.651 ms) : 0, 815651
BytebuddyAgent [candidate] (813.222 ms) : 0, 813222
GlobalTracer [baseline] (306.53 ms) : 0, 306530
GlobalTracer [candidate] (305.765 ms) : 0, 305765
AppSec [baseline] (57.855 ms) : 0, 57855
AppSec [candidate] (57.863 ms) : 0, 57863
IAST [baseline] (22.05 ms) : 0, 22050
IAST [candidate] (21.001 ms) : 0, 21001
Remote Config [baseline] (649.555 µs) : 0, 650
Remote Config [candidate] (657.243 µs) : 0, 657
Telemetry [baseline] (7.649 ms) : 0, 7649
Telemetry [candidate] (7.598 ms) : 0, 7598
section profiling
BytebuddyAgent [baseline] (686.859 ms) : 0, 686859
BytebuddyAgent [candidate] (689.695 ms) : 0, 689695
GlobalTracer [baseline] (431.37 ms) : 0, 431370
GlobalTracer [candidate] (436.565 ms) : 0, 436565
AppSec [baseline] (53.352 ms) : 0, 53352
AppSec [candidate] (54.261 ms) : 0, 54261
Remote Config [baseline] (650.444 µs) : 0, 650
Remote Config [candidate] (663.136 µs) : 0, 663
Telemetry [baseline] (7.707 ms) : 0, 7707
Telemetry [candidate] (7.663 ms) : 0, 7663
ProfilingAgent [baseline] (93.224 ms) : 0, 93224
ProfilingAgent [candidate] (94.516 ms) : 0, 94516
Profiling [baseline] (93.249 ms) : 0, 93249
Profiling [candidate] (94.54 ms) : 0, 94540

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-07T01:18:21	2024-12-07T01:25:19
git_branch	master	ygree/mute-jmxfetch-shutdown-err
git_commit_date	1733503294	1733533148
git_commit_sha	`0db6312`	`e10b807`
release_version	1.44.0-SNAPSHOT~0db63127b0	1.44.0-SNAPSHOT~e10b807755
start_time	2024-12-07T01:18:07	2024-12-07T01:25:06

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733535072	1733535072
ci_job_id	729870662	729870662
ci_pipeline_id	50491920	50491920
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.156 µs) : 358, 400
.   : milestone, 379,
iast (489.772 µs) : 468, 511
.   : milestone, 490,
iast_FULL (648.155 µs) : 627, 670
.   : milestone, 648,
iast_GLOBAL (514.12 µs) : 493, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (493.002 µs) : 471, 515
.   : milestone, 493,
iast_INACTIVE (451.308 µs) : 430, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (487.098 µs) : 465, 509
.   : milestone, 487,
tracing (443.211 µs) : 423, 464
.   : milestone, 443,
section candidate
no_agent (382.625 µs) : 363, 402
.   : milestone, 383,
iast (491.509 µs) : 470, 513
.   : milestone, 492,
iast_FULL (646.724 µs) : 625, 668
.   : milestone, 647,
iast_GLOBAL (507.848 µs) : 486, 529
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (487.9 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (453.198 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (476.229 µs) : 455, 498
.   : milestone, 476,
tracing (448.434 µs) : 427, 469
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.156 µs [358.01 µs, 400.301 µs]	-
iast	489.772 µs [468.166 µs, 511.379 µs]	110.617 µs (29.2%)
iast_FULL	648.155 µs [626.537 µs, 669.773 µs]	268.999 µs (70.9%)
iast_GLOBAL	514.12 µs [492.504 µs, 535.736 µs]	134.964 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED	493.002 µs [471.229 µs, 514.775 µs]	113.846 µs (30.0%)
iast_INACTIVE	451.308 µs [430.004 µs, 472.611 µs]	72.152 µs (19.0%)
iast_TELEMETRY_OFF	487.098 µs [465.26 µs, 508.936 µs]	107.942 µs (28.5%)
tracing	443.211 µs [422.671 µs, 463.751 µs]	64.056 µs (16.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.625 µs [362.805 µs, 402.444 µs]	-
iast	491.509 µs [470.159 µs, 512.86 µs]	108.885 µs (28.5%)
iast_FULL	646.724 µs [625.161 µs, 668.287 µs]	264.1 µs (69.0%)
iast_GLOBAL	507.848 µs [486.441 µs, 529.254 µs]	125.223 µs (32.7%)
iast_HARDCODED_SECRET_DISABLED	487.9 µs [466.763 µs, 509.037 µs]	105.276 µs (27.5%)
iast_INACTIVE	453.198 µs [432.436 µs, 473.959 µs]	70.573 µs (18.4%)
iast_TELEMETRY_OFF	476.229 µs [454.685 µs, 497.773 µs]	93.604 µs (24.5%)
tracing	448.434 µs [427.406 µs, 469.461 µs]	65.809 µs (17.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.741 ms) : 1715, 1767
.   : milestone, 1741,
appsec_no_iast (1.749 ms) : 1722, 1775
.   : milestone, 1749,
iast (1.495 ms) : 1472, 1517
.   : milestone, 1495,
profiling (1.556 ms) : 1531, 1582
.   : milestone, 1556,
tracing (1.467 ms) : 1443, 1492
.   : milestone, 1467,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.755 ms) : 1731, 1779
.   : milestone, 1755,
appsec_no_iast (1.748 ms) : 1724, 1773
.   : milestone, 1748,
iast (1.493 ms) : 1470, 1516
.   : milestone, 1493,
profiling (1.542 ms) : 1518, 1567
.   : milestone, 1542,
tracing (1.495 ms) : 1469, 1520
.   : milestone, 1495,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.334 ms, 1.372 ms]	-
appsec	1.741 ms [1.715 ms, 1.767 ms]	388.51 µs (28.7%)
appsec_no_iast	1.749 ms [1.722 ms, 1.775 ms]	396.06 µs (29.3%)
iast	1.495 ms [1.472 ms, 1.517 ms]	141.743 µs (10.5%)
profiling	1.556 ms [1.531 ms, 1.582 ms]	203.61 µs (15.1%)
tracing	1.467 ms [1.443 ms, 1.492 ms]	114.59 µs (8.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.34 ms, 1.38 ms]	-
appsec	1.755 ms [1.731 ms, 1.779 ms]	394.925 µs (29.0%)
appsec_no_iast	1.748 ms [1.724 ms, 1.773 ms]	388.642 µs (28.6%)
iast	1.493 ms [1.47 ms, 1.516 ms]	133.208 µs (9.8%)
profiling	1.542 ms [1.518 ms, 1.567 ms]	182.647 µs (13.4%)
tracing	1.495 ms [1.469 ms, 1.52 ms]	134.721 µs (9.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ygree/mute-jmxfetch-shutdown-err
git_commit_date	1733503294	1733533148
git_commit_sha	`0db6312`	`e10b807`
release_version	1.44.0-SNAPSHOT~0db63127b0	1.44.0-SNAPSHOT~e10b807755

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1733535620	1733535620
ci_job_id	729870663	729870663
ci_pipeline_id	50491920	50491920
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.356 ms) : 2314, 2397
.   : milestone, 2356,
iast (2.095 ms) : 2042, 2148
.   : milestone, 2095,
iast_GLOBAL (2.135 ms) : 2082, 2188
.   : milestone, 2135,
profiling (1.96 ms) : 1918, 2002
.   : milestone, 1960,
tracing (1.938 ms) : 1898, 1979
.   : milestone, 1938,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.355 ms) : 2314, 2396
.   : milestone, 2355,
iast (2.094 ms) : 2042, 2146
.   : milestone, 2094,
iast_GLOBAL (2.138 ms) : 2085, 2191
.   : milestone, 2138,
profiling (1.957 ms) : 1914, 1999
.   : milestone, 1957,
tracing (1.935 ms) : 1895, 1976
.   : milestone, 1935,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.356 ms [2.314 ms, 2.397 ms]	881.894 µs (59.8%)
iast	2.095 ms [2.042 ms, 2.148 ms]	621.379 µs (42.2%)
iast_GLOBAL	2.135 ms [2.082 ms, 2.188 ms]	661.017 µs (44.8%)
profiling	1.96 ms [1.918 ms, 2.002 ms]	486.234 µs (33.0%)
tracing	1.938 ms [1.898 ms, 1.979 ms]	464.619 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	2.355 ms [2.314 ms, 2.396 ms]	880.922 µs (59.8%)
iast	2.094 ms [2.042 ms, 2.146 ms]	620.088 µs (42.1%)
iast_GLOBAL	2.138 ms [2.085 ms, 2.191 ms]	664.216 µs (45.1%)
profiling	1.957 ms [1.914 ms, 1.999 ms]	482.646 µs (32.7%)
tracing	1.935 ms [1.895 ms, 1.976 ms]	461.329 µs (31.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~e10b807755, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
appsec (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
iast (18.577 s) : 18577000, 18577000
.   : milestone, 18577000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
.   : milestone, 17877000,
profiling (15.368 s) : 15368000, 15368000
.   : milestone, 15368000,
tracing (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
section candidate
no_agent (15.31 s) : 15310000, 15310000
.   : milestone, 15310000,
appsec (14.838 s) : 14838000, 14838000
.   : milestone, 14838000,
iast (19.001 s) : 19001000, 19001000
.   : milestone, 19001000,
iast_GLOBAL (18.019 s) : 18019000, 18019000
.   : milestone, 18019000,
profiling (15.056 s) : 15056000, 15056000
.   : milestone, 15056000,
tracing (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.963 s [14.963 s, 14.963 s]	-
appsec	14.948 s [14.948 s, 14.948 s]	-15.0 ms (-0.1%)
iast	18.577 s [18.577 s, 18.577 s]	3.614 s (24.2%)
iast_GLOBAL	17.877 s [17.877 s, 17.877 s]	2.914 s (19.5%)
profiling	15.368 s [15.368 s, 15.368 s]	405.0 ms (2.7%)
tracing	14.968 s [14.968 s, 14.968 s]	5.0 ms (0.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.31 s [15.31 s, 15.31 s]	-
appsec	14.838 s [14.838 s, 14.838 s]	-472.0 ms (-3.1%)
iast	19.001 s [19.001 s, 19.001 s]	3.691 s (24.1%)
iast_GLOBAL	18.019 s [18.019 s, 18.019 s]	2.709 s (17.7%)
profiling	15.056 s [15.056 s, 15.056 s]	-254.0 ms (-1.7%)
tracing	15.206 s [15.206 s, 15.206 s]	-104.0 ms (-0.7%)

PerfectSlayer

Should this log be error in the first place?
Maybe warn at best, and dumping exception stacktrace only in debug mode.
WDYT?

PerfectSlayer · 2024-12-09T09:19:06Z

dd-java-agent/agent-jmxfetch/src/main/java/datadog/trace/agent/jmxfetch/JMXFetch.java

@@ -142,9 +142,16 @@ public void run() {
                  if (!appConfig.getExitWatcher().shouldExit()) {
                    try {
                      final int result = app.run();
-                      log.error("jmx collector exited with result: {}", result);
+                      if (result != 0) {
+                        log.error("jmx collector exited with result: {}", result);


Suggested change

log.error("jmx collector exited with result: {}", result);

log.error("jmx collector exited with error code: {}", result);

Mute JMXFetch Shutdown in progress error

e10b807

ygree added the type: bug label Dec 7, 2024

ygree self-assigned this Dec 7, 2024

ygree requested a review from a team as a code owner December 7, 2024 01:07

ygree requested a review from PerfectSlayer December 7, 2024 01:07

ygree added the comp: jmx-fetch JMX fetch label Dec 7, 2024

ygree enabled auto-merge (squash) December 7, 2024 02:17

PerfectSlayer reviewed Dec 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mute JMXFetch Shutdown in progress error #8068

Mute JMXFetch Shutdown in progress error #8068

ygree commented Dec 7, 2024 •

edited

Loading

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 7, 2024

pr-commenter bot commented Dec 7, 2024

PerfectSlayer left a comment

PerfectSlayer Dec 9, 2024

	log.error("jmx collector exited with result: {}", result);
	log.error("jmx collector exited with error code: {}", result);

Mute JMXFetch Shutdown in progress error #8068

Are you sure you want to change the base?

Mute JMXFetch Shutdown in progress error #8068

Conversation

ygree commented Dec 7, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 7, 2024

pr-commenter bot commented Dec 7, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

PerfectSlayer left a comment

Choose a reason for hiding this comment

PerfectSlayer Dec 9, 2024

Choose a reason for hiding this comment

ygree commented Dec 7, 2024 •

edited

Loading