Extract interfaces for tainted objects classes #8060

manuel-alvarez-alvarez · 2024-12-05T23:46:15Z

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-12-06T00:24:51Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-extrat-taint-interfaces
git_commit_date	1733503294	1733563153
git_commit_sha	`0db6312`	`326f822`

See matching parameters

	Baseline	Candidate
ci_job_date	1733564253	1733564253
ci_job_id	729933060	729933060
ci_pipeline_id	50497293	50497293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	unsure [+88.397op/s; +5043.673op/s] or [+0.065%; +3.731%]

pr-commenter · 2024-12-06T00:27:26Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-07T09:30:48	2024-12-07T09:37:47
git_branch	master	malvarez/iast-extrat-taint-interfaces
git_commit_date	1733503294	1733563153
git_commit_sha	`0db6312`	`326f822`
release_version	1.44.0-SNAPSHOT~0db63127b0	1.44.0-SNAPSHOT~326f822968
start_time	2024-12-07T09:30:34	2024-12-07T09:37:34

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733564624	1733564624
ci_job_id	729933057	729933057
ci_pipeline_id	50497293	50497293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+44.677µs; +96.335µs] or [+2.960%; +6.383%]	unstable [-656.608op/s; +428.688op/s] or [-21.340%; +13.932%]	1.580ms	2962.963op/s	1.509ms	3076.923op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~326f822968, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.803 µs) : 365, 405
.   : milestone, 385,
iast (498.484 µs) : 477, 520
.   : milestone, 498,
iast_FULL (662.069 µs) : 640, 684
.   : milestone, 662,
iast_GLOBAL (530.624 µs) : 509, 553
.   : milestone, 531,
iast_HARDCODED_SECRET_DISABLED (497.834 µs) : 477, 519
.   : milestone, 498,
iast_INACTIVE (460.574 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (485.244 µs) : 464, 507
.   : milestone, 485,
tracing (457.919 µs) : 437, 479
.   : milestone, 458,
section candidate
no_agent (381.062 µs) : 362, 400
.   : milestone, 381,
iast (494.951 µs) : 473, 516
.   : milestone, 495,
iast_FULL (661.339 µs) : 640, 683
.   : milestone, 661,
iast_GLOBAL (528.248 µs) : 506, 550
.   : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (499.098 µs) : 477, 521
.   : milestone, 499,
iast_INACTIVE (460.322 µs) : 439, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (487.207 µs) : 466, 509
.   : milestone, 487,
tracing (453.437 µs) : 432, 474
.   : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	384.803 µs [364.944 µs, 404.661 µs]	-
iast	498.484 µs [477.068 µs, 519.899 µs]	113.681 µs (29.5%)
iast_FULL	662.069 µs [640.441 µs, 683.698 µs]	277.267 µs (72.1%)
iast_GLOBAL	530.624 µs [508.552 µs, 552.696 µs]	145.821 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED	497.834 µs [476.687 µs, 518.982 µs]	113.032 µs (29.4%)
iast_INACTIVE	460.574 µs [439.367 µs, 481.78 µs]	75.771 µs (19.7%)
iast_TELEMETRY_OFF	485.244 µs [463.681 µs, 506.807 µs]	100.442 µs (26.1%)
tracing	457.919 µs [436.697 µs, 479.142 µs]	73.117 µs (19.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.062 µs [361.651 µs, 400.474 µs]	-
iast	494.951 µs [473.433 µs, 516.469 µs]	113.889 µs (29.9%)
iast_FULL	661.339 µs [639.817 µs, 682.861 µs]	280.277 µs (73.6%)
iast_GLOBAL	528.248 µs [506.189 µs, 550.307 µs]	147.186 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED	499.098 µs [477.395 µs, 520.8 µs]	118.035 µs (31.0%)
iast_INACTIVE	460.322 µs [439.015 µs, 481.628 µs]	79.259 µs (20.8%)
iast_TELEMETRY_OFF	487.207 µs [465.772 µs, 508.643 µs]	106.145 µs (27.9%)
tracing	453.437 µs [432.399 µs, 474.475 µs]	72.374 µs (19.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~326f822968, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1338, 1379
.   : milestone, 1359,
appsec (1.753 ms) : 1728, 1777
.   : milestone, 1753,
appsec_no_iast (1.748 ms) : 1722, 1774
.   : milestone, 1748,
iast (1.501 ms) : 1478, 1524
.   : milestone, 1501,
profiling (1.509 ms) : 1486, 1533
.   : milestone, 1509,
tracing (1.491 ms) : 1465, 1516
.   : milestone, 1491,
section candidate
no_agent (1.357 ms) : 1337, 1376
.   : milestone, 1357,
appsec (1.747 ms) : 1722, 1772
.   : milestone, 1747,
appsec_no_iast (1.769 ms) : 1745, 1794
.   : milestone, 1769,
iast (1.5 ms) : 1477, 1522
.   : milestone, 1500,
profiling (1.58 ms) : 1555, 1604
.   : milestone, 1580,
tracing (1.514 ms) : 1490, 1539
.   : milestone, 1514,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.338 ms, 1.379 ms]	-
appsec	1.753 ms [1.728 ms, 1.777 ms]	393.93 µs (29.0%)
appsec_no_iast	1.748 ms [1.722 ms, 1.774 ms]	389.38 µs (28.7%)
iast	1.501 ms [1.478 ms, 1.524 ms]	142.551 µs (10.5%)
profiling	1.509 ms [1.486 ms, 1.533 ms]	150.587 µs (11.1%)
tracing	1.491 ms [1.465 ms, 1.516 ms]	131.999 µs (9.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.337 ms, 1.376 ms]	-
appsec	1.747 ms [1.722 ms, 1.772 ms]	390.128 µs (28.8%)
appsec_no_iast	1.769 ms [1.745 ms, 1.794 ms]	412.779 µs (30.4%)
iast	1.5 ms [1.477 ms, 1.522 ms]	143.01 µs (10.5%)
profiling	1.58 ms [1.555 ms, 1.604 ms]	223.183 µs (16.5%)
tracing	1.514 ms [1.49 ms, 1.539 ms]	157.587 µs (11.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-extrat-taint-interfaces
git_commit_date	1733503294	1733563153
git_commit_sha	`0db6312`	`326f822`
release_version	1.44.0-SNAPSHOT~0db63127b0	1.44.0-SNAPSHOT~326f822968

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1733565171	1733565171
ci_job_id	729933058	729933058
ci_pipeline_id	50497293	50497293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~326f822968, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1484
.   : milestone, 1473,
appsec (2.34 ms) : 2298, 2381
.   : milestone, 2340,
iast (2.092 ms) : 2039, 2144
.   : milestone, 2092,
iast_GLOBAL (2.145 ms) : 2091, 2198
.   : milestone, 2145,
profiling (1.951 ms) : 1910, 1993
.   : milestone, 1951,
tracing (1.933 ms) : 1893, 1973
.   : milestone, 1933,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.352 ms) : 2311, 2393
.   : milestone, 2352,
iast (2.084 ms) : 2032, 2136
.   : milestone, 2084,
iast_GLOBAL (2.139 ms) : 2086, 2192
.   : milestone, 2139,
profiling (1.954 ms) : 1912, 1996
.   : milestone, 1954,
tracing (1.942 ms) : 1902, 1983
.   : milestone, 1942,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.484 ms]	-
appsec	2.34 ms [2.298 ms, 2.381 ms]	866.516 µs (58.8%)
iast	2.092 ms [2.039 ms, 2.144 ms]	618.554 µs (42.0%)
iast_GLOBAL	2.145 ms [2.091 ms, 2.198 ms]	671.459 µs (45.6%)
profiling	1.951 ms [1.91 ms, 1.993 ms]	478.286 µs (32.5%)
tracing	1.933 ms [1.893 ms, 1.973 ms]	459.942 µs (31.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.352 ms [2.311 ms, 2.393 ms]	880.1 µs (59.8%)
iast	2.084 ms [2.032 ms, 2.136 ms]	611.927 µs (41.6%)
iast_GLOBAL	2.139 ms [2.086 ms, 2.192 ms]	667.046 µs (45.3%)
profiling	1.954 ms [1.912 ms, 1.996 ms]	482.106 µs (32.8%)
tracing	1.942 ms [1.902 ms, 1.983 ms]	470.709 µs (32.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~326f822968, baseline=1.44.0-SNAPSHOT~0db63127b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
appsec (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
iast (18.904 s) : 18904000, 18904000
.   : milestone, 18904000,
iast_GLOBAL (17.73 s) : 17730000, 17730000
.   : milestone, 17730000,
profiling (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
tracing (14.868 s) : 14868000, 14868000
.   : milestone, 14868000,
section candidate
no_agent (14.837 s) : 14837000, 14837000
.   : milestone, 14837000,
appsec (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
iast (18.967 s) : 18967000, 18967000
.   : milestone, 18967000,
iast_GLOBAL (18.373 s) : 18373000, 18373000
.   : milestone, 18373000,
profiling (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
tracing (14.672 s) : 14672000, 14672000
.   : milestone, 14672000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.418 s [15.418 s, 15.418 s]	-
appsec	15.082 s [15.082 s, 15.082 s]	-336.0 ms (-2.2%)
iast	18.904 s [18.904 s, 18.904 s]	3.486 s (22.6%)
iast_GLOBAL	17.73 s [17.73 s, 17.73 s]	2.312 s (15.0%)
profiling	15.026 s [15.026 s, 15.026 s]	-392.0 ms (-2.5%)
tracing	14.868 s [14.868 s, 14.868 s]	-550.0 ms (-3.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.837 s [14.837 s, 14.837 s]	-
appsec	15.036 s [15.036 s, 15.036 s]	199.0 ms (1.3%)
iast	18.967 s [18.967 s, 18.967 s]	4.13 s (27.8%)
iast_GLOBAL	18.373 s [18.373 s, 18.373 s]	3.536 s (23.8%)
profiling	15.005 s [15.005 s, 15.005 s]	168.0 ms (1.1%)
tracing	14.672 s [14.672 s, 14.672 s]	-165.0 ms (-1.1%)

pr-commenter · 2024-12-06T00:37:29Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/iast-extrat-taint-interfaces
git_commit_date	1733503294	1733563153
git_commit_sha	`0db6312`	`326f822`

See matching parameters

	Baseline	Candidate
ci_job_date	1733564294	1733564294
ci_job_id	729933061	729933061
ci_pipeline_id	50497293	50497293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	unsure [-18610.900op/s; -1380.683op/s] or [-6.037%; -0.448%]
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

manuel-alvarez-alvarez force-pushed the malvarez/iast-extrat-taint-interfaces branch from 8d0b1ce to edccd9e Compare December 6, 2024 10:30

manuel-alvarez-alvarez added comp: asm iast Application Security Management (IAST) type: refactoring tag: no release notes Changes to exclude from release notes labels Dec 6, 2024

manuel-alvarez-alvarez force-pushed the malvarez/iast-extrat-taint-interfaces branch 5 times, most recently from 2f1af73 to 471f00b Compare December 6, 2024 17:17

Extract interface for tainted objects

326f822

manuel-alvarez-alvarez force-pushed the malvarez/iast-extrat-taint-interfaces branch from 471f00b to 326f822 Compare December 7, 2024 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract interfaces for tainted objects classes #8060

Extract interfaces for tainted objects classes #8060

manuel-alvarez-alvarez commented Dec 5, 2024

pr-commenter bot commented Dec 6, 2024 •

edited

Loading

pr-commenter bot commented Dec 6, 2024 •

edited

Loading

pr-commenter bot commented Dec 6, 2024 •

edited

Loading

Extract interfaces for tainted objects classes #8060

Are you sure you want to change the base?

Extract interfaces for tainted objects classes #8060

Conversation

manuel-alvarez-alvarez commented Dec 5, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Dec 6, 2024 • edited Loading

Kafka / producer-benchmark

Parameters

Summary

pr-commenter bot commented Dec 6, 2024 • edited Loading

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

pr-commenter bot commented Dec 6, 2024 • edited Loading

Kafka / consumer-benchmark

Parameters

Summary

pr-commenter bot commented Dec 6, 2024 •

edited

Loading

pr-commenter bot commented Dec 6, 2024 •

edited

Loading

pr-commenter bot commented Dec 6, 2024 •

edited

Loading