test

Author: amarziali

utils/queue-utils/src/main/java/datadog/common/queue/MpscArrayQueueVarHandle.java

@@ -1,7 +1,6 @@
 package datadog.common.queue;
 
 import java.util.Objects;
-import java.util.concurrent.locks.LockSupport;
 
 /**
  * A Multiple-Producer, Single-Consumer (MPSC) bounded lock-free queue using a circular array and
@@ -43,9 +42,6 @@ public boolean offer(E e) {
     long localProducerLimit = producerLimit;
     long cachedHead = 0L; // Local cache of head to reduce volatile reads
 
-    int spinCycles = 0;
-    boolean parkOnSpin = (Thread.currentThread().getId() & 1) == 0;
-
     while (true) {
       long currentTail = (long) TAIL_HANDLE.getVolatile(this);
 
@@ -73,16 +69,7 @@ public boolean offer(E e) {
       }
 
       // Backoff to reduce contention
-      if ((spinCycles & 1) == 0) {
-        Thread.onSpinWait();
-      } else {
-        if (parkOnSpin) {
-          LockSupport.parkNanos(1);
-        } else {
-          Thread.yield();
-        }
-      }
-      spinCycles++;
+      Thread.onSpinWait();
     }
   }
 

utils/queue-utils/src/main/java/datadog/common/queue/MpscBlockingConsumerArrayQueueVarHandle.java

@@ -61,9 +61,6 @@ public final boolean offer(E e) {
     long localProducerLimit = producerLimit;
     long cachedHead = 0L; // Local cache of head to reduce volatile reads
 
-    int spinCycles = 0;
-    boolean parkOnSpin = (Thread.currentThread().getId() & 1) == 0;
-
     while (true) {
       long currentTail = (long) TAIL_HANDLE.getVolatile(this);
 
@@ -93,21 +90,11 @@ public final boolean offer(E e) {
         if (c != null) {
           LockSupport.unpark(c);
         }
-
         return true;
       }
 
       // Backoff to reduce contention
-      if ((spinCycles & 1) == 0) {
-        Thread.onSpinWait();
-      } else {
-        if (parkOnSpin) {
-          LockSupport.parkNanos(1);
-        } else {
-          Thread.yield();
-        }
-      }
-      spinCycles++;
+      Thread.onSpinWait();
     }
   }
 

utils/queue-utils/src/main/java/datadog/common/queue/SpmcArrayQueueVarHandle.java

@@ -1,7 +1,6 @@
 package datadog.common.queue;
 
 import java.util.Objects;
-import java.util.concurrent.locks.LockSupport;
 
 /**
  * A Single-Producer, Multiple-Consumer (SPMC) bounded, lock-free queue based on a circular array.
@@ -58,9 +57,6 @@ public boolean offer(E e) {
   public E poll() {
     final Object[] localBuffer = this.buffer;
 
-    int spinCycles = 0;
-    boolean parkOnSpin = (Thread.currentThread().getId() & 1) == 0;
-
     while (true) {
       long currentHead = (long) HEAD_HANDLE.getVolatile(this);
       long limit = consumerLimit; // cached tail
@@ -77,16 +73,7 @@ public E poll() {
       // Attempt to claim this slot
       if (!HEAD_HANDLE.compareAndSet(this, currentHead, currentHead + 1)) {
         // CAS failed. Backoff to reduce contention
-        if ((spinCycles & 1) == 0) {
-          Thread.onSpinWait();
-        } else {
-          if (parkOnSpin) {
-            LockSupport.parkNanos(1);
-          } else {
-            Thread.yield();
-          }
-        }
-        spinCycles++;
+        Thread.onSpinWait();
         continue;
       }