Add support for more combinations of tags on telemetry metrics #6429

andrewlock · 2024-12-12T12:17:59Z

Summary of changes

Allow passing in more tag values to telemetry metrics

Reason for change

@tonyredondo requested it as it would make some of the combinatorial tag requirements for ci visibility easier.

Implementation details

Generalised the current behaviour (that limited it to 2 metrics)

Warning

The original 2 metrics limitation was partly there to avoid the combinatorial explosion you can get with more metrics. Be aware that we always generate all combinations of tags, so if only certain combinations of tags should be set together, then you should use the existing capabilities of grouping multiple tags.

During the factoring, I was careful to keep the generated code consistent. We can sweep through and simplify the generator (by allowing trivial renaming of variables etc) later, but didn't want to muddy the waters for review in this PR.

Test coverage

Added unit tests for the source generator. We should carefully test and review the first real usage of the multiple-generics, to confirm there's no unexpected issues.

…tags No changes to the generated code or anything, just making it work...

andrewlock · 2024-12-12T12:51:13Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6429) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 65, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6429) - mean (978ms)  : 952, 1004
     .   : milestone, 978,
    master - mean (979ms)  : 952, 1006
     .   : milestone, 979,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6429) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6429) - mean (675ms)  : 660, 690
     .   : milestone, 675,
    master - mean (678ms)  : 664, 692
     .   : milestone, 678,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6429) - mean (90ms)  : 88, 93
     .   : milestone, 90,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6429) - mean (624ms)  : 606, 641
     .   : milestone, 624,
    master - mean (638ms)  : 625, 651
     .   : milestone, 638,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6429) - mean (193ms)  : 189, 196
     .   : milestone, 193,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6429) - mean (1,101ms)  : 1068, 1135
     .   : milestone, 1101,
    master - mean (1,101ms)  : 1073, 1128
     .   : milestone, 1101,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6429) - mean (279ms)  : 274, 283
     .   : milestone, 279,
    master - mean (278ms)  : 274, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6429) - mean (870ms)  : 836, 904
     .   : milestone, 870,
    master - mean (877ms)  : 848, 906
     .   : milestone, 877,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6429) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (268ms)  : 262, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6429) - mean (848ms)  : 816, 880
     .   : milestone, 848,
    master - mean (854ms)  : 815, 893
     .   : milestone, 854,

andrewlock · 2024-12-12T13:17:41Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6429) (11.183M)   : 0, 11183231
    master (11.185M)   : 0, 11185452
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6429) (7.362M)   : 0, 7361643
    master (7.339M)   : 0, 7338940
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.663M)   : 0, 7662708

    section Manual
    master (11.063M)   : 0, 11063462

    section Manual + Automatic
    This PR (6429) (6.761M)   : 0, 6760990
    master (6.756M)   : 0, 6755869

    section DD_TRACE_ENABLED=0
    master (10.292M)   : 0, 10291550

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6429) (9.518M)   : 0, 9518339
    master (9.298M)   : 0, 9298207
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6429) (6.414M)   : 0, 6414309
    master (6.384M)   : 0, 6384093

    section Trace stats
    master (6.648M)   : 0, 6647596

    section Manual
    master (9.348M)   : 0, 9347597

    section Manual + Automatic
    This PR (6429) (6.003M)   : 0, 6003042
    master (5.912M)   : 0, 5911591

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8867634

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6429) (10.180M)   : 0, 10180033
    master (9.792M)   : 0, 9791934
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6429) (6.306M)   : 0, 6305649
    master (6.431M)   : 0, 6431072
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.934M)   : 0, 6934019

    section Manual
    master (9.676M)   : 0, 9675873

    section Manual + Automatic
    This PR (6429) (5.767M)   : 0, 5766620
    master (6.062M)   : 0, 6061828

    section DD_TRACE_ENABLED=0
    master (9.288M)   : 0, 9287665

datadog-ddstaging · 2024-12-12T13:19:09Z

Datadog Report

Branch report: andrew/more-telemetry-metrics
Commit report: 6308474
Test service: dd-trace-dotnet

✅ 0 Failed, 463153 Passed, 2862 Skipped, 19h 12m 58.24s Total Time

tonyredondo · 2024-12-12T15:03:30Z

tracer/src/Datadog.Trace.SourceGenerators/TelemetryMetric/Sources.cs

+            return;
+        }
+
+        Span<int> multipliers = stackalloc int[tagArray.Length];


what's the expected length here? be careful with int size * length in the stack...

It's one per generic parameter, so currently a max of 5. i.e. all fine IMO

andrewlock · 2024-12-12T18:44:03Z

Benchmarks Report for tracer 🐌

Benchmarks for #6429 compared to master:

All benchmarks have the same speed
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.97μs	42.2ns	235ns	0.0163	0.00816	0	5.6 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	55.2ns	307ns	0.0204	0.00511	0	5.8 KB
master	`StartStopWithChild`	net472	16.3μs	36.1ns	130ns	1.04	0.302	0.0897	6.21 KB
#6429	`StartStopWithChild`	net6.0	8.21μs	45.3ns	272ns	0.0206	0.00823	0	5.61 KB
#6429	`StartStopWithChild`	netcoreapp3.1	10μs	54.7ns	342ns	0.0194	0.00971	0	5.8 KB
#6429	`StartStopWithChild`	net472	16.4μs	45.1ns	175ns	1.04	0.303	0.0957	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	494μs	144ns	538ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	249ns	932ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	858μs	356ns	1.38μs	0.428	3.3 KB
#6429	`WriteAndFlushEnrichedTraces`	net6.0	492μs	277ns	1.04μs	0	2.7 KB
#6429	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	515ns	2μs	0	2.7 KB
#6429	`WriteAndFlushEnrichedTraces`	net472	850μs	478ns	1.79μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	152μs	868ns	8.46μs	0.148	14.47 KB
master	`SendRequest`	netcoreapp3.1	167μs	961ns	8.1μs	0.157	17.27 KB
master	`SendRequest`	net472	0.00118ns	0.000644ns	0.0025ns	0	0 b
#6429	`SendRequest`	net6.0	147μs	773ns	6.14μs	0.147	14.47 KB
#6429	`SendRequest`	netcoreapp3.1	167μs	979ns	8.97μs	0.16	17.27 KB
#6429	`SendRequest`	net472	0.00111ns	0.000425ns	0.00165ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6429

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.59 KB	41.8 KB	209 B	0.50%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	565μs	2.71μs	11.2μs	0.568	0	0	41.59 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	661μs	3.57μs	20.2μs	0.353	0	0	41.72 KB
master	`WriteAndFlushEnrichedTraces`	net472	821μs	4.02μs	16.6μs	8.45	2.53	0.422	53.29 KB
#6429	`WriteAndFlushEnrichedTraces`	net6.0	599μs	3.09μs	19.8μs	0.558	0	0	41.8 KB
#6429	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	656μs	2.86μs	10.7μs	0.34	0	0	41.64 KB
#6429	`WriteAndFlushEnrichedTraces`	net472	863μs	3.73μs	15.4μs	8.3	2.62	0.437	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.23μs	0.62ns	2.32ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.77μs	0.915ns	3.54ns	0.0138	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.01μs	2.19ns	8.19ns	0.156	0.001	987 B
#6429	`ExecuteNonQuery`	net6.0	1.27μs	3.89ns	15.1ns	0.0139	0	1.02 KB
#6429	`ExecuteNonQuery`	netcoreapp3.1	1.85μs	1.13ns	4.24ns	0.0139	0	1.02 KB
#6429	`ExecuteNonQuery`	net472	2.15μs	1.73ns	6.68ns	0.157	0.00108	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	1.08ns	4.03ns	0.0133	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.63μs	0.751ns	2.91ns	0.0134	976 B
master	`CallElasticsearch`	net472	2.49μs	3.3ns	12.8ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.33μs	1.22ns	4.74ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.75μs	0.987ns	3.69ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	2.13ns	8.25ns	0.167	1.05 KB
#6429	`CallElasticsearch`	net6.0	1.3μs	0.743ns	2.78ns	0.0138	976 B
#6429	`CallElasticsearch`	netcoreapp3.1	1.58μs	1.41ns	5.26ns	0.0129	976 B
#6429	`CallElasticsearch`	net472	2.63μs	1.6ns	5.76ns	0.158	995 B
#6429	`CallElasticsearchAsync`	net6.0	1.33μs	0.69ns	2.67ns	0.0132	952 B
#6429	`CallElasticsearchAsync`	netcoreapp3.1	1.72μs	0.765ns	2.86ns	0.0137	1.02 KB
#6429	`CallElasticsearchAsync`	net472	2.55μs	1.4ns	4.86ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.466ns	1.8ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.7μs	0.474ns	1.77ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.81μs	0.506ns	1.89ns	0.145	915 B
#6429	`ExecuteAsync`	net6.0	1.33μs	0.525ns	1.89ns	0.0132	952 B
#6429	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.823ns	3.19ns	0.0132	952 B
#6429	`ExecuteAsync`	net472	1.73μs	1.09ns	4.23ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.44μs	2.39ns	9.26ns	0.0311	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.31μs	2.93ns	11.4ns	0.0372	2.85 KB
master	`SendAsync`	net472	7.35μs	2.39ns	9.27ns	0.496	3.12 KB
#6429	`SendAsync`	net6.0	4.32μs	1.54ns	5.77ns	0.0323	2.31 KB
#6429	`SendAsync`	netcoreapp3.1	5.21μs	3.49ns	13.5ns	0.0389	2.85 KB
#6429	`SendAsync`	net472	7.34μs	1.21ns	4.7ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.52μs	1.04ns	3.9ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.24μs	0.978ns	3.66ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.68μs	1.83ns	7.09ns	0.25	1.57 KB
#6429	`EnrichedLog`	net6.0	1.6μs	0.677ns	2.53ns	0.0232	1.64 KB
#6429	`EnrichedLog`	netcoreapp3.1	2.19μs	0.572ns	2.14ns	0.0218	1.64 KB
#6429	`EnrichedLog`	net472	2.63μs	1.64ns	5.69ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	291ns	1.13μs	0.0591	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	117ns	439ns	0.063	0	4.28 KB
master	`EnrichedLog`	net472	153μs	216ns	838ns	0.693	0.231	4.46 KB
#6429	`EnrichedLog`	net6.0	120μs	170ns	659ns	0.0598	0	4.28 KB
#6429	`EnrichedLog`	netcoreapp3.1	122μs	182ns	705ns	0	0	4.28 KB
#6429	`EnrichedLog`	net472	153μs	154ns	597ns	0.689	0.23	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.14μs	0.916ns	3.43ns	0.0315	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.97ns	7.65ns	0.0293	2.2 KB
master	`EnrichedLog`	net472	4.98μs	1.32ns	5.12ns	0.319	2.02 KB
#6429	`EnrichedLog`	net6.0	2.96μs	1.16ns	4.49ns	0.0311	2.2 KB
#6429	`EnrichedLog`	netcoreapp3.1	4.33μs	1.16ns	4.5ns	0.0304	2.2 KB
#6429	`EnrichedLog`	net472	4.92μs	0.999ns	3.74ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.41μs	0.586ns	2.27ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.8μs	1.25ns	4.83ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.17μs	0.992ns	3.58ns	0.184	1.16 KB
#6429	`SendReceive`	net6.0	1.29μs	0.46ns	1.78ns	0.0162	1.14 KB
#6429	`SendReceive`	netcoreapp3.1	1.79μs	0.871ns	3.37ns	0.0153	1.14 KB
#6429	`SendReceive`	net472	2.14μs	1.13ns	4.38ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.66μs	0.712ns	2.66ns	0.0229	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.79μs	3.19ns	12.3ns	0.0208	1.65 KB
master	`EnrichedLog`	net472	4.36μs	2.11ns	7.88ns	0.322	2.04 KB
#6429	`EnrichedLog`	net6.0	2.76μs	0.77ns	2.88ns	0.022	1.6 KB
#6429	`EnrichedLog`	netcoreapp3.1	3.94μs	11.9ns	46.2ns	0.022	1.65 KB
#6429	`EnrichedLog`	net472	4.33μs	2.74ns	10.3ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	398ns	0.273ns	1.06ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	618ns	0.659ns	2.55ns	0.0077	576 B
master	`StartFinishSpan`	net472	674ns	2.01ns	7.78ns	0.0916	578 B
master	`StartFinishScope`	net6.0	492ns	0.46ns	1.78ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	751ns	0.711ns	2.75ns	0.00947	696 B
master	`StartFinishScope`	net472	823ns	3.16ns	11.8ns	0.105	658 B
#6429	`StartFinishSpan`	net6.0	392ns	0.252ns	0.975ns	0.00808	576 B
#6429	`StartFinishSpan`	netcoreapp3.1	596ns	0.781ns	3.03ns	0.00782	576 B
#6429	`StartFinishSpan`	net472	693ns	0.485ns	1.88ns	0.0916	578 B
#6429	`StartFinishScope`	net6.0	478ns	0.363ns	1.41ns	0.00964	696 B
#6429	`StartFinishScope`	netcoreapp3.1	699ns	1.01ns	3.92ns	0.0095	696 B
#6429	`StartFinishScope`	net472	876ns	0.47ns	1.82ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	643ns	0.442ns	1.65ns	0.00981	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	923ns	0.497ns	1.86ns	0.00924	696 B
master	`RunOnMethodBegin`	net472	1.14μs	0.524ns	2.03ns	0.104	658 B
#6429	`RunOnMethodBegin`	net6.0	678ns	0.381ns	1.48ns	0.0099	696 B
#6429	`RunOnMethodBegin`	netcoreapp3.1	937ns	1.16ns	4.17ns	0.00945	696 B
#6429	`RunOnMethodBegin`	net472	1.13μs	0.621ns	2.4ns	0.104	658 B

andrewlock added 2 commits December 12, 2024 11:09

Refactor Telemetry Metric generator to work with arbitrary number of …

88e95b8

…tags No changes to the generated code or anything, just making it work...

Add support for adding more tags to metrics

6308474

andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:telemetry labels Dec 12, 2024

andrewlock requested review from a team as code owners December 12, 2024 12:18

tonyredondo approved these changes Dec 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for more combinations of tags on telemetry metrics #6429

Add support for more combinations of tags on telemetry metrics #6429

andrewlock commented Dec 12, 2024

andrewlock commented Dec 12, 2024

andrewlock commented Dec 12, 2024

datadog-ddstaging bot commented Dec 12, 2024 •

edited

Loading

tonyredondo Dec 12, 2024

andrewlock Dec 19, 2024

andrewlock commented Dec 12, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #6429

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Add support for more combinations of tags on telemetry metrics #6429

Are you sure you want to change the base?

Add support for more combinations of tags on telemetry metrics #6429

Conversation

andrewlock commented Dec 12, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

andrewlock commented Dec 12, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 12, 2024

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Dec 12, 2024 • edited Loading

Datadog Report

tonyredondo Dec 12, 2024

Choose a reason for hiding this comment

andrewlock Dec 19, 2024

Choose a reason for hiding this comment

andrewlock commented Dec 12, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6429

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

datadog-ddstaging bot commented Dec 12, 2024 •

edited

Loading