Commit bad5402
authored
[OTEL] Metrics API Support - Collection Implementation (#7511)
## Summary of changes
This PR implements the metrics collection foundation for OpenTelemetry
Metrics API supportKey additions include:
- MetricReader: Component for collecting instrument measurements and
aggregating them
- MetricReaderHandler: High-performance measurement processing with
proper aggregation (Sum, Last Value, Histogram)
- MetricPoint: Thread-safe data structure for metric aggregation with
histogram bucket support
- Testing: Unit test covering all 7 instrument types (4 sync + 3 async)
with exact OTLP value verification
This is the second of a series of 3 PRs to complete the OpenTelemetry
Metrics API support.
1. [[OTEL] Metrics API Support - Configurations & Telemetry
#7420](#7420)
2. [[OTEL] Metrics API Support - Collection Implementation
#7511](#7511) <- You are
here.
3. [[OTEL] Metrics API Support - Metrics Reader & OTLP Exporter
#7514](#7514)
## Reason for change
The [RFC] OpenTelemetry Metrics API support requires implementing
metrics collection that's compatible with the OpenTelemetry data model.
This PR provides the collection foundation that will enable customers to
use .NET's `System.Diagnostics.Metrics` API with Datadog as a drop-in
replacement for the OpenTelemetry SDK.
Business Impact: Enables the collection phase of OpenTelemetry Metrics
API support, laying the groundwork for OTLP export in the next PR.
## Implementation details
✅ Metrics Collection Components:
- MetricReader - RFC-compliant component for initialization and async
collection
- MetricReaderHandler - Measurement processing and aggregation
- MetricPoint - Aggregation data structure with histogram bucket support
✅ Aggregation Mapping:
- Counter/Asynchronous Counter → Sum Aggregation → Sum Metric Point ✅
- UpDownCounter/Asynchronous UpDownCounter → Sum Aggregation → Sum
Metric Point ✅
- Gauge/Asynchronous Gauge → Last Value Aggregation → Gauge Metric Point
✅
- Histogram → Explicit Bucket Histogram Aggregation → Histogram Metric
Point ✅
## Test coverage
Added unit test `MeterListenerCapturesAllMetrics()` that verifies:
- All 7 instrument types (Counter, Histogram, Gauge, UpDownCounter + 3
Async variants)
- Value verification matching OTLP snapshot expectations
Histogram bucket logic verification
- Sync + Async instrument collection
- Tag capture and temporality settings
## Other details
Jira: [APMAPI-1572](https://datadoghq.atlassian.net/browse/APMAPI-1572)
<!-- Fixes #{issue} -->
<!-- 1 parent 792a204 commit bad5402
File tree
12 files changed
+1153
-7
lines changed- tracer
- src
- Datadog.Trace.Trimming/build
- Datadog.Trace
- ClrProfiler
- OTelMetrics
- test
- Datadog.Trace.ClrProfiler.IntegrationTests
- Datadog.Trace.Tests
12 files changed
+1153
-7
lines changedLines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
242 | 246 | | |
243 | 247 | | |
244 | 248 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
381 | | - | |
382 | 381 | | |
383 | 382 | | |
| 383 | + | |
384 | 384 | | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
| 385 | + | |
| 386 | + | |
389 | 387 | | |
390 | 388 | | |
391 | 389 | | |
392 | 390 | | |
393 | 391 | | |
394 | | - | |
| 392 | + | |
395 | 393 | | |
396 | 394 | | |
397 | 395 | | |
398 | 396 | | |
399 | | - | |
| 397 | + | |
400 | 398 | | |
401 | 399 | | |
402 | 400 | | |
| |||
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
0 commit comments