Skip to content

Commit d03266e

Browse files
committed
RUM-8657: post-review fixes
1 parent 4cd1141 commit d03266e

File tree

3 files changed

+16
-24
lines changed

3 files changed

+16
-24
lines changed

dd-sdk-android-core/api/apiSurface

-6
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,6 @@ class com.datadog.android.core.UploadWorker : androidx.work.Worker
198198
constructor(android.content.Context, androidx.work.WorkerParameters)
199199
override fun doWork(): Result
200200
companion object
201-
class com.datadog.android.core.collections.EvictingQueue<T> : java.util.LinkedList<T>
202-
constructor(Int = Int.MAX_VALUE)
203-
override fun add(T): Boolean
204-
override fun addAll(Collection<T>): Boolean
205-
override fun add(Int, T)
206-
override fun addAll(Int, Collection<T>): Boolean
207201
enum com.datadog.android.core.configuration.BackPressureMitigation
208202
- DROP_OLDEST
209203
- IGNORE_NEWEST

dd-sdk-android-core/api/dd-sdk-android-core.api

-14
Original file line numberDiff line numberDiff line change
@@ -563,20 +563,6 @@ public final class com/datadog/android/core/UploadWorker : androidx/work/Worker
563563
public final class com/datadog/android/core/UploadWorker$Companion {
564564
}
565565

566-
public final class com/datadog/android/core/collections/EvictingQueue : java/util/LinkedList {
567-
public fun <init> ()V
568-
public fun <init> (I)V
569-
public synthetic fun <init> (IILkotlin/jvm/internal/DefaultConstructorMarker;)V
570-
public fun add (ILjava/lang/Object;)V
571-
public fun add (Ljava/lang/Object;)Z
572-
public fun addAll (ILjava/util/Collection;)Z
573-
public fun addAll (Ljava/util/Collection;)Z
574-
public fun getSize ()I
575-
public final fun remove (I)Ljava/lang/Object;
576-
public fun removeAt (I)Ljava/lang/Object;
577-
public final fun size ()I
578-
}
579-
580566
public final class com/datadog/android/core/configuration/BackPressureMitigation : java/lang/Enum {
581567
public static final field DROP_OLDEST Lcom/datadog/android/core/configuration/BackPressureMitigation;
582568
public static final field IGNORE_NEWEST Lcom/datadog/android/core/configuration/BackPressureMitigation;

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/assertj/ViewEventAssert.kt

+16-4
Original file line numberDiff line numberDiff line change
@@ -589,12 +589,24 @@ internal class ViewEventAssert(actual: ViewEvent) :
589589

590590
fun hasSlownessInfo(
591591
slowFrames: List<ViewEvent.SlowFrame>,
592-
slowFrameRate: Double,
592+
slowFramesRate: Double,
593593
freezeRate: Double
594594
): ViewEventAssert = apply {
595-
assertThat(actual.view.slowFrames).isEqualTo(slowFrames)
596-
assertThat(actual.view.slowFramesRate).isEqualTo(slowFrameRate)
597-
assertThat(actual.view.freezeRate).isEqualTo(freezeRate)
595+
assertThat(actual.view.slowFrames)
596+
.overridingErrorMessage(
597+
"Expected event data to have slowFrames $slowFrames but was ${actual.view.slowFrames}"
598+
)
599+
.isEqualTo(slowFrames)
600+
assertThat(actual.view.slowFramesRate)
601+
.overridingErrorMessage(
602+
"Expected event data to have slowFramesRate $slowFramesRate but was ${actual.view.slowFramesRate}"
603+
)
604+
.isEqualTo(slowFramesRate)
605+
assertThat(actual.view.freezeRate)
606+
.overridingErrorMessage(
607+
"Expected event data to have freezeRate $freezeRate but was ${actual.view.freezeRate}"
608+
)
609+
.isEqualTo(freezeRate)
598610
}
599611

600612
fun hasOsInfo(

0 commit comments

Comments
 (0)