Skip to content

Commit c510e0e

Browse files
Minor improvements to unit tests
1 parent be663eb commit c510e0e

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

features/dd-sdk-android-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/utils/RectExt.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ internal fun Rect.toWireframeClip(): MobileSegment.WireframeClip {
1616
this.left.toLong(),
1717
this.right.toLong()
1818
)
19-
}
19+
}

features/dd-sdk-android-session-replay/src/main/kotlin/com/datadog/android/sessionreplay/recorder/mapper/ImageViewMapper.kt

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import androidx.annotation.UiThread
1111
import com.datadog.android.api.InternalLogger
1212
import com.datadog.android.internal.utils.ImageViewUtils
1313
import com.datadog.android.internal.utils.densityNormalized
14-
import com.datadog.android.sessionreplay.SessionReplay
1514
import com.datadog.android.sessionreplay.internal.utils.toWireframeClip
1615
import com.datadog.android.sessionreplay.model.MobileSegment
1716
import com.datadog.android.sessionreplay.recorder.MappingContext

features/dd-sdk-android-session-replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/recorder/resources/DefaultImageWireframeHelperTest.kt

+8-4
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,8 @@ internal class DefaultImageWireframeHelperTest {
891891
customResourceIdCacheKey = null,
892892
asyncJobStatusCallback = mockAsyncJobStatusCallback
893893
)
894-
wireframes[0] as MobileSegment.Wireframe.ImageWireframe
894+
895+
assertThat(wireframes[0]).isInstanceOf(MobileSegment.Wireframe.ImageWireframe::class.java)
895896

896897
// Then
897898
val argumentCaptor = argumentCaptor<ResourceResolverCallback>()
@@ -939,7 +940,8 @@ internal class DefaultImageWireframeHelperTest {
939940
customResourceIdCacheKey = null,
940941
asyncJobStatusCallback = mockAsyncJobStatusCallback
941942
)
942-
wireframes[0] as MobileSegment.Wireframe.ImageWireframe
943+
944+
assertThat(wireframes[0]).isInstanceOf(MobileSegment.Wireframe.ImageWireframe::class.java)
943945

944946
// Then
945947
val argumentCaptor = argumentCaptor<ResourceResolverCallback>()
@@ -1270,7 +1272,8 @@ internal class DefaultImageWireframeHelperTest {
12701272
customResourceIdCacheKey = null,
12711273
asyncJobStatusCallback = mockAsyncJobStatusCallback
12721274
)
1273-
wireframes[0] as MobileSegment.Wireframe.ImageWireframe
1275+
1276+
assertThat(wireframes[0]).isInstanceOf(MobileSegment.Wireframe.ImageWireframe::class.java)
12741277

12751278
// Then
12761279
val argumentCaptor = argumentCaptor<ResourceResolverCallback>()
@@ -1318,7 +1321,8 @@ internal class DefaultImageWireframeHelperTest {
13181321
customResourceIdCacheKey = null,
13191322
asyncJobStatusCallback = mockAsyncJobStatusCallback
13201323
)
1321-
wireframes[0] as MobileSegment.Wireframe.ImageWireframe
1324+
1325+
assertThat(wireframes[0]).isInstanceOf(MobileSegment.Wireframe.ImageWireframe::class.java)
13221326

13231327
// Then
13241328
val argumentCaptor = argumentCaptor<ResourceResolverCallback>()

0 commit comments

Comments
 (0)