RUM-3900: Remove RUM feature check in AndroidTracer builder

Author: aleksandr-gringauz

features/dd-sdk-android-trace/src/main/kotlin/com/datadog/android/trace/AndroidTracer.kt

@@ -126,7 +126,6 @@ class AndroidTracer internal constructor(
         fun build(): AndroidTracer {
             val tracingFeature = sdkCore.getFeature(Feature.TRACING_FEATURE_NAME)
                 ?.unwrap<TracingFeature>()
-            val rumFeature = sdkCore.getFeature(Feature.RUM_FEATURE_NAME)
 
             if (tracingFeature == null) {
                 sdkCore.internalLogger.log(
@@ -136,14 +135,6 @@ class AndroidTracer internal constructor(
                 )
             }
 
-            if (bundleWithRumEnabled && rumFeature == null) {
-                sdkCore.internalLogger.log(
-                    InternalLogger.Level.WARN,
-                    InternalLogger.Target.USER,
-                    { RUM_NOT_ENABLED_ERROR_MESSAGE }
-                )
-                bundleWithRumEnabled = false
-            }
             return AndroidTracer(
                 sdkCore,
                 config(),
@@ -296,10 +287,6 @@ class AndroidTracer internal constructor(
             "You're trying to create an AndroidTracer instance, " +
                 "but either the SDK was not initialized or the Tracing feature was " +
                 "not registered/initialized. No tracing data will be sent."
-        internal const val RUM_NOT_ENABLED_ERROR_MESSAGE =
-            "You're trying to bundle the traces with a RUM context, " +
-                "but the RUM feature was not registered/initialized. " +
-                "No RUM context will be attached to your traces in this case."
         internal const val DEFAULT_SERVICE_NAME_IS_MISSING_ERROR_MESSAGE =
             "Default service name is missing during" +
                 " AndroidTracer.Builder creation, did you initialize SDK?"

features/dd-sdk-android-trace/src/test/kotlin/com/datadog/android/trace/AndroidTracerTest.kt

@@ -153,22 +153,6 @@ internal class AndroidTracerTest {
         )
     }
 
-    @Test
-    fun `M log a developer error W buildTracer { RumFeature not enabled, bundleWithRum true }`() {
-        // GIVEN
-        whenever(mockSdkCore.getFeature(Feature.RUM_FEATURE_NAME)) doReturn null
-
-        // WHEN
-        testedTracerBuilder.build()
-
-        // THEN
-        mockInternalLogger.verifyLog(
-            InternalLogger.Level.WARN,
-            InternalLogger.Target.USER,
-            AndroidTracer.RUM_NOT_ENABLED_ERROR_MESSAGE
-        )
-    }
-
     @Test
     fun `M log a developer error W buildTracer { default service name not available }`() {
         // GIVEN
@@ -415,6 +399,8 @@ internal class AndroidTracerTest {
     ) {
         // GIVEN
         whenever(mockSdkCore.getFeature(Feature.RUM_FEATURE_NAME)) doReturn null
+        whenever(mockSdkCore.getFeatureContext(Feature.RUM_FEATURE_NAME)) doReturn emptyMap()
+
         val tracer = AndroidTracer.Builder(mockSdkCore)
             .build()
 
@@ -429,6 +415,37 @@ internal class AndroidTracerTest {
             .isNull()
     }
 
+    @Test
+    fun `M inject RumContext W buildSpan { RumFeature is initialized after AndroidTracer is built }`(
+        @StringForgery(type = StringForgeryType.ALPHA_NUMERICAL) operationName: String
+    ) {
+        // GIVEN
+        whenever(mockSdkCore.getFeature(Feature.RUM_FEATURE_NAME)) doReturn null
+        whenever(mockSdkCore.getFeatureContext(Feature.RUM_FEATURE_NAME)) doReturn emptyMap()
+
+        val tracer = AndroidTracer.Builder(mockSdkCore)
+            .build()
+
+        whenever(mockSdkCore.getFeatureContext(Feature.RUM_FEATURE_NAME)) doReturn mapOf(
+            "application_id" to fakeRumApplicationId,
+            "session_id" to fakeRumSessionId,
+            "view_id" to fakeRumViewId,
+            "action_id" to fakeRumActionId
+        )
+
+        whenever(mockSdkCore.getFeature(Feature.RUM_FEATURE_NAME)) doReturn mock()
+
+        // WHEN
+        val span = tracer.buildSpan(operationName).start() as DDSpan
+
+        // THEN
+        val meta = span.meta
+        assertThat(meta[LogAttributes.RUM_APPLICATION_ID])
+            .isEqualTo(fakeRumApplicationId)
+        assertThat(meta[LogAttributes.RUM_SESSION_ID])
+            .isEqualTo(fakeRumSessionId)
+    }
+
     @Test
     fun `M not inject RumContext W buildSpan { bundleWithRum disabled }`(
         @StringForgery(type = StringForgeryType.ALPHA_NUMERICAL) operationName: String

sample/kotlin/src/main/kotlin/com/datadog/android/sample/SampleApplication.kt

@@ -153,9 +153,6 @@ class SampleApplication : Application() {
             preferences.getTrackingConsent()
         )
 
-        val rumConfig = createRumConfiguration()
-        Rum.enable(rumConfig)
-
         initializeSessionReplay()
         initializeLogs()
         initializeTraces()
@@ -169,6 +166,10 @@ class SampleApplication : Application() {
                 .setService(BuildConfig.APPLICATION_ID)
                 .build()
         )
+
+        val rumConfig = createRumConfiguration()
+        Rum.enable(rumConfig)
+
         GlobalOpenTelemetry.set(object : OpenTelemetry {
             private val tracerProvider = OtelTracerProvider.Builder()
                 .setService(BuildConfig.APPLICATION_ID)