Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error tracking): add core agent and error tracking standalone settings #1553

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GianlucaBortoli
Copy link
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@GianlucaBortoli GianlucaBortoli added the enhancement New feature or request label Dec 10, 2024
@GianlucaBortoli GianlucaBortoli added this to the v1.11.0 milestone Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 48.78%. Comparing base (993280d) to head (ccd2f66).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nal/controller/datadogagent/feature/apm/feature.go 0.00% 9 Missing and 3 partials ⚠️
api/datadoghq/v2alpha1/test/builder.go 0.00% 11 Missing ⚠️
...adogagent/component/clusterchecksrunner/default.go 0.00% 8 Missing ⚠️
...nternal/controller/datadogagent/override/global.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   48.66%   48.78%   +0.12%     
==========================================
  Files         226      226              
  Lines       20363    20481     +118     
==========================================
+ Hits         9909     9992      +83     
- Misses       9937     9973      +36     
+ Partials      517      516       -1     
Flag Coverage Δ
unittests 48.78% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/datadoghq/v2alpha1/datadogagent_types.go 100.00% <ø> (ø)
...nternal/controller/datadogagent/override/global.go 51.55% <0.00%> (-0.98%) ⬇️
...adogagent/component/clusterchecksrunner/default.go 10.28% <0.00%> (-0.40%) ⬇️
api/datadoghq/v2alpha1/test/builder.go 90.11% <0.00%> (-1.70%) ⬇️
...nal/controller/datadogagent/feature/apm/feature.go 61.37% <0.00%> (-2.65%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993280d...ccd2f66. Read the comment docs.

@levan-m levan-m modified the milestones: v1.11.0, v1.12.0 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants