Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROF-10073: Add suport for feature.profiling #1271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Jul 5, 2024

What does this PR do?

This PR adds the Continuous Profiling feature activation under the feature.profiling field in the DatadogAgent CRD. Its only goal is to propagate environment variables to the cluster-agent admission controller.

Motivation

Part of Single Step Activation for the Continuous Profiler.

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Cluster Agent: 7.57.0 (feature will be ignored by earlier versions.)

Describe your test plan

With admission controller enabled, the environment variable DD_ADMISSION_CONTROLLER_AUTO_INSTRUMENTATION_PROFILING_ENABLED will be set with the value of features.profiling.enabled from the manifest, e.g.:

apiVersion: datadoghq.com/v1alpha1
kind: DatadogAgent
metadata:
  name: datadog
spec:
  features:
     profiling:
       enabled: auto

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@szegedi szegedi force-pushed the szegedi/profiling-ssi-kubernetes branch from 1b74c56 to 6e75139 Compare August 16, 2024 11:46
@szegedi szegedi changed the title Add suport for feature.profiling PROF-10073: Add suport for feature.profiling Aug 16, 2024
@szegedi szegedi requested a review from eliottness August 16, 2024 13:35
@szegedi szegedi force-pushed the szegedi/profiling-ssi-kubernetes branch 2 times, most recently from 157e26e to b233635 Compare August 16, 2024 13:45
Copy link
Collaborator

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the comment left open ☝️

@szegedi szegedi force-pushed the szegedi/profiling-ssi-kubernetes branch 2 times, most recently from 7e22fd2 to a77f7a0 Compare August 21, 2024 10:15
@szegedi szegedi added this to the v1.9.0 milestone Aug 21, 2024
@szegedi szegedi force-pushed the szegedi/profiling-ssi-kubernetes branch from a77f7a0 to 5639f0d Compare August 21, 2024 11:33
@szegedi szegedi force-pushed the szegedi/profiling-ssi-kubernetes branch from 5639f0d to 3ba4fa5 Compare August 21, 2024 11:40
@szegedi szegedi marked this pull request as ready for review August 21, 2024 12:18
@szegedi szegedi requested review from a team as code owners August 21, 2024 12:18
@levan-m levan-m removed this from the v1.9.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants