-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROF-10073: Add suport for feature.profiling
#1271
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies
1b74c56
to
6e75139
Compare
feature.profiling
feature.profiling
157e26e
to
b233635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the comment left open ☝️
7e22fd2
to
a77f7a0
Compare
a77f7a0
to
5639f0d
Compare
5639f0d
to
3ba4fa5
Compare
What does this PR do?
This PR adds the Continuous Profiling feature activation under the
feature.profiling
field in the DatadogAgent CRD. Its only goal is to propagate environment variables to the cluster-agent admission controller.Motivation
Part of Single Step Activation for the Continuous Profiler.
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
With admission controller enabled, the environment variable
DD_ADMISSION_CONTROLLER_AUTO_INSTRUMENTATION_PROFILING_ENABLED
will be set with the value offeatures.profiling.enabled
from the manifest, e.g.:Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label