Why must use generated:kubernetes tag when generating SLOs with datadog crd?

[useradd-temp]

https://github.com/DataDog/datadog-operator/blob/main/internal/controller/utils/tag.go#L8

https://github.com/DataDog/datadog-operator/blob/main/internal/controller/datadogslo/controller.go#L169

These two code automatically generate the generated:kubernetes tag when create SLO using CRD.

The problem arises when using a synchronization tool like argocd to deploy SLO

When create an SLO via argocd, the actual generated SLO has the generated:kubernetes tag

And the datadogslo created in the cluster also have the generated:kubernetes tag (by the datadog operator)

However, this tag doesn't exist in the user-defined manifest, so stuck in an infinite sync (reconciling)

This is not in any of the documentation (even though it's not GA)

Is there a reason this tag is required to be used for SLOs?

[celenechang]

Hi @useradd-temp , thanks for opening this issue.

Do you mind setting disableRequiredTags (nested under controllerOptions) to true https://github.com/DataDog/datadog-operator/blob/main/api/datadoghq/v1alpha1/datadogslo_types.go#L94 and seeing if that works for you?

[useradd-temp]

Hi @useradd-temp , thanks for opening this issue.

Do you mind setting disableRequiredTags (nested under controllerOptions) to true https://github.com/DataDog/datadog-operator/blob/main/api/datadoghq/v1alpha1/datadogslo_types.go#L94 and seeing if that works for you?

This setting works perfectly, thank you!

Can you tell me why tags are required? (Why the required tag was added)

Datadog resources(SLO, Monitor, Dashboard etc.) don't actually require tags.