Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding agent image values also overrides the FIPS proxy image values #1488

Open
ryan-at-ld opened this issue Oct 25, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@ryan-at-ld
Copy link

If I have spec.global.fips.enabled: true in my DatadogAgent resource and I also override the agent image name or tag (add spec.override. nodeAgent.image.tag: "7.58.1", for example), the overridden value is also applied to the FIPS proxy image. As a result, the FIPS proxy image is no longer valid and the pods can't start due to image pull errors. If I'm understanding the operator code correctly, the bug is in this for loop. It assumes that every container uses the same image. Modifying the loop to skip the fips-proxy container should fix the issue.

@khewonc
Copy link
Contributor

khewonc commented Nov 4, 2024

@ryan-at-ld Thanks for reaching out. I'll add a card in our backlog to fix this. I think it's possible a user may want to override the fips-proxy image settings so my first thought is that if we add something to be able to override the image settings at the container level, that should work

@khewonc khewonc added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants