do not emit telemetry metrics when attempting to start test session or test module and they're already present

Author: anmarchenko

lib/datadog/ci/contrib/parallel_tests/cli.rb

@@ -22,7 +22,6 @@ def run_tests_in_parallel(num_processes, options)
                   tags: {
                     CI::Ext::Test::TAG_FRAMEWORK => CI::Contrib::RSpec::Ext::FRAMEWORK,
                     CI::Ext::Test::TAG_FRAMEWORK_VERSION => datadog_extract_rspec_version
-
                   },
                   service: datadog_configuration[:service_name],
                   estimated_total_tests_count: 10_000, # temporary value, updated by child processes

lib/datadog/ci/test_visibility/component.rb

@@ -72,6 +72,9 @@ def configure(library_configuration, test_session)
         def start_test_session(service: nil, tags: {}, estimated_total_tests_count: 0, distributed: false)
           return skip_tracing unless test_suite_level_visibility_enabled
 
+          current_test_session = maybe_remote_context.active_test_session
+          return current_test_session if current_test_session
+
           start_drb_service
 
           test_session = maybe_remote_context.start_test_session(service: service, tags: tags)
@@ -85,6 +88,9 @@ def start_test_session(service: nil, tags: {}, estimated_total_tests_count: 0, d
         def start_test_module(test_module_name, service: nil, tags: {})
           return skip_tracing unless test_suite_level_visibility_enabled
 
+          existing_test_module = maybe_remote_context.active_test_module
+          return existing_test_module if existing_test_module
+
           test_module = maybe_remote_context.start_test_module(test_module_name, service: service, tags: tags)
           on_test_module_started(test_module)
           test_module

spec/datadog/ci/test_visibility/component_spec.rb

@@ -415,6 +415,27 @@
           expect(subject).to have_test_tag("my.tag", "my_value")
         end
 
+        context "when a test session is already active" do
+          let(:existing_test_session) { test_visibility.start_test_session(service: service, tags: tags) }
+
+          before do
+            existing_test_session
+
+            reset_telemetry_spy!
+          end
+
+          it "returns the existing test session" do
+            expect(subject).to eq(existing_test_session)
+          end
+
+          it "does not emit any telemetry metrics" do
+            subject
+
+            expect(received_telemetry_metric?(:inc, Datadog::CI::Ext::Telemetry::METRIC_EVENT_CREATED)).to be_falsey
+            expect(received_telemetry_metric?(:inc, Datadog::CI::Ext::Telemetry::METRIC_TEST_SESSION)).to be_falsey
+          end
+        end
+
         context "with git upload enabled and gitdb api spy" do
           let(:git_metadata_upload_enabled) { true }
           let(:search_commits) { double("search_commits") }
@@ -559,6 +580,25 @@
             expect(subject.tracer_span.trace_id).to eq(test_session.tracer_span.trace_id)
           end
         end
+
+        context "when a test module is already active" do
+          let(:existing_test_module) { test_visibility.start_test_module(module_name, service: service, tags: tags) }
+
+          before do
+            existing_test_module
+            reset_telemetry_spy!
+          end
+
+          it "returns the existing test module" do
+            expect(subject).to eq(existing_test_module)
+          end
+
+          it "does not emit any telemetry metrics" do
+            subject
+
+            expect(received_telemetry_metric?(:inc, Datadog::CI::Ext::Telemetry::METRIC_EVENT_CREATED)).to be_falsey
+          end
+        end
       end
 
       describe "start_test_suite" do

spec/support/contexts/telemetry_spy.rb

@@ -50,4 +50,15 @@ def telemetry_spy_value_suffix(value)
   def telemetry_metric(type, name)
     @metrics[type].find { |m| m.name == name }
   end
+
+  def reset_telemetry_spy!
+    @metrics = {
+      inc: [],
+      distribution: []
+    }
+  end
+
+  def received_telemetry_metric?(type, name)
+    @metrics[type].map(&:name).include?(name)
+  end
 end