[ABLD-174] Compose buildifier from upstream & multitool

[rdesgroppes]

Motivation

Currently, buildifier targets don't work out of the box on Windows - credits to @ofek for reporting.

Sadly, it turns out that two separate attempts have already been made to remedy this:

1. In the upstream bazelbuild/buildtools (go source, but only workspace-suitable): Fixes build for Windows bazelbuild/buildtools#1230 (merged)
2. keith/buildifier-prebuilt (bzlmod-suitable, and providing -slightly outdated- go binaries published by bazelbuild/buildtools): Windows fixes for buildifier check, fix and test keith/buildifier-prebuilt#89 (well tested, but pending CI feedback... for months!)

What does this PR do?

Inspired by some of @aiuto's tips:

[1.b.] instead of pointing to the toolchain type defined in buildifier_prebuilt, point to buildifier via multitools.
[2.a.] revert prebuilt_buildtools.json to 5fd6373

The present change proposes the "least intrusive" change so that:

• we don't need to start a third effort (own rules, .bash and .bat scripts),
• we benefit from the validated and merged upstream behavior,
• we don't depend on the goodwill of keith/buildifier-prebuilt to publish the version 8.2.1 of the binaries (nor subsequent versions),
• we don't have to manage a complex patch, but instead simply inhibit the upstream lines that we do not need, given buildifier implementations are provided by multitool (again).

In short, this change combines the best of both worlds through a simple indirection made possible by the configurability of upstream rules which, unlike keith/buildifier-prebuilt, allow us to define which implementation of buildifier to use.

Describe how you validated your changes

I used another branch to verify this works under Windows as well:

datadog-agent/.gitlab/bazel/build-deps.yaml

Line 39 in 0260422

bazel run //bazel/buildifier

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5587c73d-fcd2-4b07-ba13-b2721e4a7e4a

Baseline: b9b1630
Comparison: 5b6e2b4
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-3.29	[-6.34, -0.23]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+1.68	[+1.53, +1.83]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+1.13	[+0.91, +1.34]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.84	[+0.78, +0.90]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.65	[+0.61, +0.69]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	+0.27	[+0.16, +0.39]	1	Logs
➖	ddot_logs	memory utilization	+0.19	[+0.13, +0.25]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.09	[-0.10, +0.29]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.08	[+0.04, +0.12]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.08	[-0.04, +0.20]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.08	[-0.52, +0.67]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.20, +0.20]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.57, +0.56]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.60, +0.59]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.09	[-0.67, +0.50]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.13	[-0.25, -0.02]	1	Logs
➖	file_tree	memory utilization	-0.30	[-0.34, -0.25]	1	Logs
➖	quality_gate_idle	memory utilization	-0.33	[-0.38, -0.28]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	-0.33	[-0.48, -0.18]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.56	[-3.33, +2.21]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	-0.72	[-0.89, -0.54]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-3.29	[-6.34, -0.23]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor b9b1630

Error

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
❌	iot_agent_deb_arm64	$${0}$$	$${51.91}$$ > $${51.9}$$	$${-0}$$	$${11.78}$$ < $${12.63}$$

Gate failure full details

Quality gate	Error type	Error message
iot_agent_deb_arm64	StaticQualityGateFailed	�[91mstatic_quality_gate_iot_agent_deb_arm64 failed! Disk size 51.9 MB exceeds limit of 51.9 MB by 0.0 MB�[0m

Static quality gates prevent the PR to merge!
You can check the static quality gates confluence page for guidance. We also have a toolbox page available to list tools useful to debug the size increase.

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0}$$	$${697.13}$$ < $${703.13}$$	$${+0.01}$$	$${175.44}$$ < $${178.38}$$
✅	agent_deb_amd64_fips	$${-0}$$	$${691.63}$$ < $${697.61}$$	$${+0.08}$$	$${174.06}$$ < $${177.15}$$
✅	agent_heroku_amd64	$${0}$$	$${335.91}$$ < $${341.62}$$	$${-0.01}$$	$${88.94}$$ < $${91.52}$$
✅	agent_msi	$${0}$$	$${988.67}$$ < $${990.42}$$	$${0}$$	$${150.88}$$ < $${152.42}$$
✅	agent_rpm_amd64	$${-0}$$	$${697.12}$$ < $${703.12}$$	$${+0.04}$$	$${177.77}$$ < $${180.53}$$
✅	agent_rpm_amd64_fips	$${-0}$$	$${691.62}$$ < $${697.6}$$	$${+0.01}$$	$${176.18}$$ < $${178.87}$$
✅	agent_rpm_arm64	$${+0}$$	$${683.25}$$ < $${689.82}$$	$${+0.01}$$	$${159.02}$$ < $${162.16}$$
✅	agent_rpm_arm64_fips	$${+0}$$	$${678.76}$$ < $${685.08}$$	$${-0.01}$$	$${157.9}$$ < $${161.11}$$
✅	agent_suse_amd64	$${-0}$$	$${697.12}$$ < $${703.12}$$	$${+0.04}$$	$${177.77}$$ < $${180.53}$$
✅	agent_suse_amd64_fips	$${-0}$$	$${691.62}$$ < $${697.6}$$	$${+0.01}$$	$${176.18}$$ < $${178.87}$$
✅	agent_suse_arm64	$${+0}$$	$${683.25}$$ < $${689.82}$$	$${+0.01}$$	$${159.02}$$ < $${162.16}$$
✅	agent_suse_arm64_fips	$${+0}$$	$${678.76}$$ < $${685.08}$$	$${-0.01}$$	$${157.9}$$ < $${161.11}$$
✅	docker_agent_amd64	$${-0}$$	$${768.5}$$ < $${774.54}$$	$${+0}$$	$${263.2}$$ < $${266.46}$$
✅	docker_agent_arm64	$${+0}$$	$${778.58}$$ < $${785.2}$$	$${+0}$$	$${249.28}$$ < $${252.92}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${959.37}$$ < $${965.41}$$	$${+0}$$	$${331.82}$$ < $${335.08}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${958.04}$$ < $${964.66}$$	$${+0}$$	$${313.88}$$ < $${317.54}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${212.85}$$ < $${213.74}$$	$${-0}$$	$${72.2}$$ < $${73.2}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${228.8}$$ < $${229.68}$$	$${-0}$$	$${68.49}$$ < $${69.48}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.06}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.39}$$ < $${39.3}$$	$${+0}$$	$${14.83}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.05}$$ < $${37.94}$$	$${+0}$$	$${14.28}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.62}$$ < $${30.53}$$	$${+0}$$	$${7.82}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.21}$$ < $${29.12}$$	$${-0}$$	$${6.77}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.62}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.77}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.62}$$ < $${30.53}$$	$${-0}$$	$${7.83}$$ < $${8.77}$$
✅	iot_agent_deb_amd64	$${0}$$	$${54.64}$$ < $${54.97}$$	$${+0}$$	$${13.65}$$ < $${14.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${51.44}$$ < $${51.84}$$	$${+0}$$	$${11.85}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${54.64}$$ < $${54.97}$$	$${+0}$$	$${13.67}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	$${0}$$	$${54.64}$$ < $${54.97}$$	$${+0}$$	$${13.67}$$ < $${14.47}$$