You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for templating extra_dbname into a database template for the AWS Aurora auto discovery feature. This will allow users with a non-standard dbname set to automatically discover the primary database named in the Aurora instances.
Non standardised dbname configuration in our organisations cloud real estate, where we follow neither a practice of using the default postgres db nor a standardised alternative such as app - which is the only hurdle we see in enabling autodiscovery.
Describe how to test/QA your changes
Instance template configured with a database name, using the templated extra_dbname variable.
dbname: %%extra_dbname%%
it would be best to test this against an aurora instance configured with a name which is not postgres, to avoid defaults.
lu-zhengda
added
qa/done
QA done before merge and regressions are covered by tests
and removed
qa/rc-required
Only for a PR that requires validation on the Release Candidate
labels
Dec 19, 2024
Tested in staging with %%extra_dbname%%.
The testing cluster uses mydb instead of the default postgres dbname.
Postgres integration config receives dbname: "%%extra_dbname%%" from autodiscovery.
2024-12-19 18:51:43 UTC ℹ️ MergeQueue: waiting for PR to be ready
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.
2024-12-19 22:51:45 UTC⚠️MergeQueue: This merge request was unqueued
[email protected] unqueued this merge request: It did not become mergeable within the expected time
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lu-zhengda
added
the
qa/rc-required
What does this PR do?
Adds support for templating extra_dbname into a database template for the AWS Aurora auto discovery feature. This will allow users with a non-standard dbname set to automatically discover the primary database named in the Aurora instances.
Fixes #31123
Motivation
Non standardised dbname configuration in our organisations cloud real estate, where we follow neither a practice of using the default
postgresdb nor a standardised alternative such asapp- which is the only hurdle we see in enabling autodiscovery.Describe how to test/QA your changes
Instance template configured with a database name, using the templated extra_dbname variable.
it would be best to test this against an aurora instance configured with a name which is not
postgres, to avoid defaults.Possible Drawbacks / Trade-offs
Additional Notes