Make buildifier faster on Windows

Author: rdesgroppes

.gitlab/bazel/build-deps.yaml

@@ -47,5 +47,4 @@ bazel:build-deps:windows-amd64:
     ARCH: x64
     SCRIPT: |-
       echo "🟡 TODO(regis): compilation errors remain - limiting to a working subset for the time being"
-      bazel build '@zlib//...' '@libffi'
-      # bazel build @bzip2//...
+      bazel run //bazel/buildifier

bazel/patches/buildifier-runner-bat-template.patch

@@ -1,8 +1,8 @@
 diff --git a/buildifier/runner.bat.template b/buildifier/runner.bat.template
-index 13ca3fa..d8ccac9 100644
+index 13ca3fa..a9a5828 100644
 --- a/buildifier/runner.bat.template
 +++ b/buildifier/runner.bat.template
-@@ -11,9 +11,34 @@ set stripped_args=%stripped_args:'=%
+@@ -11,35 +11,49 @@ set stripped_args=%stripped_args:'=%
  rem Get the absolute path to the buildifier executable
 -for /f "tokens=2" %%i in ('findstr /r "\<buildifier\.exe\>" MANIFEST') do (set buildifier_abs_path=%%i)
 +if exist MANIFEST (
@@ -16,33 +16,65 @@ index 13ca3fa..d8ccac9 100644
 +for /f "tokens=2" %%i in ('findstr /r "\<buildifier\.exe\>" "%manifest_file%"') do (set buildifier_abs_path=%%i)
 
  powershell ^
+-function Buildify($Root)^
++$startTime = Get-Date;^
 +function Should-Exclude($Path)^
-+{^
+ {^
+-    $Folder = (New-Object -Com Scripting.FileSystemObject).GetFolder($Root);^
+-    $Files = $Folder.Files ^| Where-Object {^
+-        $_.Name -eq 'BUILD.bazel' `^
+-        -or $_.Name -eq 'BUILD' `^
+-        -or $_.Name -eq 'WORKSPACE' `^
+-        -or $_.Name -eq 'WORKSPACE.bazel' `^
+-        -or $_.Name -eq 'WORKSPACE.oss' `^
+-        -or $_.Name  -clike '*.bzl' `^
+-        -or $_.Name -clike '*.sky' `^
+-        -or $_.Name -clike '*.BUILD' `^
+-        -or $_.Name -clike 'BUILD.*.bazel' `^
+-        -or $_.Name -clike 'BUILD.*.oss' `^
+-        -or $_.Name -clike 'WORKSPACE.*.bazel' `^
+-        -or $_.Name -clike 'WORKSPACE.*.oss'^
+-    };^
+-    foreach ($File in $Files)^
+-    {^
+-        ^& '%buildifier_abs_path%' %stripped_args% $File.Path;^
+-    };^
+-    foreach ($SubFolder in $Folder.Subfolders)^
 +    $relPath = '.' + $Path.Substring('%BUILD_WORKSPACE_DIRECTORY%'.Length);^
 +    foreach ($pattern in @(@@EXCLUDE_PATTERNS@@))^
-+    {^
+     {^
+-        $CurrentItem = Get-Item $SubFolder.Path -ErrorAction SilentlyContinue;^
+-        if ($CurrentItem -and !$CurrentItem.Attributes.ToString().Contains('ReparsePoint'))^
 +        if ($relPath -clike $pattern)^
-+        {^
+         {^
+-            Buildify($SubFolder.Path);^
++            Write-Host excl relPath=$relPath;^
 +            return $true;^
-+        };^
-+    };^
+         };^
+     };^
++    Write-Host incl relPath=$relPath;^
 +    return $false;^
 +};^
- function Buildify($Root)^
- {^
-+    if (Should-Exclude $Root)^
-+    {^
-+        return;^
-+    };^
-     $Folder = (New-Object -Com Scripting.FileSystemObject).GetFolder($Root);^
-     $Files = $Folder.Files ^| Where-Object {^
-+        (^
-         $_.Name -eq 'BUILD.bazel' `^
-@@ -30,2 +55,3 @@ function Buildify($Root)^
-         -or $_.Name -clike 'WORKSPACE.*.oss'^
-+        ) -and -not (Should-Exclude $_.Path)^
-     };^
-@@ -44,2 +70,2 @@ function Buildify($Root)^
++$Files = Get-ChildItem -LiteralPath '%BUILD_WORKSPACE_DIRECTORY:/=\%' -Recurse -File -ErrorAction SilentlyContinue ^| Where-Object {^
++    (^
++    $_.Name -eq 'BUILD.bazel' `^
++    -or $_.Name -eq 'BUILD' `^
++    -or $_.Name -eq 'WORKSPACE' `^
++    -or $_.Name -eq 'WORKSPACE.bazel' `^
++    -or $_.Name -eq 'WORKSPACE.oss' `^
++    -or $_.Name  -clike '*.bzl' `^
++    -or $_.Name -clike '*.sky' `^
++    -or $_.Name -clike '*.BUILD' `^
++    -or $_.Name -clike 'BUILD.*.bazel' `^
++    -or $_.Name -clike 'BUILD.*.oss' `^
++    -or $_.Name -clike 'WORKSPACE.*.bazel' `^
++    -or $_.Name -clike 'WORKSPACE.*.oss'^
++    ) -and -not (Should-Exclude $_.FullName)^
++};^
++if ($Files)^
++{^
++    ^& '%buildifier_abs_path%' %stripped_args% $Files.FullName;^
  };^
 -Buildify('%BUILD_WORKSPACE_DIRECTORY%');
-+Buildify('%BUILD_WORKSPACE_DIRECTORY:/=\%');
++$duration = (Get-Date) - $startTime;^
++Write-Host ('Execution time: {0:N2} seconds' -f $duration.TotalSeconds);