-
-
Notifications
You must be signed in to change notification settings - Fork 3
docs: dts-tests.md: add custom iPXE server manual #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Daniil Klimuk <[email protected]>
4fb95c7
to
cb346e2
Compare
docs/dts-tests.md
Outdated
From now the `dts.ipxe` can be used via iPXE shell by typing: | ||
|
||
```text | ||
chain http://IP:8080/dts.ipxe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chain http://IP:8080/dts.ipxe | |
chain http://localhost:8080/dts.ipxe |
and :4321
if you use script. Not sure if this step is even needed, and you assume reader knows where to write this chain
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why localhost
? Are you launching the server on the same hardware, where you are booting the files from the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and you assume reader knows where to write this chain command
I assume the user knows what is the iPXE shell
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you launching the server on the same hardware, where you are booting the files from the server?
Yes? How else are you running E2E tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, for E2E it is ok, but I had have been using it for testing on hardware too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then fix documentation? This setup is for E2E tests:
## E2E tests
(...)
### HTTP server with DTS iPXE boot
This subsection is under E2E tests.
Remove one #
, and mention that you can use localhost
when referencing in E2E section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you are right
Signed-off-by: Daniil Klimuk <[email protected]>
No description provided.