Add functionality for running tests on a remote machine #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrushnic
force-pushed
the
support-for-qemu-run-on-remote-machine
branch
from
1f22fac to
9fdc43c
Compare
…... kwd Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
This commit introduces a new feature that allows users to run tests on a remote machine. This is particularly useful when running QEMU on the local machine is not desirable due to security concerns or memory limitations. The changes include updates to the documentation to explain the new feature and a new script, `remote-runner.sh`, which handles the synchronization of a local directory to a remote machine and the execution of QEMU based on parameters on the remote machine. Signed-off-by: Piotr Król <[email protected]>
pietrushnic
force-pushed
the
support-for-qemu-run-on-remote-machine
branch
from
9fdc43c to
22cd658
Compare
This commit refactors the qemu-run.sh and remote-runner.sh scripts to improve their flexibility and usability. In qemu-run.sh, the ACTION parameter has been split into ACTION and FIRMWARE parameters. This allows the user to specify the action (os or os_install) and the firmware (uefi or seabios) separately, providing more flexibility in the configuration of the QEMU instance. The usage instructions have been updated accordingly. Now we are not limited to run tests or install only on uefi. In remote-runner.sh, the number of required parameters has been increased from 4 to 5 to accommodate the new FIRMWARE parameter in qemu-run.sh. The usage instructions and error messages have been updated to reflect this change. Additionally, the shebang in remote-runner.sh has been changed from different systems. Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
pietrushnic
changed the base branch from
seabios-support-for-network-boot-tests
to
seabios-support
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
It is very interesting that incorrect pattern fails because of
underlying logic:
KEYWORD ${matches} = BuiltIn . Run Keyword And Return Status Should Match, ${item}, *${option}*
Documentation:
23:12:21.311 TRACE Arguments: [ '2. AHCI/0: QEMU HARDDISK ATA-7 Hard-Disk (20480 MiBytes)' | '*[setup]*' ]
23:12:21.311 TRACE Return: None
23:12:21.311 TRACE Return: True
23:12:21.311 INFO ${matches} = True
So this one return True, but following one return False:
KEYWORD ${matches} = BuiltIn . Run Keyword And Return Status Should Match, ${item}, *${option}*
Documentation:
Fails if the given string does not match the given pattern.
Start / End / Elapsed: 20241216 23:12:21.307 / 20241216 23:12:21.309 / 00:00:00.002
23:12:21.307 TRACE Arguments: [ '1. DVD/CD [AHCI/2: QEMU DVD-ROM ATAPI-4 DVD/CD]' | '*[setup]*' ]
23:12:21.308 FAIL '1. DVD/CD [AHCI/2: QEMU DVD-ROM ATAPI-4 DVD/CD]' does not match '*[setup]*'
23:12:21.309 DEBUG Traceback (most recent call last):
None
AssertionError: '1. DVD/CD [AHCI/2: QEMU DVD-ROM ATAPI-4 DVD/CD]' does not match '*[setup]*'
23:12:21.309 TRACE Return: False
23:12:21.309 INFO ${matches} = False
Signed-off-by: Piotr Król <[email protected]>
This patch fix the problem where virtio-net by delivering its pxe rom interfere with the fact that seabios needs empty romfile and use built in iPXE to do network boot and work with developed tests. Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
…ers in env variables no mater the QEMU_FW_FILE Signed-off-by: Piotr Król <[email protected]>
miczyg1
reviewed
Jan 30, 2025
Co-authored-by: Michał Żygowski <[email protected]>
|
@miczyg1, why did you get back to this PR after so long? Is that helpful code somewhere? |
I had a JIRAfication day yesterday. Too many red tasks, tasks in verification to unblock someone, etc. piled up. The task related to this PR is in progress since the beginning and there is no perspective for it to be closed soon. If this has close to no value, then maybe the task should be closed? @pietrushnic |
|
@miczyg1 no, it has value, at least for me. Please ping me in an internal task for that. So we can clarify WTH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new feature that allows users to run tests on a remote machine. This is particularly useful when running QEMU on the local machine is not desirable due to security concerns or memory limitations.
The changes include updates to the documentation to explain the new feature and a new script,
remote-runner.sh, which handles the synchronization of a local directory to a remote machine and the execution of QEMU based on parameters on the remote machine.