Skip to content

Commit c646647

Browse files
committed
platform-configs/include/pcengines.robot: keyboard config updated
PC Engines-specific conditions removed from: USB keybard test skip: dasharo-compatibility/usb-hid-misc-msc-support.robot Flash WP GPIO manipulation: util/basic-platform-setup.robot lib/flash.robot Signed-off-by: Mateusz Maciejewski <[email protected]>
1 parent 72cd642 commit c646647

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

dasharo-compatibility/usb-hid-and-msc-support.robot

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ USB002.001 USB keyboard detected in FW
4242
[Tags] automated minimal-regression
4343
Depends On ${TESTS_IN_FIRMWARE_SUPPORT}
4444
Depends On ${HAS_KEYBOARD}
45-
Skip If '${MANUFACTURER}' == 'PC Engines'
4645
Deploy Uefi Shell
4746
Power On
4847
Enter UEFI Shell

lib/flash.robot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,11 @@ Read Firmware
173173
[Arguments] ${file}
174174

175175
IF '${FLASHING_METHOD}' == 'external'
176-
IF '${MANUFACTURER}' == 'PC Engines' and '${APU_FLASH_WP_GPIO}' != '${TBD}'
176+
IF '${APU_FLASH_WP_GPIO}' != '${TBD}'
177177
Rte Gpio Set ${APU_FLASH_WP_GPIO} low
178178
END
179179
Rte Flash Read ${file}
180-
IF '${MANUFACTURER}' == 'PC Engines' and '${APU_FLASH_WP_GPIO}' != '${TBD}'
180+
IF '${APU_FLASH_WP_GPIO}' != '${TBD}'
181181
Rte Gpio Set ${APU_FLASH_WP_GPIO} high-z
182182
END
183183
ELSE IF '${FLASHING_METHOD}' == 'internal'

platform-configs/include/pcengines.robot

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ ${DMIDECODE_FAMILY}= N/A
3939
# TODO
4040
${DMIDECODE_TYPE}= Desktop
4141
${INTERNAL_PROGRAMMER_CHIPNAME}= W25Q64BV/W25Q64CV/W25Q64FV
42+
${DEVICE_USB_KEYBOARD}= ${EMPTY}
4243

4344
# Supported test environments
4445
${TESTS_IN_FIRMWARE_SUPPORT}= ${TRUE}
@@ -80,6 +81,7 @@ ${ESP_SCANNING_SUPPORT}= ${TRUE}
8081
${DTS_FIRMWARE_FLASHING_SUPPORT}= ${TRUE}
8182
${MINI_PC_IE_SLOT_SUPPORT}= ${TRUE}
8283
${APU_CONFIGURATION_MENU_SUPPORT}= ${TRUE}
84+
${DUT_HAS_CMOS_RESET}= ${FALSE}
8385

8486
# Test module: dasharo-security
8587
${TPM_SUPPORTED_VERSION}= 2

util/basic-platform-setup.robot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,11 @@ BPS006.001 Ensure test dependencies
111111
BPS007.001 External flashing
112112
[Documentation] This test verifies if the flash die can be detected.
113113
Skip If '${FLASHING_METHOD}' != 'external'
114-
IF '${MANUFACTURER}' == 'PC Engines' and '${APU_FLASH_WP_GPIO}' != '${TBD}'
114+
IF '${APU_FLASH_WP_GPIO}' != '${TBD}'
115115
Rte Gpio Set ${APU_FLASH_WP_GPIO} low
116116
END
117117
${rc}= Rte Flash Probe
118-
IF '${MANUFACTURER}' == 'PC Engines' and '${APU_FLASH_WP_GPIO}' != '${TBD}'
118+
IF '${APU_FLASH_WP_GPIO}' != '${TBD}'
119119
Rte Gpio Set ${APU_FLASH_WP_GPIO} high-z
120120
END
121121
Should Be Equal As Integers ${rc} 0

0 commit comments

Comments
 (0)