Skip to content

Commit c62f5e2

Browse files
philipandamkopec
authored andcommitted
lib/flash.robot, dcu.robot: Increase timeout when flashing
Flashing most of the times takes at least a minute. By default Execute Command Via Terminal timeouts after 30s closing connection mid flashing. Signed-off-by: Filip Gołaś <[email protected]>
1 parent 1dc8f62 commit c62f5e2

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

lib/flash.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Flash Via Internal Programmer With Args
1717
... Should Contain ${out_flash} VERIFIED
1818
IF not ${success}
1919
Log Retry flashing once again in case of failure
20-
${out_flash}= Execute Command In Terminal flashrom -p internal -w ${fw_file_path} ${args}
20+
${out_flash}= Execute Command In Terminal flashrom -p internal -w ${fw_file_path} ${args} 300s
2121
IF "Warning: Chip content is identical to the requested image." in """${out_flash}"""
2222
RETURN
2323
END

lib/options/dcu.robot

+3-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ Set UEFI Option
2323
Login To Linux
2424
Switch To Root User
2525
Get Flashrom From Cloud
26-
Execute Command In Terminal flashrom -p internal -r coreboot.rom --fmap -i FMAP -i SMMSTORE &> /dev/null
26+
${result}= Execute Command In Terminal flashrom -p internal -r coreboot.rom --fmap -i FMAP -i SMMSTORE
27+
Should Not Contain ${result} read-only
2728
Execute Command In Terminal chmod 666 coreboot.rom
2829
SSHLibrary.Get File coreboot.rom dcu/coreboot.rom
2930
${result}= Run Process
@@ -32,7 +33,7 @@ Set UEFI Option
3233
Should Contain ${result.stdout} Success
3334
SSHLibrary.Put File dcu/coreboot.rom coreboot.rom
3435
${result}= Execute Command In Terminal
35-
... flashrom -p internal -w coreboot.rom --fmap -i SMMSTORE --noverify-all &> /dev/null
36+
... flashrom -p internal -w coreboot.rom --fmap -i SMMSTORE 300s
3637
Should Contain ${result} VERIFIED
3738
Execute Reboot Command
3839
# Assume we don't have serial to tell us that we've rebooted, so just wait

platform-configs/novacustom-v560tnd.robot

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ Resource include/novacustom-mtl.robot
77
# CPU
88
${CPU}= Intel(R) Core(TM) Ultra 7 155H
99

10-
${3_MDEB_WIFI_NETWORK}= 3mdeb_abr
11-
${DEVICE_NVME_DISK}= Non-Volatile memory controller
12-
${DEVICE_USB_KEYBOARD}= Logitech, Inc. Keyboard K120
13-
${DMIDECODE_PRODUCT_NAME}= V5xTNC_TND_TNE
14-
${EXTERNAL_HEADSET}= USB PnP Audio Device
15-
${CPU_MAX_FREQUENCY}= 4800
16-
${CPU_MIN_FREQUENCY}= 200
10+
${3_MDEB_WIFI_NETWORK}= 3mdeb_abr
11+
${DEVICE_NVME_DISK}= Non-Volatile memory controller
12+
${DEVICE_USB_KEYBOARD}= Logitech, Inc. Keyboard K120
13+
${DMIDECODE_PRODUCT_NAME}= V5xTNC_TND_TNE
14+
${EXTERNAL_HEADSET}= USB PnP Audio Device
15+
${CPU_MAX_FREQUENCY}= 4800
16+
${CPU_MIN_FREQUENCY}= 200
1717

1818
${NVIDIA_GRAPHICS_CARD_SUPPORT}= ${TRUE}
1919

platform-configs/novacustom-v560tne.robot

+1-2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,5 @@ ${TESTS_IN_WINDOWS_SUPPORT}= ${FALSE} # change windows/ubuntu support
2424
${TESTS_IN_UBUNTU_SUPPORT}= ${TRUE} # on which OS is first in the boot order
2525
${USB_STACK_SUPPORT}= ${TRUE}
2626

27-
${USB_DETECTION_ITERATIONS_NUMBER}= 1
28-
${BOOT_FROM_USB_ITERATIONS_NUMBER}= 1
27+
${BOOT_FROM_USB_ITERATIONS_NUMBER}= 3
2928
${WIFI_CARD}= Intel(R) Wi-Fi 6E AX211 160MHz

0 commit comments

Comments
 (0)