check for empty list wit ETH variables

These are lists, not single variables, so should not be compared against
${EMPTY} or ''.

Also, set the default variables to empty lists, rather than TBD string.

Signed-off-by: Maciej Pijanowski <[email protected]>

Author: macpijan

dasharo-compatibility/check-ethernet-ports-order.robot

@@ -23,7 +23,7 @@ Default Tags        automated
 SPS001.001 Ethernet ports are in order
     [Documentation]    This test automates the verification of port order based
     ...    on PCIe bus numbers and checks PCIe switching.
-    Skip If    '''${ETH_PORTS}''' == ''    not supported
+    Depends On    '${ETH_PORTS}' != '@{EMPTY}'    not supported
     Power On
     Boot System Or From Connected Disk    ${ENV_ID_UBUNTU}
     Login To Linux

dasharo-compatibility/network-speed.robot

@@ -29,8 +29,8 @@ ETHPERF001.201 Check Performance of 2.5G Wired Network Interface (Ubuntu)
     ...
     ...    Previous IDs: ETHPERF001.001
     [Tags]    semiauto
-    Depends On    ${ETH_PERF_PAIR_2_G}
-    Depends On    ${ETH_PORTS}
+    Depends On    '${ETH_PERF_PAIR_2_G}' != '@{EMPTY}'
+    Depends On    '${ETH_PORTS}' != '@{EMPTY}'
 
     ${eth_ports_number}=    Get Length    ${ETH_PORTS}
     IF    '${eth_ports_number}' == '2'
@@ -81,7 +81,7 @@ ETHPERF002.201 Check Performance of 10G Wired Network Interface (Ubuntu)
     ...
     ...    Previous IDs: ETHPERF002.001
     [Tags]    automated
-    Depends On    ${ETH_PERF_PAIR_10_G}
+    Depends On    '${ETH_PERF_PAIR_10_G}' != '@{EMPTY}'
     Power On
     Boot System Or From Connected Disk    ${ENV_ID_UBUNTU}
     Login To Linux

lib/framework.robot

@@ -8,10 +8,11 @@ Depends On Variable
 Depends On
     [Documentation]    Skips test if ``condition`` is not met. Test identifier
     ...    (first word of its name) and optional ``reason`` is set
-    ...    to the test as per ```Skip`` keyword.
+    ...    to the test as per ``Skip`` keyword.
     [Arguments]    ${condition}    ${reason}=${NONE}
     ${line}=    Set Variable    ${TEST_NAME.split()}[0] not supported
-    IF    """${reason}""" != """${NONE}"""
+    IF    "${reason}" != "${NONE}"
         ${line}=    Set Variable    ${line}: ${reason}
     END
-    Skip If    not ${condition}    ${line}
+    ${should_skip}=    Evaluate    not bool(${condition})
+    Skip If    ${should_skip}    ${line}

platform-configs/include/default.robot

@@ -296,6 +296,12 @@ ${USE_ANSIBLE}=                                     ${TRUE}
 ${TESTS_IN_XCP_NG_SUPPORT}=                         ${FALSE}
 ${TESTS_IN_ESXI_SUPPORT}=                           ${FALSE}
 
+@{ETH_PERF_PAIR_10_G}=                              @{EMPTY}
+@{ETH_PERF_PAIR_1_G}=                               @{EMPTY}
+@{ETH_PERF_PAIR_2_G}=                               @{EMPTY}
+@{ETH_PORTS}=                                       @{EMPTY}
+@{ETH_SFP_PORTS}=                                   @{EMPTY}
+
 # These were missing in default.robot and have been automatically
 # identified and added via: ./scripts/ci/check_platform_configs_vars.py
 
@@ -384,11 +390,6 @@ ${WIN_SEQ_WRITE_QUEUED}=                            ${TBD}
 ${ZIP_MULTI_COMPRESSION}=                           ${TBD}
 ${ZIP_MULTI_DECOMPRESSION}=                         ${TBD}
 ${FAN_RPM_MEASUREMENT_SENSOR_MODULE}=               ${TBD}
-@{ETH_PERF_PAIR_10_G}=                              ${TBD}
-@{ETH_PERF_PAIR_1_G}=                               ${TBD}
-@{ETH_PERF_PAIR_2_G}=                               ${TBD}
-@{ETH_PORTS}=                                       ${TBD}
-@{ETH_SFP_PORTS}=                                   ${TBD}
 
 
 *** Keywords ***