Skip to content

Commit 510be26

Browse files
philipandamkopec
philipanda
authored and
mkopec
committed
platform-configs: Replace ${EMPTY} with ${TBD}
Signed-off-by: Filip Gołaś <[email protected]>
1 parent b0860ac commit 510be26

14 files changed

+50
-50
lines changed

‎platform-configs/include/msi-z690-common.robot

+5-5
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ ${DUT_CONNECTION_METHOD}= ${INITIAL_DUT_CONNECTION_METHOD}
1111
${PAYLOAD}= tianocore
1212
${RTE_S2_N_PORT}= 13541
1313
${FLASH_SIZE}= ${32*1024*1024}
14-
${FLASH_LENGTH}= ${EMPTY}
14+
${FLASH_LENGTH}= ${TBD}
1515
${TIANOCORE_STRING}= to boot directly
1616
${BOOT_MENU_KEY}= F11
1717
${SETUP_MENU_KEY}= Delete
1818
${BOOT_MENU_STRING}= Please select boot device:
1919
${SETUP_MENU_STRING}= Select Entry
2020
${IPXE_BOOT_ENTRY}= iPXE Network Boot
2121
${EDK2_IPXE_CHECKPOINT}= iPXE Shell
22-
${MANUFACTURER}= ${EMPTY}
23-
${CPU}= ${EMPTY}
22+
${MANUFACTURER}= ${TBD}
23+
${CPU}= ${TBD}
2424
${POWER_CTRL}= sonoff
2525
${FLASH_VERIFY_METHOD}= none
26-
${WIFI_CARD}= ${EMPTY}
26+
${WIFI_CARD}= ${TBD}
2727
${MAX_CPU_TEMP}= 80
2828

2929
${DMIDECODE_MANUFACTURER}= Micro-Star International Co., Ltd.
@@ -36,7 +36,7 @@ ${DEVICE_NVME_DISK}= Non-Volatile memory controller
3636
${DEVICE_AUDIO1}= ALC897
3737
${DEVICE_AUDIO2}= Alderlake HDMI
3838
${DEVICE_AUDIO1_WIN}= Realtek High Definition Audio
39-
${WIFI_CARD_UBUNTU}= ${EMPTY}
39+
${WIFI_CARD_UBUNTU}= ${TBD}
4040
${USB_MODEL}= Kingston
4141
${USB_DEVICE}= Multifunction Composite Gadget
4242

‎platform-configs/include/novacustom-common.robot

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ ${BOOT_MENU_STRING}= Please select boot device:
1717
${SETUP_MENU_STRING}= Select Entry
1818
${IPXE_BOOT_ENTRY}= iPXE Network Boot
1919
${EDK2_IPXE_CHECKPOINT}= iPXE Shell
20-
${MANUFACTURER}= ${EMPTY}
21-
${CPU}= ${EMPTY}
20+
${MANUFACTURER}= ${TBD}
21+
${CPU}= ${TBD}
2222
${POWER_CTRL}= sonoff
2323
${FLASH_VERIFY_METHOD}= none
2424
${MAX_CPU_TEMP}= 82

‎platform-configs/include/novacustom-tgl.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ${FLASH_SIZE}= ${16*1024*1024}
66
${INITIAL_CPU_FREQUENCY}= 2800
77
${DEF_CORES_PER_SOCKET}= 4
88
${DEF_THREADS_PER_CORE}= 2
9-
${DEF_THREADS_TOTAL}= ${EMPTY}
9+
${DEF_THREADS_TOTAL}= ${TBD}
1010
# TODO: remove, the value below can be inferred from the one above
1111
${DEF_ONLINE_CPU}= 0-7
1212
${DEF_SOCKETS}= 1

‎platform-configs/include/pcengines.robot

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ${DUT_CONNECTION_METHOD}= ${INITIAL_DUT_CONNECTION_METHOD}
99
${PAYLOAD}= tianocore
1010
${RTE_S2_N_PORT}= 13541
1111
${FLASH_SIZE}= ${8*1024*1024}
12-
${FLASH_LENGTH}= ${EMPTY}
12+
${FLASH_LENGTH}= ${TBD}
1313
${TIANOCORE_STRING}= ENTER
1414
${BOOT_MENU_KEY}= ${F10}
1515
${SETUP_MENU_KEY}= ${DELETE}
@@ -30,7 +30,7 @@ ${FLASH_VERIFY_METHOD}= tianocore-shell
3030
${FLASH_VERIFY_OPTION}= UEFI Shell
3131
${AUTO_BOOT_TIME_OUT_DEFAULT_VALUE}= 6
3232
# TODO
33-
${MAX_CPU_TEMP}= ${EMPTY}
33+
${MAX_CPU_TEMP}= ${TBD}
3434
${CPU_MIN_FREQUENCY}= 300
3535
${CPU_MAX_FREQUENCY}= 1500
3636
${DMIDECODE_MANUFACTURER}= PC Engines

‎platform-configs/include/protectli-common.robot

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@ ${INITIAL_DUT_CONNECTION_METHOD}= Telnet
77
${DUT_CONNECTION_METHOD}= ${INITIAL_DUT_CONNECTION_METHOD}
88
${PAYLOAD}= tianocore
99
${RTE_S2_N_PORT}= 13541
10-
${FLASH_LENGTH}= ${EMPTY}
10+
${FLASH_LENGTH}= ${TBD}
1111
${TIANOCORE_STRING}= to boot directly
1212
${BOOT_MENU_KEY}= ${F11}
1313
${SETUP_MENU_KEY}= ${DELETE}
1414
${BOOT_MENU_STRING}= Please select boot device
1515
${SETUP_MENU_STRING}= Select Entry
1616
${IPXE_BOOT_ENTRY}= Network Boot and Utilities
1717
${EDK2_IPXE_CHECKPOINT}= Advanced
18-
${MANUFACTURER}= ${EMPTY}
19-
${CPU}= ${EMPTY}
18+
${MANUFACTURER}= ${TBD}
19+
${CPU}= ${TBD}
2020
${POWER_CTRL}= RteCtrl
2121
${FLASH_VERIFY_METHOD}= tianocore-shell
2222
${FLASH_VERIFY_OPTION}= UEFI Shell

‎platform-configs/minnowboard-turbot.robot

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ${DUT_CONNECTION_METHOD}= ${INITIAL_DUT_CONNECTION_METHOD}
88
${PAYLOAD}= tianocore
99
${RTE_S2_N_PORT}= 13542
1010
${FLASH_SIZE}= ${8*1024*1024}
11-
${FLASH_LENGTH}= ${EMPTY}
11+
${FLASH_LENGTH}= ${TBD}
1212
${TIANOCORE_STRING}= to enter Boot Manager Menu
1313
${BOOT_MENU_STRING}= Please select boot device:
1414
${BOOT_MENU_KEY}= ${F7}
@@ -20,8 +20,8 @@ ${CPU}= Intel Atom E3845 SoC
2020
${POWER_CTRL}= RteCtrl
2121
${FLASH_VERIFY_METHOD}= tianocore-shell
2222
${FLASH_VERIFY_OPTION}= UEFI Shell
23-
${WIFI_CARD}= ${EMPTY}
24-
${MAX_CPU_TEMP}= ${EMPTY}
23+
${WIFI_CARD}= ${TBD}
24+
${MAX_CPU_TEMP}= ${TBD}
2525

2626
${DEVICE_USB_KEYBOARD}= Logitech, Inc. Keyboard K120
2727

‎platform-configs/protectli-vp2410.robot

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ Resource include/protectli-common.robot
44

55
*** Variables ***
66
${FLASH_SIZE}= ${8*1024*1024}
7-
${WIFI_CARD}= ${EMPTY}
8-
${WIFI_CARD_UBUNTU}= ${EMPTY}
9-
${LTE_CARD}= ${EMPTY}
7+
${WIFI_CARD}= ${TBD}
8+
${WIFI_CARD_UBUNTU}= ${TBD}
9+
${LTE_CARD}= ${TBD}
1010
${DEF_ONLINE_CPU}= 0-3
1111
${DEF_SOCKETS}= 1
1212
${INITIAL_CPU_FREQUENCY}= 2000
@@ -22,7 +22,7 @@ ${E_MMC_NAME}= 8GTF4R
2222
${DMIDECODE_SERIAL_NUMBER}= N/A
2323
${DMIDECODE_FIRMWARE_VERSION}= Dasharo (coreboot+UEFI) v
2424
${DMIDECODE_PRODUCT_NAME}= VP2410
25-
${DMIDECODE_RELEASE_DATE}= ${EMPTY}
25+
${DMIDECODE_RELEASE_DATE}= ${TBD}
2626
${DMIDECODE_MANUFACTURER}= Protectli
2727
${DMIDECODE_VENDOR}= 3mdeb
2828
${DMIDECODE_FAMILY}= Vault Pro

‎platform-configs/protectli-vp2420.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ${FLASHING_METHOD}= internal
1515
# eMMC driver support
1616
${E_MMC_NAME}= 8GTF4R
1717

18-
@{ATTACHED_USB}= ${EMPTY}
18+
@{ATTACHED_USB}= ${TBD}
1919

2020
${DMIDECODE_SERIAL_NUMBER}= N/A
2121
${DMIDECODE_FIRMWARE_VERSION}= Dasharo (coreboot+UEFI) v1.2.0

‎platform-configs/protectli-vp4650.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ ${DEF_SOCKETS}= 1
1212

1313
${POWER_CTRL}= sonoff
1414
${WIFI_CARD_UBUNTU}= Qualcomm Atheros QCA6174
15-
${LTE_CARD}= ${EMPTY}
15+
${LTE_CARD}= ${TBD}
1616
${DEVICE_NVME_DISK}= Non-Volatile memory controller
1717
${USB_MODEL}= SanDisk
1818

‎platform-configs/protectli-vp4670.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ ${DEF_SOCKETS}= 1
1212

1313
${POWER_CTRL}= sonoff
1414
${WIFI_CARD_UBUNTU}= Qualcomm Atheros QCA6174
15-
${LTE_CARD}= ${EMPTY}
15+
${LTE_CARD}= ${TBD}
1616
${DEVICE_NVME_DISK}= Non-Volatile memory controller
1717
${USB_MODEL}= SanDisk
1818

‎platform-configs/protectli-vp6650.robot

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ ${DEF_ONLINE_CPU}= 0-11
1111
${DEF_SOCKETS}= 1
1212

1313
${POWER_CTRL}= sonoff
14-
${WIFI_CARD_UBUNTU}= ${EMPTY}
15-
${LTE_CARD}= ${EMPTY}
14+
${WIFI_CARD_UBUNTU}= ${TBD}
15+
${LTE_CARD}= ${TBD}
1616
${DEVICE_NVME_DISK}= Non-Volatile memory controller
1717
${USB_MODEL}= SanDisk
1818

‎platform-configs/protectli-vp6670.robot

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ ${DEF_ONLINE_CPU}= 0-11
1111
${DEF_SOCKETS}= 1
1212

1313
${POWER_CTRL}= sonoff
14-
${WIFI_CARD_UBUNTU}= ${EMPTY}
15-
${LTE_CARD}= ${EMPTY}
14+
${WIFI_CARD_UBUNTU}= ${TBD}
15+
${LTE_CARD}= ${TBD}
1616
${DEVICE_NVME_DISK}= Non-Volatile memory controller
1717
${USB_MODEL}= SanDisk
1818

‎platform-configs/raptor-cs_talos2.robot

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ${OPEN_BMC_ROOT_PROMPT}= root@talos:~#
1515
${FLASH_VERIFY_METHOD}= none
1616
${POWER_CTRL}= obmcutil
1717

18-
${AUTO_BOOT_TIME_OUT_DEFAULT_VALUE}= ${EMPTY}
18+
${AUTO_BOOT_TIME_OUT_DEFAULT_VALUE}= ${TBD}
1919
${LAPTOP_EC_SERIAL_WORKAROUND}= ${FALSE}
2020

2121
# Platform flashing flags

‎platform-configs/rpi-3b.robot

+22-22
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
*** Variables ***
22
${DUT_CONNECTION_METHOD}= Telnet
3-
${PAYLOAD}= ${EMPTY}
3+
${PAYLOAD}= ${TBD}
44
${RTE_S2_N_PORT}= 13541
5-
${FLASH_SIZE}= ${EMPTY}
6-
${FLASH_LENGTH}= ${EMPTY}
7-
${TIANOCORE_STRING}= ${EMPTY}
8-
${BOOT_MENU_KEY}= ${EMPTY}
9-
${SETUP_MENU_KEY}= ${EMPTY}
10-
${BOOT_MENU_STRING}= ${EMPTY}
11-
${SETUP_MENU_STRING}= ${EMPTY}
12-
${IPXE_BOOT_ENTRY}= ${EMPTY}
13-
${EDK2_IPXE_CHECKPOINT}= ${EMPTY}
14-
${MANUFACTURER}= ${EMPTY}
15-
${CPU}= ${EMPTY}
5+
${FLASH_SIZE}= ${TBD}
6+
${FLASH_LENGTH}= ${TBD}
7+
${TIANOCORE_STRING}= ${TBD}
8+
${BOOT_MENU_KEY}= ${TBD}
9+
${SETUP_MENU_KEY}= ${TBD}
10+
${BOOT_MENU_STRING}= ${TBD}
11+
${SETUP_MENU_STRING}= ${TBD}
12+
${IPXE_BOOT_ENTRY}= ${TBD}
13+
${EDK2_IPXE_CHECKPOINT}= ${TBD}
14+
${MANUFACTURER}= ${TBD}
15+
${CPU}= ${TBD}
1616
${POWER_CTRL}= sonoff
1717
${FLASH_VERIFY_METHOD}= none
18-
${WIFI_CARD}= ${EMPTY}
19-
${WIFI_CARD_UBUNTU}= ${EMPTY}
20-
${LTE_CARD}= ${EMPTY}
18+
${WIFI_CARD}= ${TBD}
19+
${WIFI_CARD_UBUNTU}= ${TBD}
20+
${LTE_CARD}= ${TBD}
2121
# ${ecc_string} Single-bit ECC
2222
# ${IOMMU_string} (XEN) AMD-Vi: IOMMU 0 Enable
2323
# ${dram_size} ${4096}
@@ -31,19 +31,19 @@ ${LTE_CARD}= ${EMPTY}
3131
# ${nic_number} ${4}
3232
${LAPTOP_EC_SERIAL_WORKAROUND}= ${FALSE}
3333

34-
${DEVICE_USB_KEYBOARD}= ${EMPTY}
35-
${DEVICE_NVME_DISK}= ${EMPTY}
36-
${DEVICE_AUDIO1}= ${EMPTY}
37-
${DEVICE_AUDIO2}= ${EMPTY}
38-
${DEVICE_AUDIO1_WIN}= ${EMPTY}
39-
${INITIAL_CPU_FREQUENCY}= ${EMPTY}
34+
${DEVICE_USB_KEYBOARD}= ${TBD}
35+
${DEVICE_NVME_DISK}= ${TBD}
36+
${DEVICE_AUDIO1}= ${TBD}
37+
${DEVICE_AUDIO2}= ${TBD}
38+
${DEVICE_AUDIO1_WIN}= ${TBD}
39+
${INITIAL_CPU_FREQUENCY}= ${TBD}
4040

4141
# SD Wire config
4242
${SD_WIRES_CONNECTED}= ${1}
4343
${SD_WIRE_SERIAL1}= sd-wire_01-80
4444

4545
# eMMC driver support
46-
${E_MMC_NAME}= ${EMPTY}
46+
${E_MMC_NAME}= ${TBD}
4747

4848
# Platform flashing flags
4949

0 commit comments

Comments
 (0)