Add formatting keyboard shortcuts (Ctrl+B bold, Ctrl+I italic, etc.) by Wavesonics · Pull Request #29 · Darkrock-Studios/ComposeTextEditor

Wavesonics · 2026-06-29T08:42:25Z

Closes #22

What

Adds inline formatting keyboard shortcuts to the editor, dispatched in TextEditorKeyCommandHandler and reusing the same span-toggle code path as the markdown toolbar:

Shortcut	Action
`Ctrl+B`	Bold
`Ctrl+I`	Italic
`Ctrl+Shift+X`	Strikethrough
`Ctrl+E`	Inline code

Each shortcut toggles its style over the current selection, or sets a pending style at the cursor for subsequent typing — exactly like clicking the toolbar button.

API

A new TextFormattingShortcuts data class maps each shortcut to the SpanStyle it toggles. It's exposed as a formattingShortcuts parameter on both TextEditor and BasicTextEditor:

Defaults to MarkdownConfiguration.DEFAULT styles so toggled spans round-trip through the markdown extension.
Pass TextFormattingShortcuts.None to disable, or set individual styles to null to unbind a single shortcut.
Supply custom styles to match a customized MarkdownConfiguration.

Notes

Follows the editor's existing Ctrl-based shortcut convention (copy/paste/undo are all Ctrl-only here).
Ctrl+Shift+X (strikethrough) is matched before the Ctrl+X cut branch so it isn't swallowed as a cut.
Shortcuts are gated on enabled, so they're inert in read-only editors.
Scope is limited to inline SpanStyle toggles. Headings/lists/blockquote are line-block operations driven by the markdown extension, not pure span styles, so they're intentionally left out of this change.

Tests

FormattingShortcutTest covers: apply/toggle bold, italic, code, strikethrough-doesn't-cut, pending cursor style with no selection, disabled editor is inert, and None/unbound is ignored.

Wire inline formatting shortcuts into the editor's key handler, reusing the same span-toggle code path as the markdown toolbar: - Ctrl+B: bold - Ctrl+I: italic - Ctrl+Shift+X: strikethrough - Ctrl+E: inline code Bindings and their target SpanStyles are configurable via the new TextFormattingShortcuts, exposed as a parameter on TextEditor and BasicTextEditor. Styles default to the markdown defaults so toggled spans round-trip through the markdown extension; pass TextFormattingShortcuts.None to disable. Closes #22

codacy-production · 2026-07-03T04:39:12Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 28 complexity · 0 duplication

Metric Results

Complexity 28

Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

codacy-production

Pull Request Overview

There is a severe misalignment between this PR's title/description and the actual code changes. While the PR claims to implement formatting keyboard shortcuts (Ctrl+B, Ctrl+I, etc.) and a new TextFormattingShortcuts API, the diff contains only accessibility semantics logic for BasicTextEditor. None of the listed acceptance criteria for keyboard styling shortcuts have been met.

Furthermore, the logic provided for accessibility semantics contains a functional flaw where the relative parameter in selection updates is ignored, and it lacks unit testing to ensure boundary conditions are handled during coordinate mapping. This PR should not be merged in its current state as it fails to deliver the requested feature and introduces incomplete accessibility logic.

About this PR

Critical Intent Mismatch: The PR description discusses keyboard shortcut dispatching and a new styling API, but the submitted code exclusively implements accessibility semantics for text manipulation. The 'formattingShortcuts' parameter and 'TextFormattingShortcuts' data class are entirely missing.
The PR description mentions 'FormattingShortcutTest', but no test files were included in the commit. Please ensure all related files are staged and pushed.

Test suggestions

Missing recommended test scenario: Toggle Bold style using Ctrl+B on a selected range
Missing recommended test scenario: Toggle Italic style using Ctrl+I on a selected range
Missing recommended test scenario: Toggle Inline Code style using Ctrl+E on a selected range
Missing recommended test scenario: Verify Ctrl+Shift+X applies Strikethrough and does not trigger the Cut (Ctrl+X) operation
Missing recommended test scenario: Set a pending style at the cursor with no selection and verify subsequent typing uses that style
Missing recommended test scenario: Verify shortcuts are ignored when the editor is disabled
Verify that setSelection and insertTextAtCursor correctly update state when provided with various string indices

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Missing recommended test scenario: Toggle Bold style using Ctrl+B on a selected range
2. Missing recommended test scenario: Toggle Italic style using Ctrl+I on a selected range
3. Missing recommended test scenario: Toggle Inline Code style using Ctrl+E on a selected range
4. Missing recommended test scenario: Verify Ctrl+Shift+X applies Strikethrough and does not trigger the Cut (Ctrl+X) operation
5. Missing recommended test scenario: Set a pending style at the cursor with no selection and verify subsequent typing uses that style
6. Missing recommended test scenario: Verify shortcuts are ignored when the editor is disabled
7. Verify that setSelection and insertTextAtCursor correctly update state when provided with various string indices

_{TIP Improve review quality by adding custom instructions}
_{TIP How was this review? Give us feedback}

codacy-production · 2026-07-03T04:39:30Z

+					.semantics {
+						editableText = state.getAllText()
+						textSelectionRange = state.selectionAsTextRange()
+						setText { newText ->
+							state.setText(newText)
+							true
+						}
+						insertTextAtCursor { newText ->
+							if (state.selector.hasSelection()) state.selector.deleteSelection()
+							state.insertStringAtCursor(newText)
+							true
+						}
+						setSelection { start, end, _ ->
+							val length = state.getTextLength()
+							val from = start.coerceIn(0, length)
+							val to = end.coerceIn(0, length)
+							if (from == to) {
+								state.cursor.updatePosition(state.getOffsetAtCharacter(from))
+								state.selector.clearSelection()
+							} else {
+								state.selector.updateSelection(
+									state.getOffsetAtCharacter(from),
+									state.getOffsetAtCharacter(to),
+								)
+								state.cursor.updatePosition(state.getOffsetAtCharacter(to))
+							}
+							true
+						}
+						onClick { focusRequester.requestFocus(); true }
+					}


_{🔴 HIGH RISK}

The implementation diverges entirely from the PR description. This file adds accessibility semantics (setText, setSelection, etc.) but contains no logic for keyboard shortcuts (Ctrl+B, Ctrl+I, etc.) or the promised formattingShortcuts API. Please verify if the intended logic was omitted from this commit.

codacy-production · 2026-07-03T04:39:30Z

+							state.insertStringAtCursor(newText)
+							true
+						}
+						setSelection { start, end, _ ->


_{🟡 MEDIUM RISK}

The relative parameter in setSelection is currently ignored. You should handle cases where relative is true by adding the provided offsets to the current selection indices.

codacy-production · 2026-07-03T04:39:30Z

+						setText { newText ->
+							state.setText(newText)
+							true
+						}
+						insertTextAtCursor { newText ->
+							if (state.selector.hasSelection()) state.selector.deleteSelection()
+							state.insertStringAtCursor(newText)
+							true
+						}
+						setSelection { start, end, _ ->
+							val length = state.getTextLength()
+							val from = start.coerceIn(0, length)
+							val to = end.coerceIn(0, length)
+							if (from == to) {
+								state.cursor.updatePosition(state.getOffsetAtCharacter(from))
+								state.selector.clearSelection()
+							} else {
+								state.selector.updateSelection(
+									state.getOffsetAtCharacter(from),
+									state.getOffsetAtCharacter(to),
+								)
+								state.cursor.updatePosition(state.getOffsetAtCharacter(to))
+							}
+							true
+						}


_{🟡 MEDIUM RISK}

Suggestion: The logic for setSelection and insertTextAtCursor involves manual coordinate mapping and state updates. This should be covered by unit tests to ensure indices are correctly coerced and the cursor position remains synchronized with the text state.

codacy-production · 2026-07-03T04:39:30Z

+							} else {
+								state.selector.updateSelection(
+									state.getOffsetAtCharacter(from),
+									state.getOffsetAtCharacter(to),
+								)
+								state.cursor.updatePosition(state.getOffsetAtCharacter(to))
+							}


_{⚪ LOW RISK}

Nitpick: In the else block, calculate state.getOffsetAtCharacter(to) once and store it in a variable to be reused for both state.selector.updateSelection and state.cursor.updatePosition to improve readability and efficiency.

codacy-production

Pull Request Overview

The PR successfully implements the requested keyboard shortcuts and configuration options, meeting most acceptance criteria. However, there is a critical logic gap in TextEditorKeyCommandHandler.kt: if the strikethrough shortcut is disabled via configuration, the Ctrl+Shift+X combination falls through and triggers the 'Cut' handler, which currently only checks for isCtrlPressed. This violates the requirement to prioritize strikethrough over cut and introduces a regression risk for text selection management.

Additionally, the current implementation uses hardcoded Control keys across all platforms. On macOS, this conflicts with standard Emacs-style navigation shortcuts and deviates from the expected use of the Command (Meta) key for formatting. The TextEditorKeyCommandHandler has also reached a high level of cognitive complexity (+16) which warrants refactoring to ensure long-term maintainability.

About this PR

Systemic Complexity: The addition of multiple conditional formatting shortcuts into the main keyboard event handler has increased its cognitive complexity significantly. This makes the core editor logic harder to maintain and test.

2 comments outside of the diff

ComposeTextEditor/src/commonMain/kotlin/com/darkrockstudios/texteditor/input/TextEditorInputModifierNode.kt

_{line 145 ⚪ LOW RISK}
Nitpick: Expose the formattingShortcuts property in the inspector.

Try running the following prompt in your coding agent:

In TextEditorInputModifierElement, update the inspectableProperties method to include a property entry for formattingShortcuts.

ComposeTextEditor/src/commonMain/kotlin/com/darkrockstudios/texteditor/input/TextEditorKeyCommandHandler.kt

_{line 59 🟡 MEDIUM RISK}
Suggestion: The handleKeyEvent function is becoming quite large and complex. Consider refactoring the shortcut logic by extracting formatting commands into a dedicated handler or a lookup map. This would decouple the core navigation/editing logic from optional formatting features.

Try running the following prompt in your IDE agent:

Refactor the handleKeyEvent function in TextEditorKeyCommandHandler.kt to move the formatting shortcut logic (Ctrl+B, I, E, Shift+X) into a separate private method called handleFormattingShortcuts, reducing the complexity of the main when block.

Test suggestions

Ctrl+B toggles bold on selection
Ctrl+I toggles italic on selection
Ctrl+Shift+X toggles strikethrough on selection without triggering cut
Ctrl+E toggles inline code on selection
Shortcuts apply pending cursor style when no selection is present
Shortcuts are ignored when the editor is disabled
Shortcuts can be unbound or disabled via configuration

_{TIP Improve review quality by adding custom instructions}
_{TIP How was this review? Give us feedback}

codacy-production · 2026-07-03T04:41:17Z

+				true
+			}
+
 			keyEvent.isCtrlPressed && keyEvent.key == Key.X -> {


_{🔴 HIGH RISK}

To prevent accidental 'Cut' operations when strikethrough shortcuts are disabled or when other Shift+X combinations are used, ensure the Cut handler explicitly checks that Shift is not pressed.

This might be a simple fix:

Suggested change

keyEvent.isCtrlPressed && keyEvent.key == Key.X -> {

keyEvent.isCtrlPressed && !keyEvent.isShiftPressed && keyEvent.key == Key.X -> {

codacy-production · 2026-07-03T04:41:17Z

+				true
+			}
+
+			keyEvent.isCtrlPressed && keyEvent.key == Key.B &&


_{⚪ LOW RISK}

Suggestion: Restrict these shortcuts to only trigger when Shift is not pressed.

Suggested change

keyEvent.isCtrlPressed && keyEvent.key == Key.B &&

keyEvent.isCtrlPressed && !keyEvent.isShiftPressed && keyEvent.key == Key.B &&

codacy-production Bot reviewed Jul 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add formatting keyboard shortcuts (Ctrl+B bold, Ctrl+I italic, etc.) - #29

Add formatting keyboard shortcuts (Ctrl+B bold, Ctrl+I italic, etc.)#29
Wavesonics wants to merge 1 commit into
mainfrom
feature/formatting-shortcuts

Wavesonics commented Jun 29, 2026

Uh oh!

codacy-production Bot commented Jul 3, 2026

Uh oh!

codacy-production Bot left a comment

Uh oh!

codacy-production Bot Jul 3, 2026

Uh oh!

codacy-production Bot Jul 3, 2026

Uh oh!

codacy-production Bot Jul 3, 2026

Uh oh!

codacy-production Bot Jul 3, 2026

Uh oh!

codacy-production Bot left a comment

Uh oh!

codacy-production Bot Jul 3, 2026

Uh oh!

codacy-production Bot Jul 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	keyEvent.isCtrlPressed && keyEvent.key == Key.X -> {
	keyEvent.isCtrlPressed && !keyEvent.isShiftPressed && keyEvent.key == Key.X -> {

Uh oh!

Conversation

Wavesonics commented Jun 29, 2026

What

API

Notes

Tests

Uh oh!

codacy-production Bot commented Jul 3, 2026

Up to standards ✅

Uh oh!

codacy-production Bot left a comment

Choose a reason for hiding this comment

Pull Request Overview

About this PR

Test suggestions

Uh oh!

codacy-production Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

codacy-production Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

codacy-production Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

codacy-production Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

codacy-production Bot left a comment

Choose a reason for hiding this comment

Pull Request Overview

About this PR

Test suggestions

Uh oh!

codacy-production Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

codacy-production Bot Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant