Skip to content

Invalid texture name makes the game load for a very long time #296

@Groupix05

Description

@Groupix05

Hello, with a recent update, the game takes a very long time to load due to Passive Skill Tree trying to load invalid textures.
This bug is due to the SkillTexturesData class.
Im on Forge 47.4.10 , Minecraft 1.20.1 and Passive Skill Tree 0.7.2c

[00:45:19] [Render thread/WARN]: ResourceLocationException!: Non [a-z0-9/._-] character in path of location: hexerei:textures/book/pictures/pestle_and_mortar_1 - Copy.png
net.minecraft.ResourceLocationException: Non [a-z0-9/._-] character in path of location: hexerei:textures/book/pictures/pestle_and_mortar_1 - Copy.png
	at net.minecraft.resources.ResourceLocation.m_245185_(ResourceLocation.java:242) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.resources.ResourceLocation.<init>(ResourceLocation.java:40) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.resources.ResourceLocation.m_214293_(ResourceLocation.java:71) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.server.packs.FilePackResources.m_8031_(FilePackResources.java:153) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.server.packs.resources.FallbackResourceManager.m_214159_(FallbackResourceManager.java:167) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.server.packs.resources.MultiPackResourceManager.m_214159_(MultiPackResourceManager.java:107) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at com.teamabnormals.blueprint.common.remolder.RemoldedResourceManager.m_214159_(RemoldedResourceManager.java:208) ~[blueprint-1.20.1-7.1.3.jar%23850!/:7.1.3]
	at daripher.skilltree.client.data.SkillTexturesData.m_6213_(SkillTexturesData.java:34) ~[PassiveSkillTree-1.20.1-BETA-0.7.2c-all.jar%231230!/:0.7.2c]
	at net.minecraft.server.packs.resources.ResourceManagerReloadListener.m_10759_(ResourceManagerReloadListener.java:15) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at java.util.concurrent.CompletableFuture$UniRun.tryFire(Unknown Source) ~[?:?]
	at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?]
	at net.minecraft.server.packs.resources.SimpleReloadInstance.m_143940_(SimpleReloadInstance.java:69) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:156) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:130) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:115) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1106) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%231373!/:?]
	at net.minecraft.client.main.Main.main(Main.java:218) ~[forge-47.4.11.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.4.11.jar:?]
	at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.4.11.jar:?]
	at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25) ~[fmlloader-1.20.1-47.4.11.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?]
	at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?]

I know this can be fixed by removing those invalid names, but some authors are no longer active to fix those issues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions