Skip to content

Commit 6e51338

Browse files
committedMar 7, 2024
chore: fix issue with accessbility score not been evaluated proeprly
Signed-off-by: blam <ben@blam.sh>
1 parent 8dc18dc commit 6e51338

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed
 

‎.lighthouseci/scripts/guest-auth.js

-1
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ module.exports = async (browser, context) => {
77
await page.evaluate(() => {
88
localStorage.setItem('@backstage/core:SignInPage:provider', 'guest');
99
});
10-
await page.goto('http://localhost:3000');
1110
};

‎lighthouserc.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
module.exports = {
1717
ci: {
1818
collect: {
19+
// headful: true,
1920
url: [
2021
/** Software Catalog */
2122
'http://localhost:3000/catalog',
@@ -52,7 +53,7 @@ module.exports = {
5253
outputPath: './.lighthouseci/reports',
5354
preset: 'desktop',
5455
},
55-
startServerCommand: 'yarn dev',
56+
startServerCommand: 'yarn start:lighthouse',
5657
startServerReadyPattern: 'webpack compiled successfully',
5758
startServerReadyTimeout: 600000,
5859
numberOfRuns: 1,
@@ -64,7 +65,7 @@ module.exports = {
6465
'categories:pwa': 'off',
6566
'categories:best-practices': 'off',
6667
'categories:seo': 'off',
67-
'categories:accessibility': ['error', { minScore: 0.89 }],
68+
'categories:accessibility': ['error', { minScore: 0.95 }],
6869
},
6970
},
7071
},

‎package.json

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"start": "yarn workspace example-app start",
4343
"start-backend": "yarn workspace example-backend start",
4444
"start-backend:next": "yarn workspace example-backend-next start",
45+
"start:lighthouse": "concurrently 'yarn start' 'yarn start-backend:next'",
4546
"start:microsite": "cd microsite/ && yarn start",
4647
"start:next": "yarn workspace example-app-next start",
4748
"storybook": "yarn ./storybook run start",

0 commit comments

Comments
 (0)
Please sign in to comment.