Some database not decrypting correctly

[DannyGB]

Users report that some databases are not decrypting correctly.

I have no further details so this will require some deep investigation

[dinilu]

Hi there. I am one of the users that reported the bug in the store. I would love to see the app working in my BQ M10 FHD. Let me know if need any info or detail in the investigation to identify the bug

[LarreaMikel]

I also have the problem of incorrect decrypting. If you need further info or logs, don't hesitate to ask for them. Thank you.

[SaltyCybernaut]

I am also experiencing this issue with version 3.0. Given that passwords decrypts to unrecognizable UTF8 symbols when the test passwords using the ASCII character set leads me think that the error could be due to byte shifting. A.K.A byte 2 of the password is parsed like it is byte 1 and the actual 1st byte is skipped.

[t-fe]

Can confirm. Just experienced the issue using a german umlaut.

[luk-s]

Hi @DannyGB. First of all, this is a great app, thank you so much for creating it! :) Secondly, I also stumbled over these decryption issues. Upon further inspection I found two different problems:

1. The aforementioned problem that databases which have master keys that contain certain special characters can't be decrypted (as an example consider this database key_error.zip which has the password 1234€).

2. If certain password entries have an additional encrypted string field, this can lead to some passwords not being displayed correctly (as an example consider this database
   protected_field.zip which has the password 1234. The 'Sample Entry' should have the password 'Password'). These additional encrypted string fields can be set automatically by e.g. browser add-ons, so the user might not even be aware that they exist.

I adapted the code to solve these two problems. You can find my pull request here. Let me know if there's something you don't like about it. :)