Common part pdg and primary has wrong value for Pandora

[noeroy]

Issue in the definition of common.part.pdg, common.part.primary in Pandora reco

https://github.com/DUNE/ND_CAFMaker/blob/main/src/reco/PandoraLArRecoNDBranchFiller.cxx#L412-L417
https://github.com/DUNE/ND_CAFMaker/blob/main/src/reco/PandoraLArRecoNDBranchFiller.cxx#L473-L478

those should be based on reco quantities and not truth quantities in that branch.
Primary in that sense is "linked to the vertex or not"
PDG in that sense is "whatever pdg reconstructed for that particle" (most likely 11 for electron showers, 13 for muon tracks).
https://github.com/DUNE/duneanaobj/blob/main/duneanaobj/StandardRecord/SRRecoParticle.h#L26-L28

Answer from @jback08
We will need to add the reconstruction isPrimary and PDG hypothesis variables to the Pandora ROOT output, which is underway with LArRecoND PandoraPFA/LArRecoND#24. When this has been merged, we can then update the Pandora ND CAF maker to use these new ntuple variables to set these common values correctly.

[jback08]

A PR request has been made for this: #95

[jback08]

Closing this, since the code has been updated in merged PR #95.