fix(evm): validate jump destination high bits#331
Merged
zoowii merged 1 commit intoDTVMStack:mainfrom Feb 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure that EVM jump destinations do not have any high bits (bits 64-255) set in their uint256 values. This is a security fix that prevents jumps to addresses outside the valid 64-bit address space.
Changes:
- Modified the interpreter to return max uint64_t when high bits are set, triggering existing validation
- Added compile-time checks in the MIR compiler to validate jump destinations at both constant and runtime
- Ensured consistent validation across both JUMP and JUMPI opcodes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/evm/interpreter.cpp | Modified Uint256ToUint64 lambda to check high bits and return max uint64_t if set, added <limits> include |
| src/compiler/evm_frontend/evm_mir_compiler.cpp | Added high-bit validation for constant and non-constant jump destinations in both handleJump and handleJumpI functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note