Skip to content

Commit b823744

Browse files
zhaogeHaydenOrz
zhaoge
authored andcommitted
ci: check-types and test unit update
1 parent 694b0cd commit b823744

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

src/parser/trino/trinoErrorListener.ts

+12-11
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,24 @@
11
import { CodeCompletionCore } from 'antlr4-c3';
2-
import { ErrorListener, ParseErrorListener } from '../common/parseErrorListener';
32
import { Parser, Token } from 'antlr4ng';
3+
44
import { TrinoSqlParser } from '../../lib/trino/TrinoSqlParser';
5+
import { ErrorListener, ParseErrorListener } from '../common/parseErrorListener';
56
import { LOCALE_TYPE } from '../common/types';
67

78
export class TrinoErrorListener extends ParseErrorListener {
89
private preferredRules: Set<number>;
910

1011
private objectNames: Map<number, string> = new Map([
11-
[TrinoSqlParser.RULE_catalogName, 'catalog'],
12+
[TrinoSqlParser.RULE_catalogRef, 'catalog'],
1213
[TrinoSqlParser.RULE_catalogNameCreate, 'catalog'],
13-
[TrinoSqlParser.RULE_tableName, 'table'],
14+
[TrinoSqlParser.RULE_tableRef, 'table'],
1415
[TrinoSqlParser.RULE_tableNameCreate, 'table'],
15-
[TrinoSqlParser.RULE_viewName, 'view'],
16+
[TrinoSqlParser.RULE_viewRef, 'view'],
1617
[TrinoSqlParser.RULE_viewNameCreate, 'view'],
17-
[TrinoSqlParser.RULE_schemaName, 'schema'],
18+
[TrinoSqlParser.RULE_schemaRef, 'schema'],
1819
[TrinoSqlParser.RULE_schemaNameCreate, 'schema'],
1920
[TrinoSqlParser.RULE_functionName, 'function'],
20-
[TrinoSqlParser.RULE_columnName, 'column'],
21+
[TrinoSqlParser.RULE_columnRef, 'column'],
2122
[TrinoSqlParser.RULE_columnNameCreate, 'column'],
2223
]);
2324

@@ -45,12 +46,12 @@ export class TrinoErrorListener extends ParseErrorListener {
4546
const [ruleType] = candidate;
4647
const name = this.objectNames.get(ruleType);
4748
switch (ruleType) {
48-
case TrinoSqlParser.RULE_catalogName:
49-
case TrinoSqlParser.RULE_schemaName:
50-
case TrinoSqlParser.RULE_tableName:
51-
case TrinoSqlParser.RULE_viewName:
49+
case TrinoSqlParser.RULE_catalogRef:
50+
case TrinoSqlParser.RULE_schemaRef:
51+
case TrinoSqlParser.RULE_tableRef:
52+
case TrinoSqlParser.RULE_viewRef:
5253
case TrinoSqlParser.RULE_functionName:
53-
case TrinoSqlParser.RULE_columnName: {
54+
case TrinoSqlParser.RULE_columnRef: {
5455
result.push(`{existing}${name}`);
5556
break;
5657
}

test/parser/mysql/contextCollect/entityCollector.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -546,8 +546,8 @@ describe('MySQL entity collector tests', () => {
546546
startIndex: 1057,
547547
startLine: 41,
548548
});
549-
550-
expect(functionEntity.columns).toBeNull();
551-
expect(functionEntity.relatedEntities).toBeNull();
549+
if (isFuncEntityContext(functionEntity)) {
550+
expect(functionEntity.relatedEntities).toBeNull();
551+
}
552552
});
553553
});

test/parser/postgresql/contextCollect/entityCollector.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ describe('PostgreSql entity collector tests', () => {
144144
endColumn: 2,
145145
});
146146
if (isCommonEntityContext(tableCreateEntity)) {
147-
expect(tableCreateEntity.columns.length).toBe(3);
147+
expect(tableCreateEntity.columns.length).toBe(2);
148148
tableCreateEntity.columns.forEach((columEntity) => {
149149
expect(columEntity.entityContextType).toBe(EntityContextType.COLUMN_CREATE);
150150
expect(columEntity.belongStmt).toBe(tableCreateEntity.belongStmt);

0 commit comments

Comments
 (0)