You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we can use Join to chain different searches using a common column name.
It would be nice to extend this to be able to Join a dataframe using a specified column name, that way we would be able to join f.ex. GrondwaterFilter with Boring.
Ok, nice. I didn't know yet about the Join functionality in owslib.
But if I understand correctly, this does not resolve #151 (even if the column name would be the same)? Because in #151 you query for something that does not exist?
Maybe it's easiest to adapt the column names of the different types in the dataframe to the same definition, now that we did not yet release anything? For example, change 'gw_id' in GrondwaterFilterSearch() to 'putnummer' of the BoringSearch()? That way we can use to above Join without having to do much remapping of column names for the joins?
I do agree that more consistency in naming would be good. While we can rename fields that are included in the default dataframes at the pydov side, this cannot be done for all other fields (f.ex. 'boringfiche' in the Filter service). They would need updating in the services themselves.
Currently, we can use Join to chain different searches using a common column name.
It would be nice to extend this to be able to Join a dataframe using a specified column name, that way we would be able to join f.ex. GrondwaterFilter with Boring.
F.ex.:
The text was updated successfully, but these errors were encountered: