Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop-reasons need some love #125

Open
1 of 3 tasks
johanix opened this issue Feb 11, 2022 · 1 comment
Open
1 of 3 tasks

Stop-reasons need some love #125

johanix opened this issue Feb 11, 2022 · 1 comment

Comments

@johanix
Copy link
Contributor

johanix commented Feb 11, 2022

  • There are still fail situations in various parts of the FSM processes that do not document a stop-reason
  • I've cleaned up the stop-reason code in all the join_*.go code (I think). Happiness is a negative diff. But the leave_ code is not updated and now directly wrong (it doesn't set the z.FSMStatus = "blocked" which we now require).
  • While z.SetStopReason(...) is hopefully suffient, the z.SetDelayReason() is not done.
@johanix
Copy link
Contributor Author

johanix commented Aug 23, 2022

#117 #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant