Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send comment notifications #158

Open
Timo-Breumelhof opened this issue Oct 30, 2019 · 3 comments
Open

Send comment notifications #158

Timo-Breumelhof opened this issue Oct 30, 2019 · 3 comments
Labels

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Oct 30, 2019

Is your feature request related to a problem?

Social interaction of blog posts could be improved.

Describe the solution you'd like

I would be good for interaction if the blog post "owner" would get an email if there are comments on his / her post.
It would also be nice if anybody commenting would (with opt-out) get an email when:
A. Someone replies to their comment
B. There are other comments

Somewhat related to #155

@WillStrohl
Copy link
Member

I just looked into the code a bit... There is notification logic in the module, but it's wrapped in code that will seemingly never execute. When a comment is added, it's saved to the database, and that's followed by a check to see if the comment is approved or not. If not, then no notifications are sent.

As a follow-up test, I just got latest and setup a quick dev environment. It seems that my original suspiscion was correct. It'll never generate a notification. I think the IF is just reversed.

image

@WillStrohl
Copy link
Member

I switched the IF statements, and the code runs without any issues, but the notification never is actually triggered even though the comments are set to auto-approve and I see they're approved in the database.

image

@WillStrohl
Copy link
Member

Oh, and one more thing... I had SMTP enabled, and at no point did I see any emails get generated to any party.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants