Skip to content
This repository was archived by the owner on Aug 23, 2024. It is now read-only.

Remove duplicative tests #177

Closed
mraineri opened this issue Jun 20, 2019 · 1 comment
Closed

Remove duplicative tests #177

mraineri opened this issue Jun 20, 2019 · 1 comment

Comments

@mraineri
Copy link
Contributor

There are many tests in the tool that validate things performed by other validators (specifically payload conformance). These tests should be removed, and the tool should focus on the protocol aspects of testing (HTTP headers, response codes, client payload handling, security, etc).

@billdodd
Copy link
Contributor

billdodd commented Aug 1, 2019

I've started looking through the assertions to identify ones that are duplicative or otherwise out-of-scope for this tool. I will keep notes here with that analysis.

  • TEST_datamodel_schema.py: The tests in this module validate the DMTF schemas or validate that service resource payloads adhere to the schemas. All the assertions in this model are (or should be) covered by the Redfish-Service-Validator (RSV), tools in https://github.com/DMTF/Redfish-Tools, or Travis CI tests in https://github.com/DMTF/Redfish. So this module can be eliminated entirely.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants