Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tenants to contain tenant_id attribute similar to clients #18

Open
mikelax opened this issue Jan 5, 2022 · 0 comments
Open
Labels
enhancement New feature or request question Further information is requested

Comments

@mikelax
Copy link
Collaborator

mikelax commented Jan 5, 2022

Feature Overview

Currently the clients object contains a client_id attribute that serves as a unique id for a given Client, though it is not the database primary key. There is a proposal in #16 to consider the client_id as a "url slug", in terms of the string pattern allowed.
The pattern proposed is: ^[a-z0-9-_]*$

For tenants, we currently only have a name attribute, and this can currently be any string. I would like to introduce a new attribute called tenant_id with the same string pattern enforcement. The code should then be refactored to use this id instead of the current implementation that requires but the name and iss_claim.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Additional context

Add any other context or screenshots about the feature request here.

@mikelax mikelax added the enhancement New feature or request label Jan 5, 2022
@mikelax mikelax changed the title Refactor tenants to contain tenant-id attribute similar to clients Refactor tenants to contain tenant_id attribute similar to clients Jan 10, 2023
@mikelax mikelax added the question Further information is requested label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant