Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Admin listRoles function to remove tenant related information #128

Open
mikelax opened this issue Oct 17, 2024 · 0 comments
Open
Labels
component: admin Administration related functionality good first issue Good for newcomers
Milestone

Comments

@mikelax
Copy link
Collaborator

mikelax commented Oct 17, 2024

Feature Overview

Is your feature request related to a problem? Please describe.

Currently, in the database listRoles function there is a case where the same role can be returned multiple times in the response. This can happen if the role belongs to a client, and this client is associated with multiple tenants.

Describe the solution you'd like

Refactor the function to remove the join condition to the tenants table and remove the tenant attributes from the response. In the scope of a Role object, the concept of tenant attributes doesn't actually make sense to include and confuses the function response.

Additional context

See this conversation in #126 for additional information and discussion.

@mikelax mikelax added good first issue Good for newcomers component: admin Administration related functionality labels Oct 17, 2024
@mikelax mikelax added this to the v3.0.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Administration related functionality good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant